Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp3896351rwd; Mon, 22 May 2023 23:24:36 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7JHl98mitYyO8LUNUgtfNf7MlObcG9hFswkcBL51hg8HxasXwF9g0zgF8cKz6mv9m4thl3 X-Received: by 2002:a05:6a00:14c4:b0:644:d220:64ac with SMTP id w4-20020a056a0014c400b00644d22064acmr17848202pfu.2.1684823075978; Mon, 22 May 2023 23:24:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684823075; cv=none; d=google.com; s=arc-20160816; b=j29T7m6sSTtREyoT7WTGz7Souc4QMPH2sN+8PeJO4S4YN5kJ0pRYV3GhTxwyaUiA8Y 7FazzsRxSlJahkUKIepag9YitOQGXMPRb50KtPJ10GQ8p45i1GOKnyFkroaem5ImsOyx Z0IjOgKgjaxC4yDid/4IFwEg1FSrdXSEgYBepjveQ1mvZZLdGqkJunCt+/HFFTB5vy66 5CzHhrgqtoFXVy847rD6MFUr3j9WKBkblKxAMrcAMOYlcu9bvi4srmMQnFCAmewQKS9v 8oGGY3ali62fO6iIpwJE4Zv4wXOSy0250POiZNap2JOmCEHFkwGN/6u6zVdYiyOZeNoW h8Zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=XOwI9zzx3UJYobf96lJIEe8i6rhkj/gDLVlyWRH4kEo=; b=OEljrTIUmETQc81aPt99rXTe9SLNrHF6yjvyv66MTZbdJLA43cQ0ZVEB7O/kLl3Z8N 29iEmlca1CiFG+p56qafwg1zjuC21WVVYAchiUn0HyduscXjYeOm2UW+SxYzCP9awIHU 4R6CYJk/YABzf1HWLQ30THDFaa6tnKVGgP/EBzTLOFJ39pWHY/4JgKuia2fWImn/ITFY a/RCZeTPUbE0bJcMCuwtCFRx1bFb1Ey8q2erAuWD55T3Iehi+PYRZ4dtoEQ3Ukk1/rq2 nu1cji9hstBU8LDC5H+rKe4qwCEF2URCGZDdd+f/4/IwAtOqMr3lcUo7UfBz4bzDuiGG 0T1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="cqq//bPa"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i18-20020a056a00005200b006466d7b68afsi1309934pfk.19.2023.05.22.23.24.21; Mon, 22 May 2023 23:24:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="cqq//bPa"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235201AbjEWGU3 (ORCPT + 99 others); Tue, 23 May 2023 02:20:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235200AbjEWGUX (ORCPT ); Tue, 23 May 2023 02:20:23 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23A721BD; Mon, 22 May 2023 23:20:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684822812; x=1716358812; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=kv+U3eR2t5jXrzu7bhE+tT5rUsZNuQI3uVH6Dk7rusQ=; b=cqq//bPah+oPEEmq1hxULMMLI4G6PPUbCiHkVNhPS5mYyZL4iXjtQ7ZK 5OGeEJi85vAegfpZItWyyqOxexWJZDV584CYn12RM1Dj1i3C8CRNMZHqW RhOKe7oNzhpOaA3TwHV3EBM44rfnCapY2dfSWU/SQp4osOSwyJfSQM5U+ CfFYiUgwcGidEC0KrFLviFyBVBqKZ7FMBxKfE7wzibnRnlWrbZ3KVm3ee ESxc0eJFbWTfwD+sm/viGdkWHj0PnGw6zESeImh8mZj8dGPEdlvwim+GT pvlmzVxgXozOwwEEIfXbVxsvJLafeFah0Xt7rSaIjQUWKpNzIDcuT89Lg g==; X-IronPort-AV: E=McAfee;i="6600,9927,10718"; a="351994164" X-IronPort-AV: E=Sophos;i="6.00,185,1681196400"; d="scan'208";a="351994164" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2023 23:20:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10718"; a="734636085" X-IronPort-AV: E=Sophos;i="6.00,185,1681196400"; d="scan'208";a="734636085" Received: from ganyifangubuntu20-ilbpg12.png.intel.com ([10.88.229.31]) by orsmga008.jf.intel.com with ESMTP; 22 May 2023 23:20:07 -0700 From: Gan Yi Fang To: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Looi Hong Aun , Michael Sit Wei Hong , Gan Yi Fang Subject: [PATCH net-next 1/1] net: stmmac: Remove redundant checking for rx_coalesce_usecs Date: Tue, 23 May 2023 02:19:52 -0400 Message-Id: <20230523061952.204537-1-yi.fang.gan@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.1 required=5.0 tests=AC_FROM_MANY_DOTS,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The datatype of rx_coalesce_usecs is u32, always larger or equal to zero. Previous checking does not include value 0, this patch removes the checking to handle the value 0. Signed-off-by: Gan Yi Fang --- drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c index 35c8dd92d369..6ed0e683b5e0 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c @@ -917,7 +917,7 @@ static int __stmmac_set_coalesce(struct net_device *dev, else if (queue >= max_cnt) return -EINVAL; - if (priv->use_riwt && (ec->rx_coalesce_usecs > 0)) { + if (priv->use_riwt) { rx_riwt = stmmac_usec2riwt(ec->rx_coalesce_usecs, priv); if ((rx_riwt > MAX_DMA_RIWT) || (rx_riwt < MIN_DMA_RIWT)) -- 2.34.1