Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c7e0574e-bfb2-fee7-2467-5f9cd8d335f5@kernel.org>
Date:   Tue, 23 May 2023 15:38:16 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: linux-next: build warning after merge of the scsi-mkp tree
Content-Language: en-US
To:     Stephen Rothwell <sfr@canb.auug.org.au>,
        "Martin K. Petersen" <martin.petersen@oracle.com>
Cc:     Niklas Cassel <niklas.cassel@wdc.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
References: <20230523133833.64560bf3@canb.auug.org.au>
From:   Damien Le Moal <dlemoal@kernel.org>
Organization: Western Digital Research
In-Reply-To: <20230523133833.64560bf3@canb.auug.org.au>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/23/23 12:38, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the scsi-mkp tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> drivers/ata/libata-scsi.c:3864: warning: Function parameter or member 'spg' not described in 'ata_mselect_control'
> 
> Introduced by commit
> 
>   df60f9c64576 ("scsi: ata: libata: Add ATA feature control sub-page translation")
> 

Martin,

This is missing:

diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index 69fc0d2c2123..c676b1e9b6c9 100644
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -3850,6 +3850,7 @@ static unsigned int ata_mselect_control_ata_feature(struct
ata_queued_cmd *qc,
 /**
  *     ata_mselect_control - Simulate MODE SELECT for control page
  *     @qc: Storage for translated ATA taskfile
+ *     @spg: sub-page of the control page
  *     @buf: input buffer
  *     @len: number of valid bytes in the input buffer
  *     @fp: out parameter for the failed field on error

Do you want me to send a fix patch or can you fold this in ?

-- 
Damien Le Moal
Western Digital Research