Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1de5b7fb-a39e-183a-1407-7d6489f706b4@nvidia.com>
Date:   Tue, 23 May 2023 07:22:18 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v3] gpio: tegra186: Check GPIO pin permission before
 access.
Content-Language: en-US
To:     Linus Walleij <linus.walleij@linaro.org>,
        Prathamesh Shete <pshete@nvidia.com>,
        Bartosz Golaszewski <brgl@bgdev.pl>
Cc:     thierry.reding@gmail.com, bgolaszewski@baylibre.com,
        linux-gpio@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org, smangipudi@nvidia.com,
        kyarlagadda@nvidia.com, Manish Bhardwaj <mbhardwaj@nvidia.com>
References: <Yz62XmiH8YG3Dtsf@orome> <20221007055936.5446-1-pshete@nvidia.com>
 <CACRpkdYkJdZ67kyTnDg3xFzO8MJhC0nHK98O+KJwCLBqV_5f-Q@mail.gmail.com>
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <CACRpkdYkJdZ67kyTnDg3xFzO8MJhC0nHK98O+KJwCLBqV_5f-Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UFFrKzd4TGZ4R3ZkM2lkeG1lbWdlU2FSa3FwSnk5N296VFltbHRaTHl2dXpz?=
 =?utf-8?B?QnM0WERQQmVsVEYxVW1lTUQwanNoYlNiMlQyQXdJQ0dQY0M2YWVTQVpQcENj?=
 =?utf-8?B?cER4SUxqRGFGejdJR25ZK1hhdWlhR0IxL2JDS1Jqazk5TDBhOVY5YXY3Ni9E?=
 =?utf-8?B?NFFPR2NpZEdMT3BFK2RLVkJod1IzYlpaNDF0VDVoNHdVM2FmSDhtYWM1L1ZB?=
 =?utf-8?B?ZjM2T05rTWlPSXdpcU1uV3lzaUI4b2Frd00vYUNJbENwZVl0VzBKSEFXdmFw?=
 =?utf-8?B?cHhqTWtYZHc1dkhGekJZSlpEcmNhL0prdWpWVzJNM1BidGV3WHNZSEljM0M1?=
 =?utf-8?B?dTVUWVczRFRPOGNYbUhFVEpIdXhQa0VkRENhQk1rQ2dWejhhSXp4U2RYTkJ1?=
 =?utf-8?B?dlNEamlUUzRBOVF0NHBibVFpOVFydVFBYjdQb0JOTkJFUVlBNTcrK0FOSGRq?=
 =?utf-8?B?YjlmQTZKblFMSThWMnFyVDVHQ2xIdnNYVEN5M2tXZ0tWeUpXOWxhaEloaWZV?=
 =?utf-8?B?NVBnTjRkUCsrRy84bFE5WEtUUjNwRzlmK05JbXBrNGlVMTcwdkZzYUcwbjF6?=
 =?utf-8?B?TUs2UEdCTHhDN1NJTnNHYjlmcnREYjVlcTgxNUNVNHA4YWhONmRNVHdNYUph?=
 =?utf-8?B?RTBKTzhqdVRwRStGK1V3NUJSZUxUaWVxN3RwN0ZvVHgzazA5eHRCSGJobVI5?=
 =?utf-8?B?a3JyTHpHeW8zRFpGRU1IN0tQTXk2QXVXeENsbzBWYVBUaGFpMlFkMnlzTVNz?=
 =?utf-8?B?VkxkNkdCSmE2UCs3SjVpYWViMk1Gb1BYTXdtUUt0TVBpYmxkOWZIdjVwZWVp?=
 =?utf-8?B?UlpUbXNjRGpqYnJDdEF3TzB4RTY3RVc3S2prV2FPeUtyZktrWUVINEpiMy8z?=
 =?utf-8?B?OU55dEN4R1BlMGZZeWEyN1o5azF0c1pabG9nbjg0NnlaWVhuOWVhNS9ZSVhX?=
 =?utf-8?B?Q0xpdW1Jd2RrMDBoaXJWeUdHa1hnVFZhMDlPdUwrQS9OazBaSC9JczMvdGxi?=
 =?utf-8?B?aEc2Ri9ieEoxSXRwSkRJcUxidGxCZ213Q0trMVo4TGtvVXVSSkkrQzkvL2ZJ?=
 =?utf-8?B?QjJZS2NuZGtyNmZPZFVwN2VJanhlckplRDhteGxVQnFlQ2lTaHBFZjN1WFNG?=
 =?utf-8?B?NWNZcnpxYXRjSk5CVzZUeG1xeFN1a2ZPc1VjMWdwUXJDZTNtTVdpY3BndUlQ?=
 =?utf-8?B?TUVVMFZpVXpFMExMRFhBdzZDSlEzWFlibFNMOVExK2Z0N0RUOFBHRUZSUFYz?=
 =?utf-8?B?QzZGRXcraUlTTE4vYlFuUXlCV0VvdFgvc3ZpRElKZGtadGdqandEUFhFWG9v?=
 =?utf-8?B?bHRoNUFybWFyYkVHbWs5YjAxS1pQWlVOTStuZjQ5K1p0RHhTaUU5djlLMEYy?=
 =?utf-8?B?SXlzZklxaHJDWlB3aWUzSW9BamJ3bmVxNEtpaXF3MmRkQlQyRytKUCtVZGU0?=
 =?utf-8?B?MnNCak5SMlp1ZGs1OW9wTW1jTk13VFR4MmV6b2UrNGoraVVPZGZuZXVVMm5M?=
 =?utf-8?B?ZGxQZllBaGo3WUxBT0lyVmp3SGtMZFdhZHRpaUgvOEdHZ1dQdkpRMFhVMFlI?=
 =?utf-8?B?azU0VVpHY2MwY2Iza210MDNheE1QTjRhQnAxaUN5cnFIenRIWGtxaU03cDFF?=
 =?utf-8?B?ZFFKSUtUd1RnSGtOa09ZRm9Ld3NIUG5hMXJ1QytDNkNOUHFjeHk0ZVVPZWVk?=
 =?utf-8?B?SlRrK1ROTHkwYnh5ZkNZam45cUE5cnVHa2xCdmlBNlFhRDUrbWFLN01yblh0?=
 =?utf-8?B?UTJGK25XNWU5LzV4T0hpSi92Y21meDJYQXVrRjJhL3pkdUo0MUZOQTBPTWty?=
 =?utf-8?B?cWZVTmtJOWlBa2V1Skd3TkhDQTVjUVJwK082YWJVL25Ld3pJYXduK3ZGZzVH?=
 =?utf-8?B?eWtERGhpcXlvVWRDTEVzUFdjMTdiMzk2N2o5YzNYcmJoRjkrd3Y2U2did3Z1?=
 =?utf-8?B?SU9SRm44MVY5M29saldXaS9Lbko4OW9uYndvaWg1bUozdUR3SHhyc1JCVWhy?=
 =?utf-8?B?WEszODNZY1BGbDZHYWhyQXJrL0JEQkVCVmt2eXFoeWFNSXIrZ0NCaGV2Z1pH?=
 =?utf-8?B?YStiWkxlUVRReUVNUC96Wmh1Z2dBYzV3UmZlb0QzV2VvU1Q0T29RK2ZGOVc5?=
 =?utf-8?B?VWVxV1VpYjg4eUN5a0lQL1diQ1lucTlVc253Rm5xRjRYNDFCdGtrUTdqeVhP?=
 =?utf-8?B?KzY3b0NJekU4YXkyYU1HelZQbXNXdEt3bWl3dmozMGRMOU5BODdUbCtjMXdv?=
 =?utf-8?B?UXRhUXk2RmJaT2F0dlBuTGtxM3hRPT0=?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f097d385-0985-4b67-c25c-08db5b5612bb
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 06:22:24.5292
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SZPyShZN32rCiSxCUnw46HR8e4NerUVFL8uJ8AnXMJSYgw8WH/zVGO7QWCeypFaqaRzdMiU+LQGGhgGJ4w4KKg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB8047
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 17/10/2022 10:31, Linus Walleij wrote:
> On Fri, Oct 7, 2022 at 7:59 AM Prathamesh Shete <pshete@nvidia.com> wrote:
> 
>> This change checks if we have the necessary permission to
>> access the GPIO. For devices that have support for virtualisation
>> we need to check both the TEGRA186_GPIO_VM_REG and the
>> TEGRA186_GPIO_SCR_REG registers. For device that do not have
>> virtualisation support for GPIOs we only need to check the
>> TEGRA186_GPIO_SCR_REG register.
>>
>> Signed-off-by: Manish Bhardwaj <mbhardwaj@nvidia.com>
>> Signed-off-by: Prathamesh Shete <pshete@nvidia.com>
> 
> Very nice patch!
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>


I did not see this anywhere in the mainline/next. However, I also 
noticed that we don't have the correct email address for Bartosz (again).

Bartosz, let me know if you can pick this up? Thierry also ack'ed 
previously for Tegra too.

FWIW ...

Acked-by: Jon Hunter <jonathanh@nvidia.com>

Thanks
Jon

-- 
nvpublic