Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 23 May 2023 14:21:30 +0800
From:   Yan Zhao <yan.y.zhao@intel.com>
To:     Robert Hoo <robert.hoo.linux@gmail.com>
CC:     <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <pbonzini@redhat.com>, <seanjc@google.com>
Subject: Re: [PATCH v2 5/6] KVM: x86: Keep a per-VM MTRR state
Message-ID: <ZGxbat2mM6AfOOVv@yzhao56-desk.sh.intel.com>
Reply-To: Yan Zhao <yan.y.zhao@intel.com>
References: <20230509134825.1523-1-yan.y.zhao@intel.com>
 <20230509135300.1855-1-yan.y.zhao@intel.com>
 <3f09e751-33fd-7d60-78cd-6857d113e8bd@gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <3f09e751-33fd-7d60-78cd-6857d113e8bd@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Yt8RRdnuWzdQaqifk4avN7/4Uk1zUvMzH3ooNfwLJdrGXX22p9j5prkW+GtW?=
 =?us-ascii?Q?Z8yDiEKCGjJzFOYItTF2tjNIRE6ZHxD/lPsmsSCQspNvg1trpVYK7XpMv+EJ?=
 =?us-ascii?Q?g5CGqlKAumflKl78KeDnDsMTqNKCg0ylVzygPrv0FTu7fK+xa6rqpLEqhE1/?=
 =?us-ascii?Q?B+TJB8jExYO5SMlJx1nMohagCqkJCZUHp2/JmfTpS5Xof5dOC5+T6HN+k6xr?=
 =?us-ascii?Q?954MaXR46pPmxWz6GXi4bNobredvu3IB24HibW0Z2luzKlqb5akjGlOnJQo0?=
 =?us-ascii?Q?XIQcok/NqVT3rGqczCr2j6/tETfnOF452XZR5mzo+BdyMHnVeZWsmlXk4KIE?=
 =?us-ascii?Q?1Z1v7Rma/KjA3gQR2b1EuuUrFRdTRyJxFUy4ofdkBMyl6MhZkF54IB6TdQGD?=
 =?us-ascii?Q?iydNmAR9AKskmbMnrMFEL4tgjedoODseER/a1zwN7xE+tQPlRK/l6K9eiQjl?=
 =?us-ascii?Q?kCcKzshB2PfbRkdYrl9Sucb448hvqJApx70HPYb2oT3nF/HqHsBGZb/IXDMf?=
 =?us-ascii?Q?6rRfY4QNWTISYE/nbMk3ms/PL9cnoKob5SiubZ5um+UFSouexLHJ9gAnKLVq?=
 =?us-ascii?Q?JNbk4qxY2anWA7QViBBNYVuRXlHWO2zji629BKBZB3C6hcXJiLd22uvPo2mO?=
 =?us-ascii?Q?8SIe0uog92s2uTLemqQFBOR1FGlhzSII+GyAfmzBNouUPWJ/P1dsDXsZRzij?=
 =?us-ascii?Q?fEszJNedKOWTSNqqg46KdG5JLsH4/pSlD6/d0Y84Cao/aHfJthZQbtKKP8fz?=
 =?us-ascii?Q?gRNJRevi46obdvMLAk6IJky9dGVo2yDkzwmaTxfg1LzQ31H/iwYafBuyTDfZ?=
 =?us-ascii?Q?jDcC3oAb3C54CFYv0PUPLnEC9d3c3quuRm1ei7G1bP9hr+YD23zKt8SOhTKE?=
 =?us-ascii?Q?fAMPK//sHKMBTWTQpSGGV28MlCCniaXIARYipVyCqtFPdFLyBCx6oHpsCaN7?=
 =?us-ascii?Q?0acIYRt0mMeLuS/yQChyM3Cy3AdPG1ppx/2kuvfBl1qHItKgywG3Ioo7gsbd?=
 =?us-ascii?Q?MxyhAdk0pf5Pa55qK4TmNIfTFFIbpx5x65iPcw7MKVdVNfv2zfXQfud7PIAI?=
 =?us-ascii?Q?ejGhdjjyg5FzhNX+pCZn0qpdzgnydvZN+WjKT3fjloAqAzTQcCHi1EQUFpEW?=
 =?us-ascii?Q?Yj7Q5m3cdEWQGpcI85+MM69cSr5qIMXR0ueQ2jc/jySnjJWvRsTHkJZo8ATL?=
 =?us-ascii?Q?1xYqny5Zf1RdyW6M0ijnumqh82w0gSXRHVV0fV9j9PWva/BN9ZPngVNnOz06?=
 =?us-ascii?Q?ChWof1nb70ic3Ad+rntYof1ML4VvS6CV1wdqF+9f1v3mz31Zv/dyqEI12Q+p?=
 =?us-ascii?Q?73/yckNkDfo/zP/tUpzBlq31OtmyCpmVZHlzU1yooFZuJqzRjpYx6NMRFeDD?=
 =?us-ascii?Q?wPc2CkS8ZKrC/DaJp/wx6HrSqVK3eTzvxYStw9e3MXYtynW6d2a8k3I8xsQ3?=
 =?us-ascii?Q?SxcagLKZPw/b9GTs6EVEdElp5OnTJOMrUEGcMxidmZaYC+AyKAQzDZ/6HMje?=
 =?us-ascii?Q?CiF4/S1bMnog0EryLUjPP6P7N0x28iJQgLZwhPBLKH51Bh7DZ0rlPuW1K78o?=
 =?us-ascii?Q?+h0bwKC8Q3kk0RGLs4RymEKWr0KmwZcqk1RrNsFg?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a532efbf-1fe2-4bb8-532e-08db5b597407
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5957.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 06:46:36.2239
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: POhmb83XTbj+KigIg0GqiRugJ+QrlZNX6v7RMFiboiQvjBAoKxYAbmr2ZVs83bJ6f7uSskEM48qRkdeQaJjTrg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6176
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, May 21, 2023 at 11:44:36AM +0800, Robert Hoo wrote:
> On 5/9/2023 9:53 PM, Yan Zhao wrote:
> > Keep a per-VM MTRR state and point it to the MTRR state of vCPU 0.
> > 
> > This is a preparation patch for KVM to reference a per-VM guest MTRR
> > to decide memory type of EPT leaf entries when noncoherent DMA is present.
> > 
> > Though each vCPU has its own MTRR state, MTRR states should be
> > consistent across each VM, which is demanded as in Intel's SDM
> > "In a multiprocessor system using a processor in the P6 family or a more
> > recent family, each processor MUST use the identical MTRR memory map so
> > that software will have a consistent view of memory."
> > 
> > Therefore, when memory type of EPT leaf entry needs to honor guest MTRR,
> > a per-VM version of guest MTRR can be referenced.
> > 
> > Each vCPU still has its own MTRR state field to keep guest rdmsr()
> > returning the right value when there's lag of MTRR update for each vCPU.
> > 
> Can we get rid of per-vCPU MTRR state copies and just have this per-VM state
> only? therefore can simplify implementation and avoid hazard of
> inconsistency among per-VPU MTRR states.
> 
> I see in SDM, it notes:
> "In multiple processor systems, the operating system must maintain MTRR
> consistency between all the processors in the system (that is, all
> processors must use the same MTRR values). The P6 and more recent processor
> families provide no hardware support for maintaining this consistency."
> 
> leaving each vCPU's MTRR is just to fully mimic HW?
>
Yes, leaving each vCPU's MTRR to mimic HW.

As also suggested in SDM, the guest OS manipulates MTRRs in this way:

for each online CPUs {
	disable MTRR
	update fixed/var MTRR ranges
	enable MTRR
}
Guest OS needs to access memory only after this full pattern.

So, I think there should not have "hazard of inconsistency among per-VPU MTRR
states".

I want to have per-VM MTRR state is because I want to reduce unnessary EPT
zap, which costs quite a lot cpu cycles even when the EPT is empty.

In this patch, per-VM MTRR pointer is used to point to vCPU 0's MTRR state,
so that it can save some memory to keep the MTRR state.
But I found out that it would only work when vCPU 0 (boot processor) is
always online (which is not true for x86 under some configration).

I'll try to find out lowest online vCPU and keep a per-VM copy of MTRR state
in next version.

Thanks!