Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 23 May 2023 07:47:05 +0100
From:   Conor Dooley <conor.dooley@microchip.com>
To:     Randy Dunlap <rdunlap@infradead.org>
CC:     <linux-kernel@vger.kernel.org>,
        Jaswinder Singh <jassisinghbrar@gmail.com>,
        Jaswinder Singh <jassi.brar@samsung.com>,
        Boojin Kim <boojin.kim@samsung.com>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Russell King <rmk+kernel@arm.linux.org.uk>,
        Vinod Koul <vkoul@kernel.org>, <dmaengine@vger.kernel.org>,
        <linux-riscv@lists.infradead.org>
Subject: Re: [PATCH] dmaengine: pl330: rename _start to prevent build error
Message-ID: <20230523-lushly-purr-9a93ea9f3573@wendy>
References: <20230523000606.9405-1-rdunlap@infradead.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="Z31axD9H5YaGMLWg"
Content-Disposition: inline
In-Reply-To: <20230523000606.9405-1-rdunlap@infradead.org>
Precedence: bulk

--Z31axD9H5YaGMLWg
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hey Randy,

On Mon, May 22, 2023 at 05:06:06PM -0700, Randy Dunlap wrote:
> "_start" is used in several arches and proably should be reserved
> for ARCH usage. Using it in a driver for a private symbol can cause
> a build error when it conflicts with ARCH usage of the same symbol.
>=20
> Therefore rename pl330's "_start" to "_start_thread" so that there
> is no conflict and no build error.

_start_thread() seems pretty generic to me too, but there don't appear
to be any users & it is certainly better than the one causing build
issues!

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

>=20
> drivers/dma/pl330.c:1053:13: error: '_start' redeclared as different kind=
 of symbol
>  1053 | static bool _start(struct pl330_thread *thrd)
>       |             ^~~~~~
> In file included from ../include/linux/interrupt.h:21,
>                  from ../drivers/dma/pl330.c:18:
> arch/riscv/include/asm/sections.h:11:13: note: previous declaration of '_=
start' with type 'char[]'
>    11 | extern char _start[];
>       |             ^~~~~~

--Z31axD9H5YaGMLWg
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZGxhZQAKCRB4tDGHoIJi
0rdIAP0Wabw96Kn9nVf+19fFM6AKRhl6z6gMm92JhKoWeudwbgEA7e0bLMA81R1s
DRBqxN4TNE5YBg3iPigE5gMne6P0KQ4=
=sBDX
-----END PGP SIGNATURE-----

--Z31axD9H5YaGMLWg--