Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c183a3d8-f2d8-b31e-4121-5e04c26114d9@quicinc.com>
Date:   Tue, 23 May 2023 12:32:41 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH 4/5] sched: make task_vruntime_update() prototype visible
Content-Language: en-US
To:     Arnd Bergmann <arnd@kernel.org>, Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>
CC:     Arnd Bergmann <arnd@arndb.de>, Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Valentin Schneider <vschneid@redhat.com>,
        <linux-kernel@vger.kernel.org>
References: <20230522195021.3456768-1-arnd@kernel.org>
 <20230522195021.3456768-5-arnd@kernel.org>
From:   Mukesh Ojha <quic_mojha@quicinc.com>
In-Reply-To: <20230522195021.3456768-5-arnd@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 5/23/2023 1:20 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Having the prototype next to the caller but not visible to the callee causes
> a W=1 warning:
> 
> kernel/sched/fair.c:11985:6: error: no previous prototype for 'task_vruntime_update' [-Werror=missing-prototypes]
> 
> Move this to a header, as we do for all other function declarations.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


LGTM.
Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>

-- Mukesh

> ---
>   kernel/sched/core.c  | 2 --
>   kernel/sched/sched.h | 1 +
>   2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 044bcdf4181a..aae6ff717c55 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -6030,8 +6030,6 @@ static inline struct task_struct *pick_task(struct rq *rq)
>   	BUG(); /* The idle class should always have a runnable task. */
>   }
>   
> -extern void task_vruntime_update(struct rq *rq, struct task_struct *p, bool in_fi);
> -
>   static void queue_core_balance(struct rq *rq);
>   
>   static struct task_struct *
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index 44b34836bb60..d5ac0af1eede 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -1245,6 +1245,7 @@ static inline raw_spinlock_t *__rq_lockp(struct rq *rq)
>   
>   bool cfs_prio_less(const struct task_struct *a, const struct task_struct *b,
>   			bool fi);
> +void task_vruntime_update(struct rq *rq, struct task_struct *p, bool in_fi);
>   
>   /*
>    * Helpers to check if the CPU's core cookie matches with the task's cookie