Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4fb844d4-cb8e-94af-b2bc-2d1e8ea83c09@quicinc.com>
Date:   Tue, 23 May 2023 12:52:30 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH 3/5] sched: fair: hide unused init_cfs_bandwidth() stub
Content-Language: en-US
To:     Arnd Bergmann <arnd@kernel.org>, Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>
CC:     Arnd Bergmann <arnd@arndb.de>, Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Valentin Schneider <vschneid@redhat.com>,
        <linux-kernel@vger.kernel.org>
References: <20230522195021.3456768-1-arnd@kernel.org>
 <20230522195021.3456768-4-arnd@kernel.org>
From:   Mukesh Ojha <quic_mojha@quicinc.com>
In-Reply-To: <20230522195021.3456768-4-arnd@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 5/23/2023 1:20 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> init_cfs_bandwidth() is only used when CONFIG_FAIR_GROUP_SCHED is
> enabled, and without this causes a W=1 warning for the missing prototype:
> 
> kernel/sched/fair.c:6131:6: error: no previous prototype for 'init_cfs_bandwidth'
> 
> The normal implementation is only defined for CONFIG_CFS_BANDWIDTH,
> so the stub exists when CFS_BANDWIDTH is disabled but FAIR_GROUP_SCHED
> is enabled.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>

-- Mukesh

> ---
>   kernel/sched/fair.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 2c1b345c3b8d..a7a8ccde3bd7 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -6169,9 +6169,8 @@ static inline int throttled_lb_pair(struct task_group *tg,
>   	return 0;
>   }
>   
> -void init_cfs_bandwidth(struct cfs_bandwidth *cfs_b) {}
> -
>   #ifdef CONFIG_FAIR_GROUP_SCHED
> +void init_cfs_bandwidth(struct cfs_bandwidth *cfs_b) {}
>   static void init_cfs_rq_runtime(struct cfs_rq *cfs_rq) {}
>   #endif
>