Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230522045806.3442-1-raag.jadav@intel.com>
In-Reply-To: <20230522045806.3442-1-raag.jadav@intel.com>
From:   Bartosz Golaszewski <brgl@bgdev.pl>
Date:   Tue, 23 May 2023 10:22:50 +0200
Message-ID: <CAMRc=McL-yuUSTMiWn56Q26ZYKoLTx1yYTRsygLQsKRbAgsR5Q@mail.gmail.com>
Subject: Re: [PATCH v1] gpio: tangier: calculate number of ctx using temporary variable
To:     Raag Jadav <raag.jadav@intel.com>
Cc:     linus.walleij@linaro.org, andriy.shevchenko@linux.intel.com,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        mallikarjunappa.sangannavar@intel.com, pandith.n@intel.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, May 22, 2023 at 6:58=E2=80=AFAM Raag Jadav <raag.jadav@intel.com> w=
rote:
>
> Utilize a temporary variable to calculate number of ctx from ngpio
> inside ->probe() implementation.
> While at it, include math.h for using DIV_ROUND_UP().
>
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> ---
>  drivers/gpio/gpio-tangier.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-tangier.c b/drivers/gpio/gpio-tangier.c
> index e990781935ba..7ce3eddaed25 100644
> --- a/drivers/gpio/gpio-tangier.c
> +++ b/drivers/gpio/gpio-tangier.c
> @@ -16,6 +16,7 @@
>  #include <linux/interrupt.h>
>  #include <linux/io.h>
>  #include <linux/irq.h>
> +#include <linux/math.h>
>  #include <linux/module.h>
>  #include <linux/pinctrl/pinconf-generic.h>
>  #include <linux/spinlock.h>
> @@ -428,10 +429,11 @@ static int tng_gpio_add_pin_ranges(struct gpio_chip=
 *chip)
>  int devm_tng_gpio_probe(struct device *dev, struct tng_gpio *gpio)
>  {
>         const struct tng_gpio_info *info =3D &gpio->info;
> +       size_t nctx =3D DIV_ROUND_UP(info->ngpio, 32);
>         struct gpio_irq_chip *girq;
>         int ret;
>
> -       gpio->ctx =3D devm_kcalloc(dev, DIV_ROUND_UP(info->ngpio, 32), si=
zeof(*gpio->ctx), GFP_KERNEL);
> +       gpio->ctx =3D devm_kcalloc(dev, nctx, sizeof(*gpio->ctx), GFP_KER=
NEL);
>         if (!gpio->ctx)
>                 return -ENOMEM;
>
> --
> 2.17.1
>

Applied, thanks!

Bartosz