Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp4062934rwd; Tue, 23 May 2023 02:31:18 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ58tlbHLLvf5IUcgiUILoOAJxSp1EE0HG6R92NYGOGVZNYTxaR39qbzXD9r5h6I67lcGjFI X-Received: by 2002:a05:6a20:3d07:b0:10b:1c98:59b2 with SMTP id y7-20020a056a203d0700b0010b1c9859b2mr9535160pzi.21.1684834277947; Tue, 23 May 2023 02:31:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684834277; cv=none; d=google.com; s=arc-20160816; b=X51hhi8PxJpEAMhQnIwcluUm23L/aucnQiJm+zy91s75l+Slraz5ZEqYtJXE9Ufnc1 7hbagcEi/Hu0GjedDg0dyxaGXJnP2q6oXBcGBknGxo0EMqtWXw/xZ08sTzY4UdSmI1nc H2sS01u2vsF9NfOo1+kT7KrtDm0HAKLqqq532jYr3We7xL3aiDygT0Wp9ugZqNn2Y3cw ZbBx9p8N9EncsnQdY7+s8BgsDR/FFbb6ixUkifyMFwdLQWbjkeFCc1Pcp/iMzXhfs3EG y5rLDPUgfkn1B0TTmnGkd0Kk0XC33QVbvJ4Dp21gXmwMPs18hnZHY8nBcBNEe2rSkiGQ V0iQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=MJ4gfQMRLLGzI6fgaFo6TdtmDQc4Q0vgwfnA86uBCt0=; b=C1Fxx4uAaGfevA3gk4Nll5evCL8ALa7besrIXwndZDzg404yrTRG8QZ3pf/UHskaJ3 TSX9Yflo17JNa3u+nD6cLscUKHJhMl/YVMWx+BBO08xUcqRmCuAXj2RcyevtUgWUYY0U nMj/mtkz5+54a1Z1i8GZY1IQDGGVR0b2XZ28bBAQNfep7IBLYVjZZZQX5HIi0HoJHroj pOOAYuAM/a8NYcteJH0vpBxkqZJudy/Zn2fpRCmVVn3vdF5jcCJnQO5kxVWesj53mtEg kft022tGyZtfDivyrsjVTQw/cD/z9gqzW9KthOJ1IcObPJUAqoVW4v7N7TP8ddx1PoIy IygA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l20-20020a17090ac59400b002508889985fsi8212471pjt.95.2023.05.23.02.31.03; Tue, 23 May 2023 02:31:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235332AbjEWJNy (ORCPT + 99 others); Tue, 23 May 2023 05:13:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236090AbjEWJNx (ORCPT ); Tue, 23 May 2023 05:13:53 -0400 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 50E3012B; Tue, 23 May 2023 02:13:45 -0700 (PDT) Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1q1O5L-0007MY-01; Tue, 23 May 2023 11:13:39 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 83A17C02E6; Tue, 23 May 2023 11:09:13 +0200 (CEST) Date: Tue, 23 May 2023 11:09:13 +0200 From: Thomas Bogendoerfer To: Keguang Zhang Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] MIPS: Loongson32: Remove reset.c Message-ID: <20230523090913.GF9484@alpha.franken.de> References: <20230511120648.463221-1-keguang.zhang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230511120648.463221-1-keguang.zhang@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_PASS,T_SCC_BODY_TEXT_LINE,T_SPF_TEMPERROR autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 11, 2023 at 08:06:48PM +0800, Keguang Zhang wrote: > Commit 2a31bf20808a ("watchdog: loongson1_wdt: Implement restart handler") > implmented .restart ops, Then, _machine_restart is no longer needed. > The _machine_halt and pm_power_off are also unnecessary, > which contain no hardware operations. > > Therefore, remove the entire reset.c and related header file. > Update the Makefile accordingly. > > Signed-off-by: Keguang Zhang > --- > V2 -> V3: Update the commit message > V1 -> V2: Remove the reference to regs-wdt.h > --- > .../include/asm/mach-loongson32/loongson1.h | 1 - > .../include/asm/mach-loongson32/regs-wdt.h | 15 ------ > arch/mips/loongson32/common/Makefile | 2 +- > arch/mips/loongson32/common/reset.c | 51 ------------------- > 4 files changed, 1 insertion(+), 68 deletions(-) > delete mode 100644 arch/mips/include/asm/mach-loongson32/regs-wdt.h > delete mode 100644 arch/mips/loongson32/common/reset.c applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]