Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\))
Subject: Re: [PATCH v2 3/3] dt-bindings: mfd: stpmic1: add fsl,pmic-poweroff
 property
From:   =?utf-8?Q?Sean_Nyekj=C3=A6r?= <sean@geanix.com>
In-Reply-To: <20230516-footprint-handoff-bcd553ff6146@spud>
Date:   Tue, 23 May 2023 11:55:50 +0200
Cc:     robh+dt@kernel.org, Lee Jones <lee@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        pascal Paillet <p.paillet@foss.st.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <9B1EE405-77D3-4980-9A13-9D4F87C1A64F@geanix.com>
References: <20230516132225.3012541-1-sean@geanix.com>
 <20230516132225.3012541-3-sean@geanix.com>
 <20230516-footprint-handoff-bcd553ff6146@spud>
To:     Conor Dooley <conor@kernel.org>
Precedence: bulk

Hey Conor,

> On 16 May 2023, at 20.06, Conor Dooley <conor@kernel.org> wrote:
>=20
> Hey Sean,
>=20
> On Tue, May 16, 2023 at 03:22:24PM +0200, Sean Nyekjaer wrote:
>> Document the new optional "fsl,pmic-poweroff" property.
>>=20
>> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
>> ---
>> Documentation/devicetree/bindings/mfd/st,stpmic1.yaml | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>=20
>> diff --git a/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml =
b/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
>> index 9573e4af949e..5183a7c660d2 100644
>> --- a/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
>> +++ b/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
>> @@ -26,6 +26,14 @@ properties:
>>=20
>>   interrupt-controller: true
>>=20
>> +  st,pmic-poweroff:
>> +    $ref: /schemas/types.yaml#/definitions/flag
>> +    description: |
>> +      if present, configure the PMIC to shutdown all power rails =
when
>> +      power off sequence have finished.
>> +      Use this option if the SoC should be powered off by external =
power management
>> +      IC (PMIC).
>=20
> Just reading this description, this is sounding quite like a "software
> behaviour" type of property, which are not permitted, rather than
> describing some element of the hardware. Clearly you are trying to =
solve
> an actual problem though, so try re-phrasing the description (and
> property name) to focus on what exact hardware configuration it is =
that
> you are trying to special-case.
> Krzysztof suggested that the samsung,s2mps11-acokb-ground property in
> samsung,s2mps11.yaml is addressing a similar problem, so that could be
> good to look at.

Better wording?
      Indicates that the power management IC (PMIC) is used to power off =
the board.
      So as the last step in the power off sequence set the SWOFF bit in =
the
      main control register (MAIN_CR) register, to shutdown all power =
rails.

>=20
> Also, the dt-binding patch should go before the patch adding the
> property to the driver.
>=20

I will switch them around.

> Thanks,
> Conor.

/Sean