Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 23 May 2023 13:04:12 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Gan Yi Fang <yi.fang.gan@intel.com>
Cc:     Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Looi Hong Aun <hong.aun.looi@intel.com>,
        Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>
Subject: Re: [PATCH net-next 1/1] net: stmmac: Remove redundant checking for
 rx_coalesce_usecs
Message-ID: <ZGydrKQg6RsL1qHo@corigine.com>
References: <20230523061952.204537-1-yi.fang.gan@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230523061952.204537-1-yi.fang.gan@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?cqQ/ab07RN0lkISIP1C2cxdaqQI4IrcAf0PQINS0OEG6ue22qZtWzQdEBY6N?=
 =?us-ascii?Q?NlsAzgGZYNXQ+RXmDjod9p2cxiDwklxGNGdzlzHdJC3n0Z/iHFw3GKfVVQTA?=
 =?us-ascii?Q?Iu72iqmNNWRhIqyvsPXZINPKgUZJ634GAixi9I1GUy1TOjlHhZu/KaQyaXxi?=
 =?us-ascii?Q?/968K35nMWVMD8AggGgk93ax+kPSeYQ3rQjzE/zOKn4Udt4slQPafg48VUDj?=
 =?us-ascii?Q?c5YZ3M1+RztZNJZGTLb3Lc7Ma03tNHRYyJefRCrvvK8Ja3by71MXvkqlOj2/?=
 =?us-ascii?Q?A9heB4PjTZ7u0ZZghyx29NzIrRzeKkDxs4NMjghJfXf2uRQjQAWCmP5EgTm7?=
 =?us-ascii?Q?rwszPwvItds+iNx7dh4+SnELbXvrxrLXCueAo2w/ab9FaoruODkXUDJDgptj?=
 =?us-ascii?Q?oMgZ7kXuNAi5VJUwD1dQLPIlDZ1s7cJ+Zv0D4k8Rakbu5Lh5Sh3PTLv7Z/DC?=
 =?us-ascii?Q?PAM9i6bm2MGQzuaWNYuTxHItmkBNcUxssumNgcWrhEQzUXfCFH7wXPj1E852?=
 =?us-ascii?Q?Lqi5Wli0leMG6BUGM+/0cHFRHxNzaVbXnwe4FM9GGSkmp5umFexlVkq4d2IB?=
 =?us-ascii?Q?diIR3kE535W1SKMxXs8V0QKnwic37suKO/Ik5dbsifdlsd6amglXJIgBM0uA?=
 =?us-ascii?Q?mhQbEftZwqbcx1wAWlTNFDO4YXsYp6Hxshge7dEqvxbcx0suJo+9kKZhWLL+?=
 =?us-ascii?Q?l+q+xMF+rEz5c18pYEZMybwNRUbVRGDz4m2P5PLeAoQ2fHePDi3OFX3Y7IU7?=
 =?us-ascii?Q?oEv5W0gRUdMod/3WpY8hyh7JRP3C+IqFHPBw1l5hRcNPPEYqiFC62hUHsQt7?=
 =?us-ascii?Q?p7tPaQwW0/u5yjKRgAODlzgTciSsO1lXAUz+TTCE4JqD1P2qnCH+JXphXSY1?=
 =?us-ascii?Q?1rwELg2/oBYCvNq6dyELCAjLDiLmolzFxEuCVeZhSiDgnn30hSGafclqV7Iy?=
 =?us-ascii?Q?w+B+5s7fqtuy4LvmR9m/qWCvVukIS8Sz8jKwyi/W5iSasL5sI9UyiNH4LQuB?=
 =?us-ascii?Q?e4GgRhfWDIdaIwJBqmllaB0oaos0VwwZBa5UN/F5Vt81dzIzyeVZuvypJ4vP?=
 =?us-ascii?Q?qmbhHcPbfTElmTC2H29jnTWXMN6tgoRCY50WDhevPSIeO+JHN4u8+ISS9d5d?=
 =?us-ascii?Q?qWbQ+dp+d6FZNKI3oWqdW64JQ9o80U5VWLJoUu1hK3gd7hx42P71hLJY6htb?=
 =?us-ascii?Q?eMiojFQuWveowGMny1SI/hB3zM5/OB4dJXgdUFM7iPnJ8JyUAY8epfxFwOTB?=
 =?us-ascii?Q?nYSFPJdBlxjGL5bx4sLKQT64CaVxAMvVXj72jL1sG7TC12eLcgSEnqSwnIku?=
 =?us-ascii?Q?qmoMj6VxpS/kHR6sH0N45CRTmo6CfZ5SgXvrg01Lxj/dP7U2sAcf0by4LlUy?=
 =?us-ascii?Q?IazyXGySKyjuk4mJkcQDzQA3GYFBmIMPP4NlIm/H73uxNRpNINSN/Zd9Lp3+?=
 =?us-ascii?Q?0yliNUQg4WoE4EPMPgqmgvhCUfn36m+nGr41wsErfkHAV/EVb0ubTIEXXBMd?=
 =?us-ascii?Q?jPrChcSwLLG+ywHneBHbwYi7M063TuYw7F6i/TIzgIjt5vux0lrocLlAwzCS?=
 =?us-ascii?Q?hPOr+rsOHzSKGS+vyFLhBtYh+CK1w/pxN36TEw2ZvBVTzkZ6lQ4p+aYH1jSp?=
 =?us-ascii?Q?necOKkW3GRxVj7QVyO0TXgNhN3Pcy0T8ZfOdqriHfmVaIqvJTGVFYOPjMVye?=
 =?us-ascii?Q?wZ0RtQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f6d0cd89-a673-4810-e062-08db5b7d7526
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 11:04:19.9208
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pzTiGOr7FsorKK5U2FP59cQrLQ2+wpKM84JrSHygZyty5uGiJgAw2nUow/vx6KKPbjxfVaulbG8JO6L2LxXI2RyYp2ltvcaknGgsQgm8kRE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR13MB6527
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 23, 2023 at 02:19:52AM -0400, Gan Yi Fang wrote:
> The datatype of rx_coalesce_usecs is u32, always larger or equal to zero.
> Previous checking does not include value 0, this patch removes the
> checking to handle the value 0.
> 
> Signed-off-by: Gan Yi Fang <yi.fang.gan@intel.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>