Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp4188051rwd; Tue, 23 May 2023 04:37:13 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5HcNzeta/kfFEjA9pskyv30ZOGp7q1rmRhfZ/1U2z0HvZc/gKeExjdpNrvgo4yIaMikjvZ X-Received: by 2002:a05:6a00:2282:b0:63f:18ae:1d5f with SMTP id f2-20020a056a00228200b0063f18ae1d5fmr19931306pfe.29.1684841833029; Tue, 23 May 2023 04:37:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684841833; cv=none; d=google.com; s=arc-20160816; b=H65LwPSziE1CGtqBwGN7tprtXbs3aQfh5M6NxfZcdVRU/HSR4ovOvaqmxcw8kdeyfz XSqkh9X0Jo3m3YJy42SqIYMJnPaId60YZM887BQ3dxhTxfdNKQlaO+wGdf3VLUIi9SnC EexSionUtbEHPCMWzfvHgX7ZQWflCdUXtRy1ICDFcyq5c8xKlTs6VOnRfvmfudcm7Ji7 wsDFtJ2EK3iMSx8ofT5p0eBziqn+gDGUgGXRiiYuD0XLBj1/WF2eETlFHRtpyEMCYvIa 0Iy6ZOCa8pVrA1S5QU0C+NouKAgYQmS2dlufyaYMgTN8OZPYCa/uXr+TD69J5j7HMpEg dsYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=dpq73DY3Q6Vvrg4NdhEibDQtlEcBu/1qSSW1eGUxOMY=; b=o5KMeCShJEHOJEkArjc3B0kYnuJW41UURT5TA3KXlydHYtD34RgynvFiKqqRZ+mHZY ecTqpWD2gNRUioEINgOVoOUXg0Nx3aKiUyhij5CPWYp2FuwGgD/9k6oYqvMdSFkaacyr UjXlwqA/Kls0VwvSoWqrlcza3z1HHTCE7GCTAz1PIPxf/p3VQ+rDNYsb1yD+QrL1qUUn LwvhoOVKShA0AiPS+9hyiA87myxRROm83gZ6Po7lVM+aUe8dL2Hk2DOPc0D20tr8sJoU TQ7x4VhqysNaPP7opuIbYVkKZXT2lIIW49brg7k8JVWWYjcyavgtMWRK3ETKyxx8/gyz qmJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="BR5E/sYa"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z5-20020aa79905000000b0064d5ae89c7fsi4961970pff.334.2023.05.23.04.37.00; Tue, 23 May 2023 04:37:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="BR5E/sYa"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236163AbjEWLKI (ORCPT + 99 others); Tue, 23 May 2023 07:10:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236041AbjEWLKH (ORCPT ); Tue, 23 May 2023 07:10:07 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4574192 for ; Tue, 23 May 2023 04:09:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684840161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dpq73DY3Q6Vvrg4NdhEibDQtlEcBu/1qSSW1eGUxOMY=; b=BR5E/sYaCYveT2a3X14Tb7Uvy60yy8JobyY/woiVigimXhB5xxvrMxeE69XyQwqsDmW5jd OWZ+cvqTrc2vF9nlHLby4Yj/kz9gVMcrvufBtufZi7WUtFO3nfbB5rk/qU8Lbf4pttqFHp 0NAwMOgOPKHPOuXzCLhJ/Xz78NrUodA= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-526-pHre70WcPjGg0y506bMRVQ-1; Tue, 23 May 2023 07:09:20 -0400 X-MC-Unique: pHre70WcPjGg0y506bMRVQ-1 Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-5118fc8abd0so813071a12.1 for ; Tue, 23 May 2023 04:09:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684840159; x=1687432159; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dpq73DY3Q6Vvrg4NdhEibDQtlEcBu/1qSSW1eGUxOMY=; b=I8/hEZ4dtg2W80VIYXJkBucfaV+1KLGMVDHbUoHraqM7iNuzynIiScKixwO4QVXDdv WTKRNw/iNSLtzgJiCVP/v0dIbW/CyMrO4tI7xfidS/1Q86E9DUVaDn3wRNdtcWs7f0YF fG0MHh0zfmBb0U/QIMgfIR0BkiS5xctr7hr6ToXvvfuMw+FiWH19H2QNYhPgE/CKzhM8 QWfK+wCq4AVoS9wHI0xWwKc75aBLv0CAq4k9KpBpF3FxUMimpbjJdjMpiLG4Y+7mRpeB lJQf3n78MvTWECkjAjOxNNpMgeRCLA5/maTjKWVYB2xhwcpuy+Q6lRxAo+37i4UdKWZf mS4w== X-Gm-Message-State: AC+VfDyQ5O0v5bd6zn22n5xo9kKOTJUSHRtAqynb3rVwefesc03qjSKY n7ea2HPMEFW425qfvx8c4iDCmaFhTzc4KSewz9GusHBAYUI+SUB4QD7TeUKhtma4aJO3kj4bTfs QCnzmnVoPofnbWHODlpKhePOL X-Received: by 2002:a50:fb16:0:b0:510:d9b3:11fb with SMTP id d22-20020a50fb16000000b00510d9b311fbmr10425650edq.40.1684840159553; Tue, 23 May 2023 04:09:19 -0700 (PDT) X-Received: by 2002:a50:fb16:0:b0:510:d9b3:11fb with SMTP id d22-20020a50fb16000000b00510d9b311fbmr10425639edq.40.1684840159295; Tue, 23 May 2023 04:09:19 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id z17-20020aa7cf91000000b004c2158e87e6sm4032154edx.97.2023.05.23.04.09.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 May 2023 04:09:18 -0700 (PDT) Message-ID: Date: Tue, 23 May 2023 13:09:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] platform/x86: lenovo-yogabook: add I2C dependency Content-Language: en-US, nl To: Arnd Bergmann , Mark Gross Cc: Arnd Bergmann , Andy Shevchenko , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230519082606.375471-1-arnd@kernel.org> From: Hans de Goede In-Reply-To: <20230519082606.375471-1-arnd@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On 5/19/23 10:25, Arnd Bergmann wrote: > From: Arnd Bergmann > > The added platform_driver support fails to link when I2C core support is > not rechable: > > x86_64-linux-ld: drivers/platform/x86/lenovo-yogabook.o: in function `yogabook_pdev_probe': > lenovo-yogabook.c:(.text+0x5a5): undefined reference to `i2c_bus_type' > > Add a Kconfig dependency to enforce a working configuration. > > Fixes: 6df1523fa0b7 ("platform/x86: lenovo-yogabook: Add platform driver support") > Signed-off-by: Arnd Bergmann Thank you I have pushed this to pdx86/for-next now. Regards, Hans > --- > drivers/platform/x86/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > index 9fe974d5f645..63637ea99c2f 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -125,6 +125,7 @@ config YOGABOOK > tristate "Lenovo Yoga Book tablet key driver" > depends on ACPI_WMI > depends on INPUT > + depends on I2C > select LEDS_CLASS > select NEW_LEDS > help