Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp4273867rwd; Tue, 23 May 2023 05:49:00 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4ppElFviYhCUU+SK2Je/6pvw2oDWikG5dJI+TurRzJVVHZ3GGLhykSCo1owfNIG/H9J7wV X-Received: by 2002:a05:6a20:9153:b0:100:11c9:8c06 with SMTP id x19-20020a056a20915300b0010011c98c06mr15259701pzc.18.1684846140166; Tue, 23 May 2023 05:49:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684846140; cv=none; d=google.com; s=arc-20160816; b=JSmojfYNSfo8/B3zD7afUYx3TA2Ujsyp2/BTmNStS43v6mj398eowJ/6aXlDet5rg9 wkztMgcJuCk000yDmWzPGqLTwvjKjs9I3KEzY+dTPUszOZO3oaCZcugeskOPRSr7Arql XBYRw6eOsIgbJrW/W3a2kKfaMiAzLfdccQeke1ytdHJa9pybWw8ga1oNcBMlK3KmqvYX 5jtTftRX0AYuAQNUOfqijjWT3HbiLdvT6KSuCAH84Vs/ibJw1aMRB6yvg2gzz/+Nv6bL JMB6XmA7AAx+VakJCsuMRYblfGk9cHk1buzvMFBNUlKeOeM2TvoxXqLvnlZhxP8R6HVY ReEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=S9Zd2magyachyLa76nXi6SNVfb4lbnmMLO9aj50gs8U=; b=uV9BxvJ9Zw6NTwCui8VIBEcv4ZiTmVALdcLXwWPQuaew1HvCNBVF/JFOT4Rm9/pkVY ym4LAfQdIMnGReVs8i5p7ttRmTNxGf1PazASJmxfnzZGFFgf5y7M/Sjaj58Jx8koij20 sYkk8Iv0xCX2ujhnXREn0rSDMKbr+9x4SfIG0s6raFKePgLdoySBmue7FK+fDIf5oROv 3ey/KbufINMtQjOBf5+Yb4pZe4SU/fgXWcbskSdqGRDGxlZ8Q6uw2AcAabPWwdkh4UZY oSYwEkK5WWOSmgaJkIcNJevort2f73meVw8xgnrWj96ZGFnY0Il6WTIeKjgWxgtKLNCD Qh7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tsJt2ZMG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k71-20020a62844a000000b0063b8a054e06si1572292pfd.259.2023.05.23.05.48.47; Tue, 23 May 2023 05:49:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tsJt2ZMG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236943AbjEWMfr (ORCPT + 99 others); Tue, 23 May 2023 08:35:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236932AbjEWMfq (ORCPT ); Tue, 23 May 2023 08:35:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1443C118; Tue, 23 May 2023 05:35:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9621B62877; Tue, 23 May 2023 12:35:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B897CC433D2; Tue, 23 May 2023 12:35:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684845339; bh=u5mv3oHXC56HjI2PT+W2P28h07N+KAV9oli2njljAUQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tsJt2ZMGlEFFghj3Uk2r2mtJQ27DlaXhKf/RUJonBOkx0K8nP6Wrpcy+FtTmqI0RS lI87w/XrmQ1hEaK4B3nsUQqXfPz7E+ZDsUM9TtjEW0RGIU2kjLanDYtAxFH+G5x5MZ Rs8fB4bfJSadDYzTM/IkeJ16LcXs2C3SveGeLllZ4E3hDk1Hm+AfwTObpj8VtWNRO+ PeLKCq6+8WSeuHz7XoTvdCsx4FEsvdJHokEVnS3x/K1h1TDcmuVijh2s1a8LJlCowo 8qvUhGAyJ/k6spJX3i+sNA+dlkPSFVPpwb0RFIqIElPXdaHL9+1vQK/xZ8spbDPv/S hj99yo81V7Dvw== Date: Tue, 23 May 2023 14:35:26 +0200 From: Christian Brauner To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, John Hubbard , Dave Chinner , Christoph Hellwig Subject: Re: [PATCH v21 1/6] iomap: Don't get an reference on ZERO_PAGE for direct I/O block zeroing Message-ID: <20230523-taschen-erfinden-3bd7c39beeda@brauner> References: <20230522205744.2825689-1-dhowells@redhat.com> <20230522205744.2825689-2-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230522205744.2825689-2-dhowells@redhat.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 22, 2023 at 09:57:39PM +0100, David Howells wrote: > ZERO_PAGE can't go away, no need to hold an extra reference. > > Signed-off-by: David Howells > Reviewed-by: David Hildenbrand > Reviewed-by: John Hubbard > Reviewed-by: Dave Chinner > Reviewed-by: Christoph Hellwig > cc: Al Viro > cc: linux-fsdevel@vger.kernel.org > --- Reviewed-by: Christian Brauner