Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp4309617rwd; Tue, 23 May 2023 06:13:05 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ41pp1we1cQV1W+dnXOi345ZASf7ekPzNI5xalA2ZtMs6byK8RF9oc2q30FqD5vlIHbnshJ X-Received: by 2002:a05:6a00:15c7:b0:64d:2e8a:4cc1 with SMTP id o7-20020a056a0015c700b0064d2e8a4cc1mr18647909pfu.27.1684847584762; Tue, 23 May 2023 06:13:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684847584; cv=none; d=google.com; s=arc-20160816; b=bzm7R1lvxCdmOhFctRKxA8dDl6aZrYN2lG1wSpuw92AZELSEwv5ZaOE0NIN8OyVPpK CSpQ5GJsleHss7piV9m8mS/YPVzy58TM46yV9Kjuv+Tkgc/ON7yS9dxA7tdSmKJ7uPYn PFn5fkFWnJP6cniqzEH/zaKXMaka3LQ1uUciXlyNp/JV1atrlNMVtMcoPOaJyIpGjUrs QKohBeqCxFjiIf316BirC7fj6VKFb4z7Z9dqLrxhyIRbEQZ74u69etblwaj0mL6WQAdW BCBP+j1W5yhSiaSnGn78h6gS/fAVBkJF6N8r1xkqeL1HpPLLQCdi/2lCGRZDVlDA8q0f dGkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date:dkim-signature; bh=PN3VYvWQVpXRAvo254BlI7PjqQARs1oNzdg2tsPbFvw=; b=VjhBxddsKbYEZI7d0mykunrM2ySPWHhTWK8LBmUQIKfLMG80uKfnh2sEKaEK2DnhzC osUVax9rJ1uFDlODr5H+K/I2eGQSxlpjTZITvjBkZ98Matn5L3hxHjjtUceD2YkjAtiv ulnnVNmWGOknO71VukA8ddiZYka4Fg17VUbn9RiUgUhZ77Is3NMtE8BsUD3gMWt9fw0D sydNsedpFzPXSgzKDKOtVnzDmr2+hgmj4jvxCIGeRCCMetNzhoySKIrjaBW1bfwiHhYa LnBJ4y+AHMSNUugc6InwTZBHRDVsHLuAfv9UhjWH1lVXcU5sD9JA1sE6DO+6bz2F5mKp h35A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OvoEbW0n; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g4-20020a625204000000b006251fb701a6si6543391pfb.285.2023.05.23.06.12.48; Tue, 23 May 2023 06:13:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OvoEbW0n; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236664AbjEWNJP (ORCPT + 99 others); Tue, 23 May 2023 09:09:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235277AbjEWNIu (ORCPT ); Tue, 23 May 2023 09:08:50 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16F5F109; Tue, 23 May 2023 06:08:49 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A776860B29; Tue, 23 May 2023 13:08:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C32AC4339B; Tue, 23 May 2023 13:08:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684847328; bh=1cEZ+kYR9C4Ji08kylg8DBnD3wDn0362SQowHihMxSU=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=OvoEbW0nJk1ROtTu1SHysGXvFjcKP8MDT4+VAuTAAPRY0vX5mcG4vBBkoV6ug5fTH D4RgNiF6AuU/WW/qT6jkUxX/fbw0BX67K5pxxBsl9nDFo/K1loJRGSQCE45Rfkwl1P oiEU1FqQE5T65Il3OGslHnIaDhq2a9BU+YYfZc/18HsabXhHMaKzezz8o7bzpZVnsh I6zYwBmHc1fcWb12+QVO755UFWUZ/nt2JUrg8h4X3T4/M+tZakWWA4Mf6saGCu9FYS fOR4g2ibYWKzU6aDWugIbK2INM+9af3a8DKuW9DkktZcUoFORv8CxsQ4TzfPrZArmH IevNwkgdRKCtQ== Date: Tue, 23 May 2023 15:08:44 +0200 (CEST) From: Jiri Kosina To: Nikita Zhandarovich cc: Ping Cheng , Jason Gerecke , Benjamin Tissoires , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: Re: [PATCH] HID: wacom: avoid integer overflow in wacom_intuos_inout() In-Reply-To: <20230417160148.60011-1-n.zhandarovich@fintech.ru> Message-ID: References: <20230417160148.60011-1-n.zhandarovich@fintech.ru> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 17 Apr 2023, Nikita Zhandarovich wrote: > If high bit is set to 1 in ((data[3] & 0x0f << 28), after all arithmetic > operations and integer promotions are done, high bits in > wacom->serial[idx] will be filled with 1s as well. > Avoid this, albeit unlikely, issue by specifying left operand's __u64 > type for the right operand. > > Found by Linux Verification Center (linuxtesting.org) with static > analysis tool SVACE. > > Fixes: 3bea733ab212 ("USB: wacom tablet driver reorganization") > Signed-off-by: Nikita Zhandarovich Applied. Thanks for the fix, and sorry for the delay. -- Jiri Kosina SUSE Labs