Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0a7b6e4775ea8ae3c41cd49c6cd19f90.squirrel@emailmg.ipower.com>
In-Reply-To: <20230511041221.135527-3-niravkumar.l.rabara@intel.com>
References: <20230503061000.3279381-1-niravkumar.l.rabara@intel.com>
    <20230511041221.135527-1-niravkumar.l.rabara@intel.com>
    <20230511041221.135527-3-niravkumar.l.rabara@intel.com>
Date:   Tue, 23 May 2023 07:23:37 -0500
Subject: Re: [PATCH v3 2/2] EDAC/altera: Check previous DDR DBE during 
 driver probe
From:   dinh.linux@anniebear.net
To:     niravkumar.l.rabara@intel.com
Cc:     niravkumar.l.rabara@intel.com, bp@alien8.de, dinguyen@kernel.org,
        james.morse@arm.com, linux-edac@vger.kernel.org,
        linux-kernel@vger.kernel.org, mchehab@kernel.org, rric@kernel.org,
        tony.luck@intel.com
User-Agent: SquirrelMail/1.4.19
MIME-Version: 1.0
Content-Type: text/plain;charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Importance: Normal
Sender:  dinh.linux@anniebear.net
Precedence: bulk

Hi,

> From: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
>
> Add DDR DBE check during driver probe to notify user if previous
> reboot cause by DDR DBE and print DBE error related information.
>
> Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
> ---
>  drivers/edac/altera_edac.c | 29 ++++++++++++++++++++++++-----
>  1 file changed, 24 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
> index 8b31cd54bdb6..04c0675adc8c 100644
> --- a/drivers/edac/altera_edac.c
> +++ b/drivers/edac/altera_edac.c
> @@ -2159,6 +2159,7 @@ static int altr_edac_a10_probe(struct
> platform_device *pdev)
>  #ifdef CONFIG_64BIT
>  	{
>  		int dberror, err_addr;
> +		struct arm_smccc_res result;
>
>  		edac->panic_notifier.notifier_call = s10_edac_dberr_handler;
>  		atomic_notifier_chain_register(&panic_notifier_list,
> @@ -2168,11 +2169,29 @@ static int altr_edac_a10_probe(struct
> platform_device *pdev)
>  		regmap_read(edac->ecc_mgr_map, S10_SYSMGR_UE_VAL_OFST,
>  			    &dberror);
>  		if (dberror) {
> -			regmap_read(edac->ecc_mgr_map, S10_SYSMGR_UE_ADDR_OFST,
> -				    &err_addr);
> -			edac_printk(KERN_ERR, EDAC_DEVICE,
> -				    "Previous Boot UE detected[0x%X] @ 0x%X\n",
> -				    dberror, err_addr);
> +			/* Bit-31 is set if previous DDR UE happened */
> +			if (dberror & (1 << 31)) {
> +				/* Read previous DDR UE info */
> +				arm_smccc_smc(INTEL_SIP_SMC_READ_SEU_ERR, 0,
> +					      0, 0, 0, 0, 0, 0, &result);
> +
> +				if (!result.a0) {
> +					edac_printk(KERN_ERR, EDAC_DEVICE,
> +						    "Previous DDR UE:Count=0x%X,Address=0x%X,ErrorData=0x%X\n"
> +						    , (unsigned int)result.a1
> +						    , (unsigned int)result.a2
> +						    , (unsigned int)result.a3);
> +				} else {
> +					edac_printk(KERN_ERR, EDAC_DEVICE,
> +						    "INTEL_SIP_SMC_SEU_ERR_STATUS failed\n");
> +				}
> +			} else {
> +				regmap_read(edac->ecc_mgr_map, S10_SYSMGR_UE_ADDR_OFST,
> +					    &err_addr);
> +				edac_printk(KERN_ERR, EDAC_DEVICE,
> +					    "Previous Boot UE detected[0x%X] @ 0x%X\n",
> +					    dberror, err_addr);
> +			}
>  			/* Reset the sticky registers */
>  			regmap_write(edac->ecc_mgr_map,
>  				     S10_SYSMGR_UE_VAL_OFST, 0);
> --
> 2.25.1
>
>

I think it would make sense if you combined the 1st patch. This patch
cannot survive on its own without the defines.

Dinh