Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <856dbc05-5046-04c8-cf6f-9d0b13e9d229@suse.cz>
Date:   Tue, 23 May 2023 15:13:43 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH] mm/mmap: refactor mlock_future_check()
Content-Language: en-US
To:     Lorenzo Stoakes <lstoakes@gmail.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>
Cc:     Mike Rapoport <rppt@kernel.org>,
        "Liam R . Howlett" <Liam.Howlett@Oracle.com>
References: <20230522082412.56685-1-lstoakes@gmail.com>
From:   Vlastimil Babka <vbabka@suse.cz>
In-Reply-To: <20230522082412.56685-1-lstoakes@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/22/23 10:24, Lorenzo Stoakes wrote:
> In all but one instance, mlock_future_check() is treated as a boolean
> function despite returning an error code. In one instance, this error code
> is ignored and replaced with -ENOMEM.
> 
> This is confusing, and the inversion of true -> failure, false -> success
> is not warranted. Convert the function to a bool, lightly refactor and
> return true if the check passes, false if not.
> 
> Signed-off-by: Lorenzo Stoakes <lstoakes@gmail.com>

Acked-by: Vlastimil Babka <vbabka@suse.cz>

> ---
>  mm/internal.h  |  4 ++--
>  mm/mmap.c      | 33 +++++++++++++++++----------------
>  mm/mremap.c    |  2 +-
>  mm/secretmem.c |  2 +-
>  4 files changed, 21 insertions(+), 20 deletions(-)
> 
> diff --git a/mm/internal.h b/mm/internal.h
> index bb6542279599..66dd214b302a 100644
> --- a/mm/internal.h
> +++ b/mm/internal.h
> @@ -576,8 +576,8 @@ extern long populate_vma_page_range(struct vm_area_struct *vma,
>  extern long faultin_vma_page_range(struct vm_area_struct *vma,
>  				   unsigned long start, unsigned long end,
>  				   bool write, int *locked);
> -extern int mlock_future_check(struct mm_struct *mm, unsigned long flags,
> -			      unsigned long len);
> +extern bool mlock_future_check(struct mm_struct *mm, unsigned long flags,
> +			       unsigned long bytes);

This would have been good opportunity to drop the extern.