Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <eeeb8971-162e-6c33-83ff-d003739d5211@quicinc.com>
Date:   Tue, 23 May 2023 19:24:47 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.1
Subject: Re: [PATCH v2 4/4] arm64: dts: qcom: qdu1000-idp: add SDHCI for emmc
Content-Language: en-US
To:     Bhupesh Sharma <bhupesh.sharma@linaro.org>
CC:     Ulf Hansson <ulf.hansson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        <linux-mmc@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>
References: <20230522093620.3568-1-quic_kbajaj@quicinc.com>
 <20230522093620.3568-5-quic_kbajaj@quicinc.com>
 <CAH=2NtxwG3YaN7F_q2PARXPA_Rit7-KhkxFKXzL0xD3J8J4SpQ@mail.gmail.com>
From:   Komal Bajaj <quic_kbajaj@quicinc.com>
In-Reply-To: <CAH=2NtxwG3YaN7F_q2PARXPA_Rit7-KhkxFKXzL0xD3J8J4SpQ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 5/22/2023 3:23 PM, Bhupesh Sharma wrote:
> On Mon, 22 May 2023 at 15:06, Komal Bajaj <quic_kbajaj@quicinc.com> wrote:
>> Add sdhci node for emmc in qdu1000-idp.
>>
>> Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 23 +++++++++++++++++++++++
>>   1 file changed, 23 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
>> index 9e9fd4b8023e..61d8446a2d55 100644
>> --- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
>> +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
>> @@ -451,3 +451,26 @@
>>   &uart7 {
>>          status = "okay";
>>   };
>> +
>> +&sdhc_1 {
>> +       pinctrl-names = "default", "sleep";
>> +       pinctrl-0 = <&sdc1_on_state>;
>> +       pinctrl-1 = <&sdc1_off_state>;
>> +
>> +       cap-mmc-hw-reset;
>> +       mmc-ddr-1_8v;
>> +       mmc-hs200-1_8v;
>> +       mmc-hs400-1_8v;
>> +       mmc-hs400-enhanced-strobe;
>> +
>> +       non-removable;
>> +       no-sd;
>> +       no-sdio;
>> +
>> +       supports-cqe;
>> +
>> +       vmmc-supply = <&vreg_l10a_2p95>;
>> +       vqmmc-supply = <&vreg_l7a_1p8>;
>> +
>> +       status = "okay";
>> +};
> This node is out of alphabetical order again.
> &uart7 would follow &sdhc_1 and so on...
Sure will change this next version.

Thanks
Komal
>
> Thanks,
> Bhupesh