Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp4425149rwd; Tue, 23 May 2023 07:35:20 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ41KBDK9HwqqHUe+lCfToCSJKKoc/10ILwBjzdTTz3GfMewBCutlyGK1erbclDBKSK3bqnq X-Received: by 2002:a05:6a20:6a13:b0:101:2ad0:1347 with SMTP id p19-20020a056a206a1300b001012ad01347mr13263205pzk.23.1684852519991; Tue, 23 May 2023 07:35:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684852519; cv=none; d=google.com; s=arc-20160816; b=iWk8dD7UqXfolzPvLD1eMQi79xfiZKjw74GkHOuo3QN66sZ1bBLCFj3Akm6wDW6/9A 3qAw/FyKcgoSNaTBM8WdJ2x/7YYJslYR8TgkS8RkFV3/OMSOSAShyMCP4zx10GkVQKcz Lp/ef1qw2R7c/acMdoeuvjf5S+n1X22LZZw7dIRxYMRtcP130mxL2YbCOAB9eid+KP1n y5chsJsl6ukL3RXYZlo2Us00X5c/bIivsYJzVANN8MJxok59bOxZY6Q+oNmY62c4O53P qLVpyT+HnBC6Sk4HhsEOxtw8T2BWr149wlzFeXtcHrTd6hcHuJpIvpJ3o1/PWpCLtpeA JEqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=Sb4ouXnfiIJfKV7USYtA2WS44255JAqNIdC+aKUHl8Q=; b=cy7clxO6mLj2yoRrBkiDNbVhN5zrxYq/1eIYXcMw/0PAk1p9tgKdZ6N8dhTO7/Xuj7 UKmgATb6pAqsB/+ubvjzTDVBP9u95CZHxtj7WmFpu3NqPNiWBWfjJDT4Q6N/KITMzcwZ H4GUNJ92UhZhneoOTpcxvGI0ce4kLVjJdv2XZYTFd2m679xQKfJwRvOowQH6s5R9PgqQ +L3bjUrpHRMQAmTN9aa7Wl6IVR2E94sMsbSdyGBd+B9vgf+GQ44Y3ntxG72auvav6eP6 +C8/lFxrlcIvUCuc/du8uUrJEKu6uzpPcmQ/JUazH2h2tkGn5cMz2mvy8/4mOGZQdurg YPbg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 7-20020a630207000000b005348b454fb8si6752382pgc.780.2023.05.23.07.35.07; Tue, 23 May 2023 07:35:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237240AbjEWOLq (ORCPT + 99 others); Tue, 23 May 2023 10:11:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236869AbjEWOL1 (ORCPT ); Tue, 23 May 2023 10:11:27 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7973FC4; Tue, 23 May 2023 07:10:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2876160B02; Tue, 23 May 2023 14:10:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 095CFC433D2; Tue, 23 May 2023 14:10:42 +0000 (UTC) Date: Tue, 23 May 2023 10:10:41 -0400 From: Steven Rostedt To: Ze Gao Cc: Jiri Olsa , Yonghong Song , Alexei Starovoitov , Andrii Nakryiko , Daniel Borkmann , Hao Luo , John Fastabend , KP Singh , Martin KaFai Lau , Masami Hiramatsu , Song Liu , Stanislav Fomichev , Yonghong Song , bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kafai@fb.com, kpsingh@chromium.org, netdev@vger.kernel.org, paulmck@kernel.org, songliubraving@fb.com, Ze Gao Subject: Re: kprobes and rcu_is_watching() Message-ID: <20230523101041.23ca7cc8@rorschach.local.home> In-Reply-To: References: <20220515203653.4039075-1-jolsa@kernel.org> <20230520094722.5393-1-zegao@tencent.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Added a subject, as I always want to delete these emails as spam! ] On Mon, 22 May 2023 10:07:42 +0800 Ze Gao wrote: > Oops, I missed that. Thanks for pointing that out, which I thought is > conditional use of rcu_is_watching before. > > One last point, I think we should double check on this > "fentry does not filter with !rcu_is_watching" > as quoted from Yonghong and argue whether it needs > the same check for fentry as well. > Note that trace_test_and_set_recursion() (which is used by ftrace_test_recursion_trylock()) checks for rcu_is_watching() and returns false if it isn't (and the trylock will fail). -- Steve