Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d0fe7a6f-8cd9-0b81-758a-f3b444e74bab@intel.com>
Date:   Tue, 23 May 2023 07:16:55 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH 2/2] signal: move show_unhandled_signals sysctl to its own
 file
Content-Language: en-US
To:     Luis Chamberlain <mcgrof@kernel.org>, keescook@chromium.org,
        yzaikin@google.com, ebiederm@xmission.com, arnd@arndb.de,
        bp@alien8.de, James.Bottomley@HansenPartnership.com, deller@gmx.de,
        tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com,
        x86@kernel.org, hpa@zytor.com, luto@kernel.org,
        peterz@infradead.org, brgerst@gmail.com,
        christophe.jaillet@wanadoo.fr, kirill.shutemov@linux.intel.com,
        jroedel@suse.de
Cc:     j.granados@samsung.com, akpm@linux-foundation.org,
        willy@infradead.org, linux-parisc@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230522210814.1919325-1-mcgrof@kernel.org>
 <20230522210814.1919325-3-mcgrof@kernel.org>
From:   Dave Hansen <dave.hansen@intel.com>
In-Reply-To: <20230522210814.1919325-3-mcgrof@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/22/23 14:08, Luis Chamberlain wrote:
> --- a/arch/x86/kernel/umip.c
> +++ b/arch/x86/kernel/umip.c
> @@ -12,6 +12,7 @@
>  #include <asm/insn.h>
>  #include <asm/insn-eval.h>
>  #include <linux/ratelimit.h>
> +#include <linux/signal.h>

Oh, so this is actually fixing a bug: umip.c uses
'show_unhandled_signals' but it doesn't explicitly include
linux/signal.h where 'show_unhandled_signals' is declared.

It doesn't actually have anything to do with moving the
show_unhandled_signals sysctl, right?

If that's the case, it would be nice to have this in its own patch.