Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <461a4c29-b60f-a2fc-390b-7a39c9cec451@amd.com>
Date:   Tue, 23 May 2023 10:36:34 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH] drm/amd/display: remove unused variables
 res_create_maximus_funcs and debug_defaults_diags
To:     Tom Rix <trix@redhat.com>, harry.wentland@amd.com,
        sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com,
        alexander.deucher@amd.com, christian.koenig@amd.com,
        Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch,
        qingqing.zhuo@amd.com, wenjing.liu@amd.com,
        aurabindo.pillai@amd.com, Samson.Tam@amd.com, gpiccoli@igalia.com
Cc:     dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20230523114937.1080767-1-trix@redhat.com>
Content-Language: en-US
From:   Hamza Mahfooz <hamza.mahfooz@amd.com>
In-Reply-To: <20230523114937.1080767-1-trix@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UXZ5UjFCV240N1cwNE80ek9KWlAreFRmU2hYOFBYc1M4aGhKVUlWTHRrZFpx?=
 =?utf-8?B?bFlNcS93aWhkanZBdDAzS3NiQ2dHbWt2Tmo3Q2c0VGdlY2NEZGZWRmYxN3Vh?=
 =?utf-8?B?UFdCYXh3enhNcW5wdTVwRHh2a3ZmTHJHT1ZOak0yN0x2bjZKY2VkbVRyb2hY?=
 =?utf-8?B?T201TE01NUZKbnlzanNIR2luSmd0eFRhR1NDNjExWmtOYnR3amhsNUkvSmll?=
 =?utf-8?B?RjRBV2NqSlJDc1ZLMkVWcTBnWHNPRTVUcytaeWV4aHZQUEw3ejBKUUl2ZUNR?=
 =?utf-8?B?MldSYzYzdUhKQ1BrejkrQUJ3dFN1Y25yQ2JZYXFTYnJ5TEIxODJ1OHNpVkNo?=
 =?utf-8?B?N2RJNTVueDdXL1FseTdPNDZHVmRuZ2ZnM3JPMnduSFN0SmdaYUFTeStUVmVU?=
 =?utf-8?B?MjJRSnlNeEtDbzdHWEF2eFNmZnZNRlNsRVFkTDlVUXgxKzJSc1hVYVVmZC9L?=
 =?utf-8?B?WDFObjNjU2ZSYTVXcWZBR3R3VVdMbUd5YlVsWG9rZ1dDYzdtQllORHRRazMx?=
 =?utf-8?B?SXA0dVlISXR3Mnd1UjBIYnVjd3dhZGFucE5zR3QzK0hWWm14NFN1ay8zSFdB?=
 =?utf-8?B?TVF2ZksvSHVaSk5EK2JPZXdhaU1VMGpyMXpKVnJ2d3R3N01PRkpSMy9Ga09T?=
 =?utf-8?B?eWlEYjlpTmFyOUhHQ2dwVm1iTFVUSXVHYndoSk9zVHd5UzcyTy9PYjJYRFZ0?=
 =?utf-8?B?NjEzZ2Fnc1Nmc2t1VmZlZHlBL1RtUy9uM3daMzZiTmc3Qzg4VlBQVDhiY21p?=
 =?utf-8?B?R2R0cGZVdWxMWUVNZ21obFdWTkJMdC9xc1NRSGhvTlc3VW11Rmd3RWFxNndQ?=
 =?utf-8?B?SG1aOTNYWVROR1BKSjlaNGNiY0Jadnl0VWpvMFBkTzBWclNOZDBBenM0OWt6?=
 =?utf-8?B?d2tGMjgxU1BhRlJvTkI0czk3bTRuVjdMU3l2WTFoNGdGekhZd1BkeWx3OS9C?=
 =?utf-8?B?SVdXVU1hWWtESVgrWGJza0FZUDFNNFdHdzFnQ0hnZVNlNWN0YWJBcTJIOWRz?=
 =?utf-8?B?SmVDSU0rVm1XeXVZMHFIMjJDZ2J1OU1Qdkh5TFhIT094UHh0NUNkNG9EcXdy?=
 =?utf-8?B?QjNJc1F6cFdncmpRSmF4ZWVON0s2RUl2VDJJRjVCYkJnYW8xQVhiM1NYTXl6?=
 =?utf-8?B?Mjc2NWVrSXFLdU8rcjUvY0VGWndFSWxvNEFKSXZqVFFUSnZrbm9sZjNVQnJL?=
 =?utf-8?B?S1NRZFNCSlQvcngxYWtLOXZ0UXNmTFZiZSszTGsvb0MwZW9FUENvbWRDS1RD?=
 =?utf-8?B?bmZ1dmE1UWhLMzVoQ3VkN0Fzc0xPbUtKZHhGdzhNK3ZGQkw5dXJDUlk4bVpU?=
 =?utf-8?B?VXRnWXUwQkNnUzNnV2cvTUpJcnNvbUlRMGRlSjY3clNwVmt1dkc4NDg1Nmtj?=
 =?utf-8?B?UndXQ0JPcCtTM09PeXVObTdES1pHK3FVNDZIMTBHekF1aFNiOCs4RWV6cFFX?=
 =?utf-8?B?Ui9Ca0JhbE80MDJnSVFmSlpWcVN4S1lxWVBtN0lCb29EWGJsbHpXTWN0SnIz?=
 =?utf-8?B?bzhPMVNkdi80MTVMZ3Y0ZzJoUktmL0RpSk1PS2VtZzZPY3gwM0ZuY0RVaXZU?=
 =?utf-8?B?djZnRWc0Zy9KZzJhZEJPNStMWlJSMnNmaVBaMExaaEd3cnZHbmhWVk9lWEpu?=
 =?utf-8?B?N0dwWUY4ZnJoRmY0a0lWRUdiaDRvbGExa1dKbzFBTzBiUjdDaSt1bFpSQzNT?=
 =?utf-8?B?TmdvaklpaWJhZmhtMmdoTWMrLytLWEVQeWhFM1VlUXN0UktGaHdpK2RiR0dN?=
 =?utf-8?B?L0o2ZzRicGFqdW9LbUV0QUlXMllMSDllUEdmYmJ1RnByQXZISVVFRytrbHlC?=
 =?utf-8?B?QXBza0ZwRFpiM2U5eE9MMkZ6REN2cC9tYUtoeElZNWpLdzkxbUZtYzUvS25Z?=
 =?utf-8?B?dWs5cDdEZndLREV1eElyMlluaXNoNXhwZ1FBUUtYZ1ZBTXV6U09ob3owM0Q0?=
 =?utf-8?B?YzNNQlZLYW1KTEVISWdtWHgxTUN6RFBiWWF1ZEdQdUR1VklmK3RMemVSOWxh?=
 =?utf-8?B?VnEvaHFTVWUxajJzd1R5dWlhQ0VwUEsvM25QZjdKMWdFSHR2alJLLzdvZ1Y1?=
 =?utf-8?B?SGFLOUNrM0VGV3pTQWVCZkVnTGJoeDBQSkdqZjV4aHpGdm96WExXZkdVamNB?=
 =?utf-8?Q?zKkAygrYDUFCAg3L9Brp9YmGE?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c5ac19e4-53d0-4850-e54f-08db5b9b1e77
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6280.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 14:36:39.5873
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tTKu7IS/WSWfqo8j0ym+2Ym8Ym/qriZ1SAg2HfaXDEt88V3kKdgWnl5YUakFuVq8jfNJxqjG2qy4WeKc44KLdA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7370
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 5/23/23 07:49, Tom Rix wrote:
> gcc with W=1 reports
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_resource.c:1069:43: error:
>    ‘res_create_maximus_funcs’ defined but not used [-Werror=unused-const-variable=]
>   1069 | static const struct resource_create_funcs res_create_maximus_funcs = {
>        |                                           ^~~~~~~~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_resource.c:727:38: error:
>    ‘debug_defaults_diags’ defined but not used [-Werror=unused-const-variable=]
>    727 | static const struct dc_debug_options debug_defaults_diags = {
>        |                                      ^~~~~~~~~~~~~~~~~~~~
> 
> These variables are not used so remove them.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>

Fixes: 00df97e1df57 ("drm/amd/display: Clean FPGA code in dc")

Applied, thanks!

> ---
>   .../drm/amd/display/dc/dcn20/dcn20_resource.c | 23 -------------------
>   1 file changed, 23 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c
> index 7dcae3183e07..6ef7e2634991 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c
> @@ -724,22 +724,6 @@ static const struct dc_debug_options debug_defaults_drv = {
>   		.underflow_assert_delay_us = 0xFFFFFFFF,
>   };
>   
> -static const struct dc_debug_options debug_defaults_diags = {
> -		.disable_dmcu = false,
> -		.force_abm_enable = false,
> -		.timing_trace = true,
> -		.clock_trace = true,
> -		.disable_dpp_power_gate = true,
> -		.disable_hubp_power_gate = true,
> -		.disable_clock_gate = true,
> -		.disable_pplib_clock_request = true,
> -		.disable_pplib_wm_range = true,
> -		.disable_stutter = true,
> -		.scl_reset_length10 = true,
> -		.underflow_assert_delay_us = 0xFFFFFFFF,
> -		.enable_tri_buf = true,
> -};
> -
>   void dcn20_dpp_destroy(struct dpp **dpp)
>   {
>   	kfree(TO_DCN20_DPP(*dpp));
> @@ -1066,13 +1050,6 @@ static const struct resource_create_funcs res_create_funcs = {
>   	.create_hwseq = dcn20_hwseq_create,
>   };
>   
> -static const struct resource_create_funcs res_create_maximus_funcs = {
> -	.read_dce_straps = NULL,
> -	.create_audio = NULL,
> -	.create_stream_encoder = NULL,
> -	.create_hwseq = dcn20_hwseq_create,
> -};
> -
>   static void dcn20_pp_smu_destroy(struct pp_smu_funcs **pp_smu);
>   
>   void dcn20_clock_source_destroy(struct clock_source **clk_src)
-- 
Hamza