Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 23 May 2023 22:31:07 +0800
From:   Feng Tang <feng.tang@intel.com>
To:     Peter Zijlstra <peterz@infradead.org>
CC:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@intel.com>,
        "H . Peter Anvin" <hpa@zytor.com>, <paulmck@kernel.org>,
        <rui.zhang@intel.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC] x86/tsc: Make recalibration default on for
 TSC_KNOWN_FREQ cases
Message-ID: <ZGzOK9xkeQTnleWB@feng-clx>
References: <20230522033018.1276836-1-feng.tang@intel.com>
 <87h6s4ye9b.ffs@tglx>
 <ZGssENXFKmOk/zL7@feng-clx>
 <87zg5wwppa.ffs@tglx>
 <ZGtnUQJy+1Nrazhy@feng-clx>
 <87pm6swi7z.ffs@tglx>
 <ZGuIL6tyzzZP3kyR@feng-clx>
 <20230522161158.GA3330346@hirez.programming.kicks-ass.net>
 <ZGwUXzGcMgbcZVnf@feng-clx>
 <20230523081115.GG4253@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230523081115.GG4253@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VyWj+APSfOUv9QICyXbKH/3sMfNf5vNEhdpx69hKl0WZHzUVdErCl1HUUinX?=
 =?us-ascii?Q?cF++N41AeiEPqsojHh/hiUxlWK2PDKxi39d8FPYtcY12ZI7nxIuV5rVCfxoP?=
 =?us-ascii?Q?KDwKEzA8c906evMCQno8hnnTvBotNHIyv5n85nShC+4+8U1PWTQTU/dNUJs9?=
 =?us-ascii?Q?O/vPqLGQ7WaM3yL/9AgpqkeekKMPubQo7ALSQownmauYLO79kkFS+j+j4gcB?=
 =?us-ascii?Q?SJqNuoeyM1zNF9yUjVTxXrJq+EsFLeKImMKcHU/xIKdcszuq7jFaWH6aHAaO?=
 =?us-ascii?Q?4I53EKvq635vbze9fND7yG+k65SgsPa+k0g7EjujVNt9/kg39ctzLpwJ1zyN?=
 =?us-ascii?Q?DL+LfnqXMJHj6DCWxpBCO/kAAF6GKlYaizgrfcLj8IjT4GiFZj6vjToe9wn9?=
 =?us-ascii?Q?9OmWQA5rpwdHVgHPoQJC6IU7fRQGw7O0WF1AR6YfqurWBhsjsVYJh9kz2ZkY?=
 =?us-ascii?Q?QuDNEsK3Tn2NNhHIvLguOXZCin7JYIJMKiUaoEe81PWlJz80Qqo4TriH10lZ?=
 =?us-ascii?Q?jV2b0CtTEbHh9x2ESd1iGJVCDXUt1b9x0CLSbq4aQJIzGNGdjeTkYuZqvrbE?=
 =?us-ascii?Q?SY5mHi4VfucZ8JnZOb8cNer0lw0GR+rmYunSguw15fmTEQg8gpwpqB1sqnu+?=
 =?us-ascii?Q?70sE78THwUY5IdUYh7rjwTfC+WXGWVsWYSbMdHYQwzzNDI6tkI7c3zLpBsB0?=
 =?us-ascii?Q?qHldxDJT0OgAuYmk+Uaj+Io7kWAg+9HWZNp9NxCLQGmoY72sx6QCONqkSADQ?=
 =?us-ascii?Q?aXTVDe/sWXkLLhGH+NKmLbo6ITOq5iHwGa9Jtf99K0q66Y9k/yzyBmUSb+uK?=
 =?us-ascii?Q?Ke67tcwEdY4jWk1MayUP5QPhl79q15OrhBlp7r6X+SvuOMYKo8v8C2CZPOmn?=
 =?us-ascii?Q?PU9nSb8av4/4050FS14QBD2cOXS6FTtetIgJ6xFCQZ99crmMe8EP5Cl08W9Y?=
 =?us-ascii?Q?bG9toJBq0qVv9P7K8Iw6LU1zt68UB5mX/p1+pbDHyQvMEeh2gbvx6KPbc5lL?=
 =?us-ascii?Q?vANL4pzZgdES/Kz40A62NOzqDWrH8+IcjSI9XJdpRmdC2x8XB0XseFctQouR?=
 =?us-ascii?Q?9NT+9pgD/32EcUMAcB0g4e3Hp0rU3iU9vFGOuHpoXnKw0TGmxKfcZp06CRoA?=
 =?us-ascii?Q?12WRZrYJs3bNdNKpyBpZrDMMja+kkdh5gls6lnSptrIqjS1y+76YRk336VEP?=
 =?us-ascii?Q?JS3yYLSPhjXKOR+V1C7XI2QLDSp8MWE22hVTwRCiOF/xtkKpwEmsZYqgIhCH?=
 =?us-ascii?Q?Z+J6qUWHAiI4tAnd00Vi4RmIxqCNNHeQdEBfdA7pq8uSXd9v7MhREgtNiwuG?=
 =?us-ascii?Q?wLWOc9V39/CH8JDv/1lIJapd91Vv9FdyIiOJ254Se/XZ2HLTp3H435L1Y4d4?=
 =?us-ascii?Q?DXezVP1NfVqpBXHmCSiA9CdA4x1e5pp93emyX8wRjodTnnf/lxHtSV72150i?=
 =?us-ascii?Q?TL8uUuzlnVWfCytWgTLsWo5ov6KATwhex+oMt2y6h7R8Nb4lyPbmf+ZD591Z?=
 =?us-ascii?Q?hUQylRT5AFiI53kC5TY3yibiacVgqOFHiOW9SA8pEZnEUEVoSJdIgqWh+OC6?=
 =?us-ascii?Q?1xXycBPBdj8e/ddQFvLMegZl3q7MaA0HOBuXS3hh?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f394c701-7f1a-416c-3afe-08db5b9b4e04
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 14:37:59.3825
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vGuQ7OqOOOYRdtmNInOazeCPs6ynAhcRZUc4UIbnLO3SNgmkQn9bir2JtooMriPZGXcqRWNg9qQ2MtlrC50RpA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6294
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 23, 2023 at 10:11:15AM +0200, Peter Zijlstra wrote:
> On Tue, May 23, 2023 at 09:18:23AM +0800, Feng Tang wrote:
> > On Mon, May 22, 2023 at 06:11:58PM +0200, Peter Zijlstra wrote:
> > > On Mon, May 22, 2023 at 11:20:15PM +0800, Feng Tang wrote:
> > > 
> > > > And I don't understand the commit log: "On Intel GOLDMONT Atom SoC
> > > > TSC is the only reliable clocksource. We mark TSC reliable to avoid
> > > > watchdog on it."
> > > > 
> > > > Clearly the Denventon I found today has both HPET and ACPI_PM timer:
> > > > 
> > > >   [root@dnv0 ~]# grep .  /sys/devices/system/clocksource/clocksource0/*
> > > >   /sys/devices/system/clocksource/clocksource0/available_clocksource:tsc hpet acpi_pm
> > > >   /sys/devices/system/clocksource/clocksource0/current_clocksource:tsc
> > > >   
> > > > The lscpu info is:
> > > >   
> > > >   Architecture:                    x86_64
> > > >   CPU op-mode(s):                  32-bit, 64-bit
> > > >   Address sizes:                   39 bits physical, 48 bits virtual
> > > >   Byte Order:                      Little Endian
> > > >   CPU(s):                          12
> > > >   On-line CPU(s) list:             0-11
> > > >   Vendor ID:                       GenuineIntel
> > > >   BIOS Vendor ID:                  Intel(R) Corporation
> > > >   Model name:                      Intel(R) Atom(TM) CPU C3850 @ 2.10GHz
> > > >   BIOS Model name:                 Intel(R) Atom(TM) CPU C3850 @ 2.10GHz  CPU @ 2.1GHz
> > > >   BIOS CPU family:                 43
> > > >   CPU family:                      6
> > > >   Model:                           95
> > > >   Thread(s) per core:              1
> > > >   Core(s) per socket:              12
> > > >   Socket(s):                       1
> > > >   Stepping:                        1
> > > > 
> > > > Maybe this cpu model (0x5F) has been used by some type of platforms
> > > > which has met the false alarm watchdog issue.
> > > 
> > > It has them; but they are not *reliable*.
> >  
> > Yes, that's possible. I tried to CC the author Bin in case he can
> > provide more background or information for his statement, but his
> > email address is unreachable now.
> 
> IIRC HPET stops in C10 or something stupid like that, I forgot what the
> problem with ACPI_PM is.

Yes, that HPET issue is a common one for several generations of
client platforms like Baytrail, Coffee Lake etc.