Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <796c7f92-1121-d9d2-6b2c-15aa13d3f215@oracle.com>
Date:   Tue, 23 May 2023 10:04:40 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH] scsi: Let scsi_execute_cmd() mark args->sshdr as invalid
Content-Language: en-US
To:     "Martin K. Petersen" <martin.petersen@oracle.com>,
        John Garry <john.g.garry@oracle.com>
Cc:     Juergen Gross <jgross@suse.com>, linux-kernel@vger.kernel.org,
        linux-scsi@vger.kernel.org,
        "James E.J. Bottomley" <jejb@linux.ibm.com>, stable@vger.kernel.org
References: <20230511123432.5793-1-jgross@suse.com>
 <yq1ttwbsoii.fsf@ca-mkp.ca.oracle.com>
 <6614f626-d174-03d0-0993-79e6f6169b71@suse.com>
 <9d356278-c826-dacf-cbe0-79f512b7970e@oracle.com>
 <60aeffe4-b31d-4ea3-d4ea-f50ae25e0316@suse.com>
 <74879c87-689f-6a8e-a177-8bde4c9c4e51@oracle.com>
 <yq1v8gmpkq4.fsf@ca-mkp.ca.oracle.com>
From:   Mike Christie <michael.christie@oracle.com>
In-Reply-To: <yq1v8gmpkq4.fsf@ca-mkp.ca.oracle.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UmhEa3lGM2xFRGNQVUUrcHBtdXFyTGd3QVlrWlc3TUFiS29teUNmSTZLVkpK?=
 =?utf-8?B?Zi9zakxuWktYeEZhK21mMkNZV1puSjdJVUJub25XMEtieW82eWxmQnB0SThX?=
 =?utf-8?B?WldZK0tZT3NqYnR1a0ptU2VUOWQ5dEhEUXBNWkVyR1JWcU5jNHdtYXRPR25G?=
 =?utf-8?B?NjJBeldDa3lma3lmOXFNMkxFZUJDakJHRHdJbHYxZXQzZWwyMWJmckR0bkl6?=
 =?utf-8?B?ZjJiclZWamJ5bGtZK1Z1KzFlRVoyWko4RkhrNnVnZE5aVmRVNTJ4NWVJZllJ?=
 =?utf-8?B?Q3M3NndjbmQrZ1owZkt3aHFIWXhpRi8welFyVFhDR01yVjU3TFVQL0ZGSGJa?=
 =?utf-8?B?cFI4RHlzZkZOa05nQVpJai9lck1GWmREc1JsK2gycVNYWW9zVHFKMzkvOUNl?=
 =?utf-8?B?Yzc5eXhxbk5TZWpFWkQ3algxSG9jWGxVR1JWUkgyaE5jdWJqSElBS1owQU5Y?=
 =?utf-8?B?SUQ1TU9LNE51VDZ2bHZZMy85ODVpSEk4bVBiMjhJYnZqTjJyMTZoZXplQzdx?=
 =?utf-8?B?cVRYNXgvNjluZVdSQnh1aEYzS1dsVEpYZG8yVzIyUFc2UlhseEZhU1YrNFhT?=
 =?utf-8?B?dThkNTkrdHV6TXZMaE1ZcTYyd1N4dW9BNnNtcXhkS0JyNVF2U3dJamVTOXdw?=
 =?utf-8?B?SUMvVEhvdW10V2ppRnM5VE1IYWZmTzlWcldBM1VseDZGblU3S0hVNThKc0Vs?=
 =?utf-8?B?M2FHWmc2cVJsMEdGN2hBY2JQbXpBWDlJMEhjSEQ3NG5ZdEdXNHo4NDBNSXhv?=
 =?utf-8?B?Wm5Oc0JQMnNZTW1aaFNXTnpSQ2RPczA2N2c5YXR0R0dBMCtta1d1Z2NEQ25B?=
 =?utf-8?B?UVEvcDN5Rkl3eXFjUWx0dzIvMUVQeEZaVFVHRzh2eFBnZUUwbkZEUktoUmFv?=
 =?utf-8?B?MllOZHFGVFNoZjBvTVRVRXVsZHBvQzVlVXhMT3Bxd1Q4VlZuMVJhMmRaQmta?=
 =?utf-8?B?d3JXdXhOeHRsYWJ6R053UVpHWVE5Z1VOYnNaRFBKTEVFeW5uK2JYY2hyQXVw?=
 =?utf-8?B?d0d6V0dTc3JjMlZXc2kwOGZkeFNxTCtvaFcyd0o1TXIxQVNDSVlLYW9SVzJU?=
 =?utf-8?B?ekEwVnJYMHFUYWFPaWhmU1RieU9TY2xaY1RNMlBBTmg3MWo0VFo5dFRlODBl?=
 =?utf-8?B?bXdVWmlNbGZnckdlVFVTWlJGNE9YTFh0WFdQcUVTanRsMm9vU3puYzNVTFBN?=
 =?utf-8?B?YlRpQnFJODlhdUpDMVZxL0tVYnR2Ui9qZ3lPRWh5d1hia2xEN3pkUnBacW5s?=
 =?utf-8?B?Y1dDWHF3RHhSUThUOXN6UWdqdzR4eHpQMVZsaGx4ZUZBOS9icHZZaklrTXQ3?=
 =?utf-8?B?TVRFays0ZHlhaTRkQlpUendSaVVLTzlaOUo0NC9ZVDNWSWwwMjJQVUFNYVBT?=
 =?utf-8?B?RjBTQ1RMVDlDYnM0bEFFalhmc0RaRHl3MDI0Z1NTUzlrRTAra0FFd3AyTm1G?=
 =?utf-8?B?ZEtseXBBdm5HeEJUUDJUR3Aya1k1eHhka0pCMXJRY3BVQnQxRVdFZzVpMWdn?=
 =?utf-8?B?VGJKNnpZUEYvcXcyVkNKMGRHT1hiNmRCWmFaYTlGWGdqaHVHZWt1bnZ3dkxZ?=
 =?utf-8?B?VlA3bWw0RkpHWFVJeHA4cnZMWWVWZlRjWmkzTjdBcGoxZERvMldreG10WGhS?=
 =?utf-8?B?Nm5qbDZIN204MzVhYzZvcFJQWXByQnBhbW1LWUdadTJRQ3FDbnByRTRRTEFl?=
 =?utf-8?B?TkhqWXhPTGVHeXdjQStnS0RYMks5OE9HT0ZwcjhlUndoS1dJL3J1bEZmS3V4?=
 =?utf-8?B?RFpocHNvR25zTXZkWUhYdHhJSzFKV2JyNi9vSTRzUmtFdkE5S0I4VFJxSS9w?=
 =?utf-8?B?bS9ucDdFdXFsMjNZQWh5UkhiS1AvWlZ4d29STHNVNXdKRmx3QjhHQWlwcjhE?=
 =?utf-8?B?djBmN1NHYWJES3NQbjhoQXhkK29HU29OQjhvMWljRUY5SVp6eWhGZkc1SVNu?=
 =?utf-8?B?Q1BhcjVKUnUySGJ3UHRDNUQxNFMxYmlPVG5kMGNjZnhPL3Raak5pODZxcGNj?=
 =?utf-8?B?eGFDeldtZkRNQmVjWXlWTnQrQVlCNlVwR0Flays4bmNEd01hQzlQQ1hqVkMx?=
 =?utf-8?B?MlRibUFrMHgxZENPcFJMZVF2M20xUHc4MzVjd1pBUXM4SVBNbjE1azNGNUVJ?=
 =?utf-8?B?Zm9Idk5NZGlMYm9NVWp0NHdNd2xCN3RXQk1yNlloWVMvUEpMbGJlSEloVHZY?=
 =?utf-8?B?eWc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: CRye45gFSi3IuD0Re/ftiif9HDy88CeKP3/5BGbOJQyBEhnH+61rQ0v1ESxZ7xxViteF8PdA/q7r4sUPqZdWhv10AvJ+PwLOS8WFI+uppTOiqRpRGsZl7MC0OQB05hgP9D/Powpuo7rDikdn0HG/xdzgXA73C7xRs/OgkoJvJ1IKrztcrrjQ8mLcCY4ZfbtZOQSj3lY7bguaIZ8LeIrAolOZNdeEmFFUpTdZn1NalGpP+mmb1HrMe18Ne1zV+14CqCjMdpose1pavuC39jTrLh9D/+tKQrS1+yYzITD11gkAMkTvN/MmFbOba0SQlwHn4LN/nCPH3yB8oUuielsz/EnKByxz1TG6q70BdTA7ZJ4tIVmf49T2drqd8GahR19X5Yj2zOpTYjeHtnwoEBMge/OzIz6VD3u0ecgYDXRDx7llG7cx/fBhi3sxd9L1v9ugIYui8XNjD6Oeylfq/D9UOV394qjVq3qnz8+LlVtebjkVP5HiIHxY+/eGuLUriltM7C05MUciCBrzqb7E2DTdhmowJhwGS2JvcMqz5xsmAgusAOzU4oQjOixxE07QjiUlekWffYiNpU37XIovknRaeV8udcObQ5gLQPb9DQMIWdbdUHrGpwIBukHROvsGK0oZDeaRkqGZMILb/jKunx/7DXeduyTlnlTlE8Xpi9TLqrIwDiUBoQv/6Zw8vxPXasVLCDQhXXLNloO6FHrKlDCS4UmlpZYXJFfULsfamvPdGp7bWbg/TtzglCJjA3mmCH1eaQBW3FNeWt0kaGj9Or1sB68+Eo5OrKZZ6jlG8W7aGllZag192xCcg6m/YNfg+cq4
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5be9af7b-52c3-4d1c-14bd-08db5b9f09cb
X-MS-Exchange-CrossTenant-AuthSource: CY8PR10MB7243.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 15:04:42.7896
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 365yVY2552ukrqvkGFdoCv99JQIPRpIlpAAzK2Ur2lKL1itg5HMqTeNqrJOuMVQm1oJ5mNS55NJfgau7VV4WcgOUCjOJ2OOZxiKIF6Nt/xU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR10MB7442
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-05-23_10,2023-05-23_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 bulkscore=0
 mlxlogscore=999 mlxscore=0 adultscore=0 spamscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000
 definitions=main-2305230118
X-Proofpoint-GUID: DdCblwIOZHjH8EUSD9yb2-Npi01kFymX
X-Proofpoint-ORIG-GUID: DdCblwIOZHjH8EUSD9yb2-Npi01kFymX
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 5/20/23 8:19 PM, Martin K. Petersen wrote:
> As I alluded to in the tracing thread, I'd like to see SK/ASC/ASCQ being
> generally available in the scsi_cmnd results instead of all this sense

Do you mean you just want a scsi_sense_hdr struct in the scsi_cmnd?

If so, I can do this when I resend the scsi retries patches since I have
to touch every scsi_execute_cmd user and test them (at least what I can
because I couldn't test things like scsi_dh_hp/rdac).

For the scsi_execute_cmd issue would we just do:


scsi_mq_init_request()
{
	cmd->sshdr = { 0 };
	....
}


scsi_execute_cmd()

	blk_execute_rq()

	if (sshdr)
		memcpy(sshdr, &scmd->sshdr, sizeof(*sshdr);

?


> buffer and sense header micromanagement in every caller. That's a pretty
> heavy lift, though.