Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 23 May 2023 16:40:46 +0200
From:   Michal =?utf-8?Q?Koutn=C3=BD?= <mkoutny@suse.com>
To:     Haifeng Xu <haifeng.xu@shopee.com>
Cc:     mhocko@kernel.org, roman.gushchin@linux.dev, hannes@cmpxchg.org,
        shakeelb@google.com, akpm@linux-foundation.org,
        cgroups@vger.kernel.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] selftests: cgroup: fix unexpected failure on
 test_memcg_low
Message-ID: <r5owzlvxbx22gqmw2cnmykvrzzhhw3hkoffk3f4wbvv7lmqzod@wbbmnt4a76cu>
References: <20230522095233.4246-2-haifeng.xu@shopee.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="qrfw5lltt6r2lzen"
Content-Disposition: inline
In-Reply-To: <20230522095233.4246-2-haifeng.xu@shopee.com>
Precedence: bulk


--qrfw5lltt6r2lzen
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, May 22, 2023 at 09:52:33AM +0000, Haifeng Xu <haifeng.xu@shopee.com=
> wrote:
> Since commit f079a020ba95 ("selftests: memcg: factor out common parts
> of memory.{low,min} tests"), the value used in second alloc_anon has
> changed from 148M to 170M. Because memory.low allows reclaiming page
> cache in child cgroups, so the memory.current is close to 30M instead
> of 50M. Therefore, adjust the expected value of parent cgroup.
>=20
> Fixes: f079a020ba95 ("selftests: memcg: factor out common parts of memory=
=2E{low,min} tests")
> Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com>
> ---
>  tools/testing/selftests/cgroup/test_memcontrol.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Yes, the expected value should be complement of the allocation to the
limit when reclaim is allowed.

Reviewed-by: Michal Koutn=FD <mkoutny@suse.com>

FTR, the test_memcg_low fails after the fix still (6.3.1-2-default)
because of nonzero memory.events:low in the unprotected A/B/E group
(with memory_recursiveprot).
(That's another and long standing issues -- perhaps the reason why this
issue was hidden.)

Thanks,
Michal

--qrfw5lltt6r2lzen
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQTrXXag4J0QvXXBmkMkDQmsBEOquQUCZGzQbAAKCRAkDQmsBEOq
uZ7BAQCh/IzL0Y/nVUwN/zZJm3gzAUIYiiYkjKXr3IdIi/nEEAD8CrjZAUCERkWq
My0modfCN7u48OMYoc2a0660bD9tYww=
=er1S
-----END PGP SIGNATURE-----

--qrfw5lltt6r2lzen--