Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp4481891rwd; Tue, 23 May 2023 08:15:20 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ76MsydY0hdd5f87AJWt9aL7yhsKWK7h8HfM4MeRj/h97foN5ycjgDSZq/l32UW4X3dFqfD X-Received: by 2002:a05:6a20:c907:b0:100:ac13:9a57 with SMTP id gx7-20020a056a20c90700b00100ac139a57mr13080105pzb.55.1684854920133; Tue, 23 May 2023 08:15:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684854920; cv=none; d=google.com; s=arc-20160816; b=DqZOM/vgnfXTJ6IDd1/tbsNwKqBlAeyauuEuJiA6HRisC1t9D2ljb0y6IT6unkAFTY jvobh4X0bxWoEeU6SfQEi+Pe3WelaAUGR1/Rfou77y6CqkeY8J0Cw1PiQ5aGuUWCTMM/ 5gO+X29PbwIFua9ByGKppi2MmJX4GUMNzdn7MEcKKPTWuApOBbQwBQaekcpqN7XcTtSH PZe0PEq/7ZFsZfwOMQjn5X+EeLTx0gezgFUWq0djLQ41FAOKRNVAuvYt0ZJI54jlG232 1QiyghOLtgXpaDFnsyGtWIv2P/hVEnIlkO8qCOO6dzaRULnFI5oWgWgNpda0fuW/sHk7 xbUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=g2BUiSAOMYWx6drU8JcC9l59Yd7svEQSTKP4Nh7QR2I=; b=OcWnMA8HF4SMWrR+W6xSk1km2YIWPoMGLu3/8EEDiflutXjdXIJhEgIpuAf9Qy/8jp v5+OpOinUarox1M6bRfJ1tcdS5DhRT5sARNPMAtDVNAlfPpmotmRpasX364J77cL9Xl5 +y1aPHIaH5CwmpZJJhfTTRgHCWdzK068WUselsligx2kbLx/bJJNbPWWeCHqxw0Nqyhv BTvfrECy0dHYW0pQxYT6fDFrtk8SY6hYB8r4qx4JnX+JRCnJshVTOMxEnLuU+FGmvT0t x7kkqq5Rw6SmaxwJPUPEht8mVTfpcfc44gXzIALJiB1KvtSrP4E6qvgfScuUteZ9cNtt /wsg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s2-20020a632c02000000b005288509b88asi2965385pgs.681.2023.05.23.08.15.06; Tue, 23 May 2023 08:15:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237403AbjEWO5i (ORCPT + 99 others); Tue, 23 May 2023 10:57:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237037AbjEWO5g (ORCPT ); Tue, 23 May 2023 10:57:36 -0400 Received: from smtp.missinglinkelectronics.com (smtp.missinglinkelectronics.com [162.55.135.183]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B71F3139; Tue, 23 May 2023 07:57:30 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by smtp.missinglinkelectronics.com (Postfix) with ESMTP id 460222066D; Tue, 23 May 2023 16:57:29 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at missinglinkelectronics.com Received: from smtp.missinglinkelectronics.com ([127.0.0.1]) by localhost (mail.missinglinkelectronics.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aBGxfYAg7Nb9; Tue, 23 May 2023 16:57:29 +0200 (CEST) Received: from nucnuc.mle (p578c5bfe.dip0.t-ipconnect.de [87.140.91.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: david) by smtp.missinglinkelectronics.com (Postfix) with ESMTPSA id B90BC20484; Tue, 23 May 2023 16:57:28 +0200 (CEST) Date: Tue, 23 May 2023 16:57:23 +0200 From: David Epping To: "Russell King (Oracle)" Cc: Andrew Lunn , Vladimir Oltean , Heiner Kallweit , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com Subject: Re: [PATCH net v2 0/3] net: phy: mscc: support VSC8501 Message-ID: <20230523145723.GA8529@nucnuc.mle> References: <20230523090405.10655-1-david.epping@missinglinkelectronics.com> <20230523133236.GA7185@nucnuc.mle> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 23, 2023 at 03:32:06PM +0100, Russell King (Oracle) wrote: > I'm sorry that you're the one who's modifying the driver when we've > spotted this, but please can you add a patch which first removes > phydev->lock from vsc85xx_rgmii_set_skews() and then your patch on > top please? Sure, no problem, will do that. Thanks for your detailed post.