Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp4509270rwd; Tue, 23 May 2023 08:35:48 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5QHLQSsS9F3hVKGv4XAlr60RHcyTBPzR8t1rSxm+MZ56+sF0d4FiTCQLAvdiBsH/e4kZqh X-Received: by 2002:a17:902:ab4e:b0:1ae:4ddd:9961 with SMTP id ij14-20020a170902ab4e00b001ae4ddd9961mr14421797plb.20.1684856147800; Tue, 23 May 2023 08:35:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684856147; cv=none; d=google.com; s=arc-20160816; b=riOYZw0PDU9J62fTNNYVPe90FlfiTixxLk2iZQ+UxGnVQAwHAhfeGIzxGHMWIhYdZZ L1QKxi9GraNzfvsoDe0ook68sWtO2bhCZ3xWZdmEv36yB+lV/fgOn2RovMRGJVT+d8M7 YEwIhdj/rhGxOyJfShfAAiNZzbDgWhUSk5dTbpURJ0uQbWUEjV0woKIbgoMhLJ0tGih3 qIGHYFHTrICsUo7OYqp8XhJhaL0fWM1pIbHHKQkHwVG5BIFnNWwMivPEvNkLWyLBuLJ+ uEYdv1t9dVTjNAw1AOKF+HOGuSqq19XuzDLl8vyUWkUkQwu077HvSoUQdQe1EbDxaJmY nOHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=K7SHk58VdIU/D8BkmBJwnZ5HgGisjRkL1nflq6B55tM=; b=vV+DkVn21mDEdDt9lTT6hH4OSsTgEy1ly2YTXIIemIm81lT92ngXv462wgBlF3i6de rR2U8H7bUxHE8sTp1g4sb0iGXqQ/Vw6jSl0QyyIIyUANWl+iSdmMvF0ifwE5gis0eLgm kBevjbvVF5TTJlzgB/nHd6WlwN4jvhTo0KeSyYDg+qs+HD0wpNloz5bwlPOzvcBDO5eg 6aJMtrYH87idiYPDnqYoPFm2BWY16qOx2wqO5DyLVgq4NACMLzlgD7o8Y7Dy8p9UnkNq KTHASVqiOKD3EHkrZqDKE3xohkBImRAw3NL5gedMwI49vgCL+UlAxBWX7tp+hzk4KS3U gODQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CsD5FvOL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o11-20020a170902d4cb00b001a94b91f428si3549416plg.319.2023.05.23.08.35.31; Tue, 23 May 2023 08:35:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CsD5FvOL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237553AbjEWPdd (ORCPT + 99 others); Tue, 23 May 2023 11:33:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237363AbjEWPd1 (ORCPT ); Tue, 23 May 2023 11:33:27 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03B5D1B9 for ; Tue, 23 May 2023 08:33:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 70DB163244 for ; Tue, 23 May 2023 15:33:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98DA9C433EF; Tue, 23 May 2023 15:33:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684855985; bh=osoUBAnh7wvCQvzNl0PgfYGMWjN8YEhX5fAYqCQLKzs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=CsD5FvOLNBtOHCzlORiS08JfHlTgrKDJ5DgzJRAMX8Szo0TGh/MNFDjkA+4xEI7QY 0bfWA20QCAULF/6bcwFB8NE6zUyyyn3k0vBLfhFoqI8nPBO4wt42saFO/RVE3Zu2Bi eeMy2Q8jX8KFs+xm5e8cex9vAK5wFKb1WAxTcXB3om6BBMzThwoU6Sq+pFwkO/5GRU dB60z6Ya+Z9QtgAur3ziHuqpCRg8jez52BE0Kt6txc8lRoMu2Bk5WcDwpSIbT5Xuw+ gbtfRIEKPDv6JCdg7Ojri/pc3mE9N9OmRYYCbhZkqsu0YQIcFi1YuqptIZV13m8FEQ kA6x4UUKTr5TA== Date: Tue, 23 May 2023 08:33:04 -0700 From: Jakub Kicinski To: Peter Rosin Cc: LKML , Dinan Gunawardena , Kalle Valo , Johannes Berg Subject: Re: [PATCH] bitfield: suggest using bitwise OR when combining bitfields Message-ID: <20230523083304.4a02d16b@kernel.org> In-Reply-To: <9b872036-42ce-2d08-2e98-12bf0abf7095@axentia.se> References: <9b872036-42ce-2d08-2e98-12bf0abf7095@axentia.se> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 23 May 2023 14:16:30 +0200 Peter Rosin wrote: > Logical OR fails to deliver the desired result. Most of the time. > > Fixes: 3e9b3112ec74 ("add basic register-field manipulation macros") > Fixes: e2192de59e45 ("bitfield: add FIELD_PREP_CONST()") Fixes tags for comment changes are an overkill. The change looks good. Who are you expecting to take this patch? Feel free to repost this CCing netdev@ so networking can take it, otherwise maybe Andrew will? Not sure..