Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp4529272rwd; Tue, 23 May 2023 08:52:06 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5Com/TtKF5HfKomIC3ipt0KSjz5mFQ41LtSGtBtk01Q7CpmncUChBE6qXTaBxKj6qvtNaw X-Received: by 2002:a05:6a20:8e13:b0:10c:2a14:a357 with SMTP id y19-20020a056a208e1300b0010c2a14a357mr5012097pzj.26.1684857126453; Tue, 23 May 2023 08:52:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684857126; cv=none; d=google.com; s=arc-20160816; b=ioB/adrnLno1h45Y3G2tpOMmMT5Kobh+LRI9hZZ9R6yk/eB5YXTHCUbTJ09ZWzh2JK bSK4u6C4guNPpCBcNTuRjS8L0qLBf8fkReQjvXnGHLobTF9zvPWbwiplCs8AdfUUL5tt 7qXEdzq9GbCYwM4H3yfW2a2pK4664CDFlmiusXQosfOYYF/S3MAw3jRV6nMfZX2Aewax 7Ub0xc7OsuzYlYZvPJXY/JgnQO5KQHkbNUk8eksXuAJvihirjwA1qDDSbI3RngujvNrA dhT0/JBXrA0hYS+fC/JV4uwSuqRhJc6ZAzhKq6XwgCB6RgscXzIXxcuHKPSClj/4jvHF uNIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=aGfqctuBC+WwUGjhxG17S0MesbLNL96Wm9a3IGm5Kmo=; b=N+76OKFtTIC54ZY9V3uU2nkPWwky/56VQvrzn1CKKA+jsGcqs6cd2ZgtajqgmwhYeZ 4ozBuqcUozlT20hXem3zRwKFiupnPkn7isAiLcagzY/vE1nVRPpqEnFLfMeCSNtXScE9 TJmqrkl1wQXr0IWs7cm3WM+lJxkNWXPayEMIzgp8UbI10eDusYcIT0kVlbdzdUnszopI YH9LrVG9xYl4chngqSfK2M/QXqdIel/+sqAjMnOl117yadGnXdRnAJanpZfOKWrh4SpX c/CHQHVMIsud0Ehj9WWNDnInevcTs7BOq+oJd8CJlCnbmbwBxv8KQlJHzP6KjIKuHmOb qcog== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b126-20020a621b84000000b0064d33dd541csi2178966pfb.108.2023.05.23.08.51.54; Tue, 23 May 2023 08:52:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237422AbjEWPbk (ORCPT + 99 others); Tue, 23 May 2023 11:31:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237341AbjEWPbd (ORCPT ); Tue, 23 May 2023 11:31:33 -0400 Received: from smtp.missinglinkelectronics.com (smtp.missinglinkelectronics.com [162.55.135.183]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 689B111A; Tue, 23 May 2023 08:31:28 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by smtp.missinglinkelectronics.com (Postfix) with ESMTP id B97572070F; Tue, 23 May 2023 17:31:26 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at missinglinkelectronics.com Received: from smtp.missinglinkelectronics.com ([127.0.0.1]) by localhost (mail.missinglinkelectronics.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2G3HKuyBGfdm; Tue, 23 May 2023 17:31:26 +0200 (CEST) Received: from humpen-bionic2.mle (p578c5bfe.dip0.t-ipconnect.de [87.140.91.254]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: david) by smtp.missinglinkelectronics.com (Postfix) with ESMTPSA id 4010C2066D; Tue, 23 May 2023 17:31:26 +0200 (CEST) From: David Epping To: Vladimir Oltean , Andrew Lunn , Russell King Cc: Heiner Kallweit , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com, David Epping Subject: [PATCH net v3 3/4] net: phy: mscc: remove unnecessary phydev locking Date: Tue, 23 May 2023 17:31:07 +0200 Message-Id: <20230523153108.18548-4-david.epping@missinglinkelectronics.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230523153108.18548-1-david.epping@missinglinkelectronics.com> References: <20230523153108.18548-1-david.epping@missinglinkelectronics.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Holding the struct phy_device (phydev) lock is unnecessary when accessing phydev->interface in the PHY driver .config_init method, which is the only place that vsc85xx_rgmii_set_skews() is called from. The phy_modify_paged() function implements required MDIO bus level locking, which can not be achieved by a phydev lock. Signed-off-by: David Epping --- drivers/net/phy/mscc/mscc_main.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/phy/mscc/mscc_main.c b/drivers/net/phy/mscc/mscc_main.c index 29fc27a16805..0c39b3ecb1f2 100644 --- a/drivers/net/phy/mscc/mscc_main.c +++ b/drivers/net/phy/mscc/mscc_main.c @@ -528,8 +528,6 @@ static int vsc85xx_rgmii_set_skews(struct phy_device *phydev, u32 rgmii_cntl, u16 reg_val = 0; int rc; - mutex_lock(&phydev->lock); - if (phydev->interface == PHY_INTERFACE_MODE_RGMII_RXID || phydev->interface == PHY_INTERFACE_MODE_RGMII_ID) reg_val |= RGMII_CLK_DELAY_2_0_NS << rgmii_rx_delay_pos; @@ -542,8 +540,6 @@ static int vsc85xx_rgmii_set_skews(struct phy_device *phydev, u32 rgmii_cntl, rgmii_rx_delay_mask | rgmii_tx_delay_mask, reg_val); - mutex_unlock(&phydev->lock); - return rc; } -- 2.17.1