Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 23 May 2023 17:02:21 +0100
From:   Gary Guo <gary@garyguo.net>
To:     Benno Lossin <benno.lossin@proton.me>
Cc:     Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Wedson Almeida Filho <wedsonaf@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>,
        =?UTF-8?B?QmrDtnJu?= Roy Baron <bjorn3_gh@protonmail.com>,
        rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
        patches@lists.linux.dev
Subject: Re: [PATCH 1/4] rust: macros: fix usage of `#[allow]` in `quote!`
Message-ID: <20230523170221.77935844.gary@garyguo.net>
In-Reply-To: <20230424081112.99890-1-benno.lossin@proton.me>
References: <20230424081112.99890-1-benno.lossin@proton.me>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yWYjncZyeJOTKI2xLfYl3FyH1qunRMC5ViznAba95mGL7CjSmqro9wKla+HR?=
 =?us-ascii?Q?BeJme1IVk8mu9wOs+uiqe0y7ELrEMTicYGl4cCTvEMqGDwuyi4R/V8opokJq?=
 =?us-ascii?Q?zGxDl7SjLJaTOvPHaM6ykhJ1xTOjC81fHwyzij1bXvHFHP6iZ2iC75K+ENra?=
 =?us-ascii?Q?Z53FSHpdWrhJBlafjj7tPuPohLWVwbia5F1ArA9eiPggzdPRcfmAfYvZFR/5?=
 =?us-ascii?Q?043N5MB8hcIIiApFWM9+OIUjFXcjt+aksJVv2/+dq7rYDh2Y+G1nu+JMUMhz?=
 =?us-ascii?Q?5mfAbMyItoOvXOzg+aBYanxZR7RvthZKXnoe8ZMqqb2wl1cTUgquUqgo4W/m?=
 =?us-ascii?Q?843TLrb97WnNGqYagn1PRNK85WIDheFAlid84rCu92dyeZrGYFX5DLIUhHWn?=
 =?us-ascii?Q?vdnA9/2EuFgTenh8a7WvHqjDZoLRoZG88uHDRp8B/XRdS3dO5flcgG5Bkf5a?=
 =?us-ascii?Q?i/OAfykmQRtLqhaQBG/CUpN6WlXMNCYMVY2kQqFCkuR48okjU1NlUk2OSA/k?=
 =?us-ascii?Q?lb2i8y8KU7ndHpq+/vrXvAR4aw8GQG5srckUvb14rYSN2/Avc+yCiVgl7GYn?=
 =?us-ascii?Q?c4yQzFPEPQ9MqKq1bpokglyN6qtPsB7BrfMB8kfUd8uI9YN/xFPpHS2HLPuZ?=
 =?us-ascii?Q?rN9Z7rZH0339No0EH9ZQfM91nOANFuFqfjGh5W/o0HQ1F0u2NTZKBYnv5e3O?=
 =?us-ascii?Q?tKV27O3olUMeQ25yBRH69FaTd+UL5wsT8AC622tiI9ihrGH2fazHLXTtN4nn?=
 =?us-ascii?Q?HgAoqFYJTj0dNiTKBzoVujm91zOK00lnBibvNeBrPRjZu5oUPwnABzdan798?=
 =?us-ascii?Q?wQbWwXHN/rDKImLZbL/pSzmYJ0Fx4SQy3lwuiHGEyp9007VjyNKozr8W1uAL?=
 =?us-ascii?Q?W66VnFQ9lv6oxCeZ1WZolIfhh660/NBMp4GGIfNqFp+smHsb4IWuXKBA1mwB?=
 =?us-ascii?Q?zY4Qf1bvYxK597YZRDke+fAhSJ9R9CHjE+ar+57gg5zOB2pCz4ORIK8iEALq?=
 =?us-ascii?Q?FKgoKsmh3OmSEuccEncYOMion/RP6jAM4+zKljOYLrAtgv3zbN7rcl+aRAWq?=
 =?us-ascii?Q?5OLZWzxw4iMhZCjpkL0RqlBu9FA9xP5k9Qk3+1Zirw0DytH62mJyWIrhDOgn?=
 =?us-ascii?Q?EuiOs+J4CtKyeb5hMGySeMYWNMlx08P6KKhkrp6wICVo92z6IEga/uGqDys2?=
 =?us-ascii?Q?bWITWwaFFsYgbAFd8RcZgxJMbS9SkVSmR7MMfCXyNq6IiD8VMxxg9z45OJqL?=
 =?us-ascii?Q?19Iatq0bkXmfz2ZnjmeSsN5HgkwQTDDGdN+E4zVcTuyMo9j+m3BmdP9AoRqb?=
 =?us-ascii?Q?J+yHxILFvhXA2GKak6WtZRsqL/2N/tF9w+FVUyYPc9+qxl58fm4aT9S3883r?=
 =?us-ascii?Q?TawR1zSFKtOzLrAPqBKqTOElsl4oSUum5uS5gvPqG3mxlCR0rzVAct4Txz0T?=
 =?us-ascii?Q?ZnI8Azek0ZX9Ey4ohOjkeM2ARtDpfGntA5NPxlHT+0x+mi4CSMmxX7RhT3vJ?=
 =?us-ascii?Q?eBWTs+PXAxIcKxk9Q6QQucZd6gqkIwtyQfx9592NMCYB5sh4dJt7b2yNJvNs?=
 =?us-ascii?Q?aoehbuJLaVIySvb7SVF1IMmOaq5ZEhKEtlFlc5tY?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 4321a183-c117-4bcc-ca42-08db5ba7193f
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 16:02:24.5578
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Z6IQsMFTzuUJc1M+7NHEjCcY7m84Ln5oWaoSyyAJV2isZT2jv0De9G7yx973dSWDq4lnWsYpJFdimUK5ShWcBQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO4P265MB7077
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 24 Apr 2023 08:11:33 +0000
Benno Lossin <benno.lossin@proton.me> wrote:

> When using `quote!` as part of an expression that was not the last one
> in a function, the `#[allow(clippy::vec_init_then_push)]` attribute
> would be present on an expression, which is not allowed.
> This patch refactors that part of the macro to use a statement instead.
> 
> Signed-off-by: Benno Lossin <benno.lossin@proton.me>

Reviewed-by: Gary Guo <gary@garyguo.net>

> ---
>  rust/macros/quote.rs | 14 ++++++++------
>  1 file changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git a/rust/macros/quote.rs b/rust/macros/quote.rs
> index c8e08b3c1e4c..dddbb4e6f4cb 100644
> --- a/rust/macros/quote.rs
> +++ b/rust/macros/quote.rs
> @@ -39,12 +39,14 @@ impl ToTokens for TokenStream {
>  /// [`quote_spanned!`](https://docs.rs/quote/latest/quote/macro.quote_spanned.html) macro from the
>  /// `quote` crate but provides only just enough functionality needed by the current `macros` crate.
>  macro_rules! quote_spanned {
> -    ($span:expr => $($tt:tt)*) => {
> -    #[allow(clippy::vec_init_then_push)]
> -    {
> -        let mut tokens = ::std::vec::Vec::new();
> -        let span = $span;
> -        quote_spanned!(@proc tokens span $($tt)*);
> +    ($span:expr => $($tt:tt)*) => {{
> +        let mut tokens;
> +        #[allow(clippy::vec_init_then_push)]
> +        {
> +            tokens = ::std::vec::Vec::new();
> +            let span = $span;
> +            quote_spanned!(@proc tokens span $($tt)*);
> +        }
>          ::proc_macro::TokenStream::from_iter(tokens)
>      }};
>      (@proc $v:ident $span:ident) => {};
> 
> base-commit: ea76e08f4d901a450619831a255e9e0a4c0ed162
> --
> 2.40.0
> 
>