Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 23 May 2023 17:01:14 +0100
From:   Gary Guo <gary@garyguo.net>
To:     Alice Ryhl <aliceryhl@google.com>
Cc:     Miguel Ojeda <ojeda@kernel.org>,
        Wedson Almeida Filho <wedsonaf@gmail.com>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>,
        "=?UTF-8?B?QmrDtnJu?= Roy Baron" <bjorn3_gh@protonmail.com>,
        Benno Lossin <benno.lossin@proton.me>,
        Will Deacon <will@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Mark Rutland <mark.rutland@arm.com>,
        rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
        patches@lists.linux.dev,
        Wedson Almeida Filho <walmeida@microsoft.com>
Subject: Re: [PATCH v1 2/2] rust: sync: implement `AsRef<T>` for `Arc<T>`
Message-ID: <20230523170114.0e4e12c8.gary@garyguo.net>
In-Reply-To: <20230517200814.3157916-2-aliceryhl@google.com>
References: <20230517200814.3157916-1-aliceryhl@google.com>
        <20230517200814.3157916-2-aliceryhl@google.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Gf6TZT4unONAsDWlxzfcrElKTssCBVsv5t5qucCOkC5xxjuseuG4ghs8a1p8?=
 =?us-ascii?Q?h0MSgX9vuGrO7qciDrgyDuqlua17Q3JXVzYAowoly08Acjzwa4QAdbctpqjh?=
 =?us-ascii?Q?CpqaytyeLAFavIXvjQtkf7+qEPxl4PoTeJy5xlkQah3giigWSCBLTkwr2jbw?=
 =?us-ascii?Q?GBMZRgUypU/4vPFfZGLVbeIVWt1szks/pTmoeNFhgJN/tZnd4xKNJ6mjN0JL?=
 =?us-ascii?Q?FrAdGV7ss70RMnCHgnS8mEHPfxjpFef8U5XosBoztQGO8Oyr1iLg1HNp7oii?=
 =?us-ascii?Q?aSqYJEVX9Jvn1inSYpUqEJ+ivruelxciz8QzAEBApJMislSR2lGCMw+HvV/H?=
 =?us-ascii?Q?DoGNkpXGKEOIXsyFAPIuONXDavVd8fCBv38R4SW+mH+JaqJaBb0K5peUVup8?=
 =?us-ascii?Q?abpw3EIY9jyQ1D1Z1O/jJaEtzyJZF5e/9VOWuNm38wuXjEePSYPvKCXXn/OC?=
 =?us-ascii?Q?9OuEgyyjjA4JrOuvr1X6LRwkLmkjvTj9LRq+1xM2YnkMByDAJJI4taY/QWpa?=
 =?us-ascii?Q?5r9gTrcp0m7UYeb+TsEIyR72X5qQcHO/xKF37gPCtolmoXIVNcV/3crY1fRr?=
 =?us-ascii?Q?OpwF+Om8L8rtW09igfVRtKSKvvKdg9WW8nRmIzYft60PlvhoibFTSuziaVqo?=
 =?us-ascii?Q?amEL0gGIKIF66VL1XFAFb91aPCs9uo/aDQvKxogtwp6kI+SoOAkACzDjIIpH?=
 =?us-ascii?Q?GelQuAUtQnXz20N2qConUQq/saLPNenBLZay0rty+W+oiwO/m+xSowjrR6V8?=
 =?us-ascii?Q?rIgtYMMYYG44pSx/9DCKiVYIds07roPD+cjshkaNcVa6/jxVXMCXpO5+/E8q?=
 =?us-ascii?Q?Ajc7cQyxBqgE1XuBOKLmx/o+uy5bB5yuJ8C33GV2DpCodOym0dDFF66A2KrU?=
 =?us-ascii?Q?PgVbprRpApEOPSO/qj8q/XTeZnkdd7ckWaoaxW+2lSmJD//TkpB8S+iHTPNe?=
 =?us-ascii?Q?p9nfTvTXrPYn/1HKJD7blNhZpT0dqX1oiw32GoisJWS49AHUrrEc32MorwuT?=
 =?us-ascii?Q?CBEausWzM0nEblHfey2hFCDvj3a5wOPnfHYx4pXdS1BEWqPcvgM2YWzJdiK0?=
 =?us-ascii?Q?CYwW4tr0T0/PgeabRnPzqfcn5cknNdzSoNSgPrEizHXcDsFhRFETBTA+SajF?=
 =?us-ascii?Q?5VgEUg4mz0TTU+ehR3X2Eoj37ztYxlcHgBtvvPCdLreWWJzArO0BX6FlDH64?=
 =?us-ascii?Q?FIuT1knxpsl2zM53uqI5O5p642bgjvbqWVm8B7IR6kF0T8KE877OeuvVG1wx?=
 =?us-ascii?Q?Gdq/DzRLbJSuzh3y13y0gZF10s5YtqfoFKMQUzWzPGiRvkIcIHga4vJkhZzL?=
 =?us-ascii?Q?cOK8egYvZ7wRlpidk2a/Rx1TVgYi+wsGGuUlpm2kOqQmzQF9VKRBoZAqOM1Q?=
 =?us-ascii?Q?6N7Zkxh684Lg1O2hxUW8rmIadoyVEp9dBTSSCrqlAoJlPDnnUVwhFV7N6ROX?=
 =?us-ascii?Q?rxIByWL/dw5FvS3t3IgSah08++x6DkEc03kztyCzK6ADj74EZxEZnhWS00Oo?=
 =?us-ascii?Q?ke0gZG5kCXpGmYWo/MmoetcnVIp3bo4ZnxbhRLP4smwVQYjUq+yqY0XIwGF/?=
 =?us-ascii?Q?A8itG66zpOXzWmQChWpozpCuQnhOL5vHpHgXw4UZ?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: d546a09e-2482-4aad-69d0-08db5ba6f079
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 16:01:16.1662
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XL2j9xif4dk8Vs/QNY8tO9ow01/pXMgUMNvluLbhLz/abwdSL5GI2ZCKip32yJq22ilWcF5IW+U4xanGQbphVw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO2P265MB5136
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 17 May 2023 20:08:14 +0000
Alice Ryhl <aliceryhl@google.com> wrote:

> This trait lets you use `Arc<T>` in code that is generic over smart
> pointer types.
> 
> The `AsRef` trait should be implemented on all smart pointers. The
> standard library also implements it on the ordinary `Arc`.
> 
> Co-developed-by: Wedson Almeida Filho <walmeida@microsoft.com>
> Signed-off-by: Wedson Almeida Filho <walmeida@microsoft.com>
> Signed-off-by: Alice Ryhl <aliceryhl@google.com>

Reviewed-by: Gary Guo <gary@garyguo.net>

> ---
>  rust/kernel/sync/arc.rs | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/rust/kernel/sync/arc.rs b/rust/kernel/sync/arc.rs
> index 274febe3bb06..9ec911e4a0c7 100644
> --- a/rust/kernel/sync/arc.rs
> +++ b/rust/kernel/sync/arc.rs
> @@ -264,6 +264,12 @@ impl<T: ?Sized> Deref for Arc<T> {
>      }
>  }
>  
> +impl<T: ?Sized> AsRef<T> for Arc<T> {
> +    fn as_ref(&self) -> &T {
> +        self.deref()
> +    }
> +}
> +
>  impl<T: ?Sized> Clone for Arc<T> {
>      fn clone(&self) -> Self {
>          // INVARIANT: C `refcount_inc` saturates the refcount, so it cannot overflow to zero.