Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp4593885rwd; Tue, 23 May 2023 09:37:56 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6QN9fbwbsz3I13ZKUzLT3AK9yLg0PFg2J4IFH8Wm00NdEGoEFwR+DmEad72aoyIuY3JJ3P X-Received: by 2002:a05:6a20:6a0e:b0:10c:127e:1c with SMTP id p14-20020a056a206a0e00b0010c127e001cmr5231487pzk.14.1684859875755; Tue, 23 May 2023 09:37:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684859875; cv=none; d=google.com; s=arc-20160816; b=CIVl09iPg2gbYXY4O3j/2wnfg3M1WfJpNjBskrkziO7LMftYf49Yq5FHbEJpXBE61s lU77haZammbVG87D1wKRFlM8NRNgnGUGHLIQh6BZQVyhkOgvo8meRibNmyoH7JMeIdDp eY3Ym2tfOGoxUXa9mW7lsJgDYMaN7iRG4Dyy6CcB2wdFreWYiEXSvoiyH1JUIlxWn6N8 5StyrU2TwaGl29GW/h2gGVCoi0g0q1eKmosLfkKjveMGQt75EgeMtVbQJ+QH+dj9eYNo ha2Tx1vAV1LLM7oMMLNdj/dYmcvvjpiY0nY2TKlN6QG3+1nK+V+1lCnirme0Qlf4cN5K 6tQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id:dkim-signature; bh=NVzMHJjDBnQq75oO+WmTbCAMNHA+96SYiTODKt5338c=; b=Va+Z+LKlgOmaxoLS7dczvU5HcgG8LFndrty1dL/vmFhJsYIwHThmwsXOHEeIRzGzVg QVdNvSHRNdRpTNWTCWE8at6d0rrAScv1/E4vHRnXHMtQo774tFEojyH8xNhDrl3Pkll0 KXHNrwpiHsFp+rMW8c0FpDeDxqwVuOgP9fzXwj883C07Kn+0e6Dw6LzedlLcpJjTVzhV Av9dkGXoYtGSdAH7jg8BbXBQc6mVxOIb9BexrHpUwX38HpSMwNjW0lItvU+A7/5N6SpC 8MUb7egYEX4p8ZNnWALcowMtBCwZddjPbmV1VL1HH2CHY2GVHgBULbGHAth6vSmfJLng Hu6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=gae5G8EC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v190-20020a6389c7000000b00534842ba60bsi2145101pgd.246.2023.05.23.09.37.42; Tue, 23 May 2023 09:37:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=gae5G8EC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237699AbjEWQe0 (ORCPT + 99 others); Tue, 23 May 2023 12:34:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236778AbjEWQeW (ORCPT ); Tue, 23 May 2023 12:34:22 -0400 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10A0F12B; Tue, 23 May 2023 09:34:06 -0700 (PDT) Received: from pps.filterd (m0353727.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34NErM2o004959; Tue, 23 May 2023 16:34:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : content-transfer-encoding : mime-version; s=pp1; bh=NVzMHJjDBnQq75oO+WmTbCAMNHA+96SYiTODKt5338c=; b=gae5G8EC0rF1m8C/f5IffgfnSizOA0XmsutlbFFdRdiLf3ECgpC9Sfc+F0VTR6LTE23o uOS8T776eaPJVjQ5DIB68xnT2FidnX0sFUN565ikvNs2Stsck1qNFYbBuiOfzc2FvFvc Y4BCv0j7A4EhLDbv80o9sN34vug3y+edBOCEdG/bgwZRIJiqEMm2Eys74QKwPPBrNF5i MwgXp/Ktpd0aLNdlm7EJzVvLbTBn5fl4SHFtenwviFlCGoIMtUVqbgGFwlH4o7+U410I 6VWUpjC/w/sF8tlrlULIHr1O5Mhl6NLTk09njwblukHDZ52asbLhBQYXmk/3IeOCTZQs qg== Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3qrymw2njb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 May 2023 16:34:03 +0000 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 34NECakD014205; Tue, 23 May 2023 16:34:02 GMT Received: from smtprelay05.wdc07v.mail.ibm.com ([9.208.129.117]) by ppma03dal.us.ibm.com (PPS) with ESMTPS id 3qppbsky2f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 May 2023 16:34:02 +0000 Received: from smtpav04.wdc07v.mail.ibm.com (smtpav04.wdc07v.mail.ibm.com [10.39.53.231]) by smtprelay05.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 34NGY0X71638946 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 23 May 2023 16:34:00 GMT Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 83C515805F; Tue, 23 May 2023 16:34:00 +0000 (GMT) Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0A8C458054; Tue, 23 May 2023 16:33:59 +0000 (GMT) Received: from li-479af74c-31f9-11b2-a85c-e4ddee11713b.ibm.com (unknown [9.61.95.28]) by smtpav04.wdc07v.mail.ibm.com (Postfix) with ESMTP; Tue, 23 May 2023 16:33:58 +0000 (GMT) Message-ID: <46a965e53acef4497d2f0da24267f484daf29e1c.camel@linux.ibm.com> Subject: Re: [PATCH 2/2][next] vfio/ccw: Use struct_size() helper From: Eric Farman To: "Gustavo A. R. Silva" , Matthew Rosato , Halil Pasic , Vineeth Vijayan , Peter Oberparleiter , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle Cc: linux-s390@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Date: Tue, 23 May 2023 12:33:58 -0400 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 3mL3btsHtoC-ne_FqfGVhfMeVLjDT3PP X-Proofpoint-ORIG-GUID: 3mL3btsHtoC-ne_FqfGVhfMeVLjDT3PP Content-Transfer-Encoding: quoted-printable X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-05-23_10,2023-05-23_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 suspectscore=0 adultscore=0 impostorscore=0 mlxlogscore=847 clxscore=1015 spamscore=0 lowpriorityscore=0 mlxscore=0 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2305230132 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2023-05-22 at 19:35 -0600, Gustavo A. R. Silva wrote: > Prefer struct_size() over open-coded versions. >=20 > Link: https://github.com/KSPP/linux/issues/160 > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Eric Farman > --- > =C2=A0drivers/s390/cio/vfio_ccw_drv.c | 3 +-- > =C2=A01 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/drivers/s390/cio/vfio_ccw_drv.c > b/drivers/s390/cio/vfio_ccw_drv.c > index 57906a9c6324..43601816ea4e 100644 > --- a/drivers/s390/cio/vfio_ccw_drv.c > +++ b/drivers/s390/cio/vfio_ccw_drv.c > @@ -171,8 +171,7 @@ static int vfio_ccw_sch_probe(struct subchannel > *sch) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0return -ENODEV; > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0} > =C2=A0 > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0parent =3D kzalloc(sizeof(*par= ent) + sizeof(struct mdev_type > *), > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 GFP_KERN= EL); > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0parent =3D kzalloc(struct_size= (parent, mdev_types, 1), > GFP_KERNEL); > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (!parent) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0return -ENOMEM; > =C2=A0