Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp4614017rwd; Tue, 23 May 2023 09:56:37 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ46vhSV7gR1TxUe1kpOPQic6L8YP05WqYhebCJjeiGcDy7hUwwyIIGnMTjKvcdTBqNq7e8Q X-Received: by 2002:a05:6a20:a115:b0:105:a24f:cff1 with SMTP id q21-20020a056a20a11500b00105a24fcff1mr13413168pzk.24.1684860997533; Tue, 23 May 2023 09:56:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684860997; cv=none; d=google.com; s=arc-20160816; b=Ni5jX7kU5ccAf4Vi5bUdY16beCDSJVbJ0d9rPZ3QpStzNjFEV1GyCHEYAn65TD0F80 UEpHQNrdsKugWUjAK3b2DYGcEKq+lpfwx1UMivhk+ecwkSankyot/cFg7jgTGaqOj5Bp ecAhEYdxQGaHn01bHP50IpWjcL9T3336Ona6iiTFvvwe7PeAmq9Fusjh5w9F7u6zDAHf rgoGozgdR4mR3O+QpBstFCCJJAaBWrO+nMgzE/RJQd1X3rQN1uIxmSpuWu1Y5LjpMLsA gV1yEO5m8fkRuYB+iMkXIpI9ZZjIpkBl6oUdDqLiR80tsvFP/bVNjTlO0LVHTneY0uRq +cnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:reply-to:message-id:subject:cc:to:from:date :dkim-signature:dkim-signature; bh=wrLx0Egcaw0whIq7DRTtuN+cxqWzcno7lSmgBonJeXA=; b=WHyoKYqLlPxDKBJDMwUOXgbGJoVI+9qiQAyyQOBwIfeEav5WrJy4/G+93irrsWaVFf PE8OTVyJnJ7ArQv2MdccX2Tr9MDnD2vtRjZSwRF7M2KvUJRm71ds5LL0AdLdOn6iFEAP 8RgOsvSsB7pZ2WrSIUK1Hj76ODWiTlou+5g4e00fCbTfK9eEzna3YeydLbvZmTBvIEJc ljhV/CgVKPkEuAaJ0OObGJfyHJEgsUW2OVW6JDmJOs35MwjjKcwZrvkWoqy78C5BhFkS 0gwX7hbxkR78+5/abyvAtZM8tNN+fABd1MIXurXsyIWhqUuJvFVUOtglkFDeb+N5NYSm u5Gw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=LC+69jTo; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=MpvjYiTf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t2-20020a17090a4e4200b0025082583ae6si2980864pjl.187.2023.05.23.09.56.22; Tue, 23 May 2023 09:56:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=LC+69jTo; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=MpvjYiTf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236828AbjEWQaM (ORCPT + 99 others); Tue, 23 May 2023 12:30:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235459AbjEWQaJ (ORCPT ); Tue, 23 May 2023 12:30:09 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1595C2; Tue, 23 May 2023 09:30:07 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 23957227E1; Tue, 23 May 2023 16:30:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1684859405; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wrLx0Egcaw0whIq7DRTtuN+cxqWzcno7lSmgBonJeXA=; b=LC+69jToeST6d2IF1TdJH6kiCDDPcm7fdmkXnivKpaoxE1boWMPwxiPVqzyJE65siJY23V uuj7yTe+4srNnFdmw23A53bYIXXJiWou5+DQ1XPfS14+9D6xHV2rU1RnHQ8E5+ulOUfWTu xAfgWOweUgC/SzDJDdx0ilBwX2yX01I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1684859405; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wrLx0Egcaw0whIq7DRTtuN+cxqWzcno7lSmgBonJeXA=; b=MpvjYiTfjUOWbbzzdRvKMyyQIar/RVwcbR8LuwtUCm21Kk9fsoIpT/ns/pnqmZa7xkKxMG 4SWPukg946lcdfDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DD9E813588; Tue, 23 May 2023 16:30:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id VdFTNQzqbGQdHwAAMHmgww (envelope-from ); Tue, 23 May 2023 16:30:04 +0000 Date: Tue, 23 May 2023 18:23:57 +0200 From: David Sterba To: pengfuyuan Cc: Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, k2ci Subject: Re: [PATCH] btrfs: fix uninitialized variable warnings Message-ID: <20230523162357.GX32559@twin.jikos.cz> Reply-To: dsterba@suse.cz References: <20230523085935.713859-1-pengfuyuan@kylinos.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230523085935.713859-1-pengfuyuan@kylinos.cn> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_SOFTFAIL,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 23, 2023 at 04:59:35PM +0800, pengfuyuan wrote: > > There are some warnings on older compilers (gcc 10, 7) or non-x86_64 > architectures (mips64). As btrfs wants to enable -Wmaybe-uninitialized > by default, fix the warnings even though it's not necessary on recent > compilers (gcc 12+). > > fs/btrfs/tree-log.c: In function ???btrfs_log_inode???: > fs/btrfs/tree-log.c:6211:9: error: ???last_range_start??? may be used uninitialized in this function [-Werror=maybe-uninitialized] > 6211 | ret = insert_dir_log_key(trans, log, path, key.objectid, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 6212 | first_dir_index, last_dir_index); > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > fs/btrfs/tree-log.c:6161:6: note: ???last_range_start??? was declared here > 6161 | u64 last_range_start; > | ^~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > > Reported-by: k2ci > Signed-off-by: pengfuyuan Thanks, this warning got reported reported recently [1] and the fix is now in queue. [1] https://lore.kernel.org/linux-btrfs/20230516013430.2712449-1-zhangshida@kylinos.cn/