Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 23 May 2023 17:55:39 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc:     perex@perex.cz, tiwai@suse.com, lgirdwood@gmail.com,
        ckeepax@opensource.cirrus.com, kuninori.morimoto.gx@renesas.com,
        linux-kernel@vger.kernel.org, pierre-louis.bossart@linux.intel.com,
        alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/2] ASoC: codecs: wsa883x: do not set can_multi_write
 flag
Message-ID: <00283665-e44f-457b-b2c9-1acf59d1cbd8@sirena.org.uk>
References: <20230523154605.4284-1-srinivas.kandagatla@linaro.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="2MlvJV6gocLMBKO+"
Content-Disposition: inline
In-Reply-To: <20230523154605.4284-1-srinivas.kandagatla@linaro.org>
Precedence: bulk


--2MlvJV6gocLMBKO+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, May 23, 2023 at 04:46:04PM +0100, Srinivas Kandagatla wrote:
> regmap-sdw does not support multi register writes, so there is
> no point in setting this flag. This also leads to incorrect
> programming of WSA codecs with regmap_multi_reg_write() call.

> This invalid configuration should have been rejected by regmap-sdw.

Does the CODEC support mulitple writes?  If so it seems better to leave
the flag set and just do the appropriate fix in the regmap code until
such time as it's updated to be able to exercise it.

--2MlvJV6gocLMBKO+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmRs8AoACgkQJNaLcl1U
h9AWNQf+IPYCRW1gnzWLgW1rC4g+MrykjJLRYtWWmcSWeEZXIsXOZOOTd+SIspbF
xq5Zao7SjZqfhKbAzBKNw7KCRc65si32UyccKO+iIhrRUQ3kKn3cCuX4sOuiCWmk
H22WwBb93WnP51cQAMiTMtBa1x+i/W05l4f155sDsj5g/FrP8CqQK/TFxTrGYGLd
nysG9PKq74NEmvYUeOMkGxprnyGeRbfeT7PWTtQJMCfkkNc7DK3mvCWiCrmX2X7k
xDPMDocsnGHBs8b0/sw/+e7w40F77Jxn/vlZQs7jiURWnyocxMGcW9qOMhv/aZhb
GbCKKHEDuCLpeEFOQlarMbKJXRsSiw==
=qDCW
-----END PGP SIGNATURE-----

--2MlvJV6gocLMBKO+--