Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp4639729rwd; Tue, 23 May 2023 10:14:57 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6EyfSucs27Nx2ymaxiWs7TDRPvyb57pcgRA5mmWqk3apEgbsIbnmaJ22iL+ufKuxS9VTKZ X-Received: by 2002:a05:6a21:33aa:b0:10a:b2a2:a301 with SMTP id yy42-20020a056a2133aa00b0010ab2a2a301mr12500279pzb.12.1684862097191; Tue, 23 May 2023 10:14:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684862097; cv=none; d=google.com; s=arc-20160816; b=tfI/5UikW6vMBKkhbKX+FuQye0ZNOIjiFLXZUq2gMuvO1VxoHeSGq7QOMUJXZ1kaWU Aw95y+P3sVA4iwbj9SGD9tNJOq/AoXPzXvKGtE2NoSGPYJi5GrlE4WzQ0wI8YYdHkGuf GHn/Rr7ouYOwJyU/6uefh6eCVCgi0764ljvYdqM1MUlKTMoPQ5D0rvSZb0ZXEvDzl606 5/tOoQYRttJ3z7LNcfc2qQLbG+yVYHaOfG69KSkB8+i1cYMRn3UkVKDUGoCXkkdZ1+s1 4l/2BVQNAPsbL2YKc3nRxqATJwvZnVe570DMghG0DBFAK5JuDCz0Z5t+JM2mj4vbsHpn 3uVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:date:from; bh=XahzVR7yfB0/QxjpK7iAv3ppMuL2fA7+fNYLDYAEROo=; b=nSn/rwPytCkPik/dQsE2P4nO0fy1L04Hl7LFPnDIpG4+YdZrSaUX4RAbmmPWWVLGEr MiOap0Y3bv+cqgLg4uFy/h1QoTbF5IAHbieFtNvr7vE3sYexQ52TVAeAOx3Q39DVmHlo ynkK9cnHMoe7Ti7ol6HZ+OfG3orPKjDPinH+GwshTtBbU8gH85PdDmvJxm3Xt252jNWk 81iafbLGVQsRpp+i3E5fQ48fFNSb0IkJcUP0fwz4+TepjbS+TR+W3ilmhdfcZxQRz2C8 MmsvIMH6iFshyJ0zXSTjpiUal7oEWJcq446f6LUZri5/vJFQnlFBUqcV8Bz3uOU+yHnU dY/Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b22-20020a637156000000b0053ef0f20fe3si1495603pgn.600.2023.05.23.10.14.42; Tue, 23 May 2023 10:14:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237884AbjEWQ4W (ORCPT + 99 others); Tue, 23 May 2023 12:56:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237863AbjEWQ4R (ORCPT ); Tue, 23 May 2023 12:56:17 -0400 Received: from fgw20-7.mail.saunalahti.fi (fgw20-7.mail.saunalahti.fi [62.142.5.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3E70198 for ; Tue, 23 May 2023 09:56:13 -0700 (PDT) Received: from localhost (88-113-26-95.elisa-laajakaista.fi [88.113.26.95]) by fgw20.mail.saunalahti.fi (Halon) with ESMTP id b8b31ff5-f98a-11ed-b3cf-005056bd6ce9; Tue, 23 May 2023 19:56:12 +0300 (EEST) From: andy.shevchenko@gmail.com Date: Tue, 23 May 2023 19:56:11 +0300 To: Mario Limonciello Cc: rafael@kernel.org, hdegoede@redhat.com, linus.walleij@linaro.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-pm@vger.kernel.org, Shyam-sundar.S-k@amd.com, Basavaraj.Natikar@amd.com Subject: Re: [PATCH v2 4/4] platform/x86/amd: pmc: Use pm_pr_dbg() for suspend related messages Message-ID: References: <20230522200033.2605-1-mario.limonciello@amd.com> <20230522200033.2605-4-mario.limonciello@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230522200033.2605-4-mario.limonciello@amd.com> X-Spam-Status: No, score=0.7 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FORGED_GMAIL_RCVD,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_SOFTFAIL,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mon, May 22, 2023 at 03:00:33PM -0500, Mario Limonciello kirjoitti: > Using pm_pr_dbg() allows users to toggle `/sys/power/pm_debug_messages` > as a single knob to turn on messages that amd-pmc can emit to aid in > any s2idle debugging. It has the same two regressions as I pointed out in previous reply. -- With Best Regards, Andy Shevchenko