Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754381AbXJIX6V (ORCPT ); Tue, 9 Oct 2007 19:58:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751519AbXJIX6N (ORCPT ); Tue, 9 Oct 2007 19:58:13 -0400 Received: from lixom.net ([66.141.50.11]:45160 "EHLO mail.lixom.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751409AbXJIX6M (ORCPT ); Tue, 9 Oct 2007 19:58:12 -0400 Date: Tue, 9 Oct 2007 19:03:18 -0500 From: Olof Johansson To: Linus Torvalds Cc: Thomas Gleixner , Greg KH , Greg KH , "Rafael J. Wysocki" , "Theodore Ts'o" , Zwane Mwaikambo , Justin Forbes , linux-kernel@vger.kernel.org, Chris Wedgwood , Domenico Andreoli , Mark Lord , Randy Dunlap , Michael Krufky , Chuck Ebbert , Dave Jones , akpm@linux-foundation.org, Chuck Wolber , stable@kernel.org, alan@lxorguk.ukuu.org.uk, linuxppc-dev@ozlabs.org Subject: Re: [stable] [patch 09/12] Fix SMP poweroff hangs Message-ID: <20071010000318.GA7875@lixom.net> References: <20071008180406.052382073@mini.kroah.org> <20071008180633.GJ7627@kroah.com> <20071009151702.GA19209@lixom.net> <20071009222003.GA21228@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.16 (2007-06-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1242 Lines: 31 On Tue, Oct 09, 2007 at 04:27:06PM -0700, Linus Torvalds wrote: > > > On Wed, 10 Oct 2007, Thomas Gleixner wrote: > > > > Wrapping it into a #ifdef CONFIG_X86 would be sufficient. > > Well, the ppc oops seems to be a ppc bug regardless. > > If CPU_HOTPLUG isn't defined, the thing does nothing. And if it is > defined, I don't see why/how ppc can validly oops. So I think the first > thing to do is to try to figure out why it oopses, not to disable it for > ppc. The machine Paul tried on most likely has MPIC interrupt controller, and the oops was when the pseries_cpu_disable tried calling XICS code instead. It's not surprising that it failed, I don't think IBM has (traditionally) cared about cpu hotplug on those machines. So the PPC-side fix is to not enable cpu hotplug on mpic-based systems. I'll follow up with a patch, but I have no way to test it since I only have one POWER5 machine, no other IBM hardware. I'd appreciate it if someone with hardware could verify it. -Olof - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/