Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp4668860rwd; Tue, 23 May 2023 10:40:40 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5MRyIbXJOHSMGhRSHsoFOe1+2GaKVUErTPGxVhmYgkvLvqn163WfCo9CMLd9tIvusWp/xx X-Received: by 2002:a05:6a20:5482:b0:10b:71c:20c5 with SMTP id i2-20020a056a20548200b0010b071c20c5mr11678641pzk.51.1684863639960; Tue, 23 May 2023 10:40:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684863639; cv=none; d=google.com; s=arc-20160816; b=K8lgZH/FsaN99R9yAGOO3CC2TT8GcjyjSU9xzEXXWBaIy+9vST1o7ZWz1hk9SzQJ3s hTXsimXBT9GG4UZEwhoTQJip7Mfazs8kLeIWRjAXSjY1WuAG35e6LTbEF6I5001v8wGL Iw4cWqaR5izxpQBPqpWZFyvNzj3+wWy1r3W4rfJp+/ZMcQEnOkDyEzlYbLsoti1D6yf7 /YZPuwZGv8rkJAIktqYa6iJpnWz7tQz/SurUbqNfvor9b+/l88m/SilVESlMTEA3efo7 eZNWCcmOj+FRqXHR4ev+cMMC0kh6pRHBNP+iG2uITsa6KnFDanoMNIbMtWu7K5TZXaft ruPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=nhOVpdiqhCvs7GVV7f2dklwaVtM++uCHQCldPOpHCUk=; b=YB2ppffUOZiz/myDt9gUwK0erWTGI80j9AWkucMeLFpKKmX9ZhHZJo4vBvoiKVY2Db p1T6gBBTFBI+rsybVBPU9iCJrnc0kVBQc2siJBxxqoLJ9HHDfvY5nO9KUd/JyoD6HI+H 3FIcrrL+/YvUbgS0/qpMppy4X4ksxHVApEgXShzBKUJNAwOOfNVEwKgUguqQQlB8TXlm hsgxizYdJEMCgJdngrhC9QkQj/49ZhQxZqkui2k1uaBZ/FhFJv3w8oUqBU9EnLPK9FbG 6j2QIyps9yPLCqHzwFFBsuh4xruwOIG25T7Kn9kE51qIITqy651dCrVNWjtX9WzqR6hq VHnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=A24777sF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x184-20020a6386c1000000b0053b64127cddsi5378077pgd.212.2023.05.23.10.40.26; Tue, 23 May 2023 10:40:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=A24777sF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238183AbjEWRaQ (ORCPT + 99 others); Tue, 23 May 2023 13:30:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238344AbjEWRaJ (ORCPT ); Tue, 23 May 2023 13:30:09 -0400 Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54C0418B for ; Tue, 23 May 2023 10:29:56 -0700 (PDT) Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-64d2f99c8c3so32869b3a.0 for ; Tue, 23 May 2023 10:29:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1684862996; x=1687454996; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=nhOVpdiqhCvs7GVV7f2dklwaVtM++uCHQCldPOpHCUk=; b=A24777sFuS5neXn2X580FSjNLT8hS3n/fA59VHL1HgoGN4qo+vI1L2wT8WPOK1StqC PcNMIz3+z2+2SnzxaOWHjZJNhIlO9GvPIxzUt2GsSAGSw2nIMjGbzqLCnn0lNvkM+zDe J17yTm15T4qXNbdDlwznS7hOhy4dWvxpnay5A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684862996; x=1687454996; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nhOVpdiqhCvs7GVV7f2dklwaVtM++uCHQCldPOpHCUk=; b=AmXwP0oxWqLx9GeQl4nYDSI/DRSQlky9o+t5R+g5SDvxZAP2Z2QbjsovOBDPzt8BEf AOTsGGetoVZIAjEZeSjDOf60V2EAws1jnHHieKHwSREct8ZmupIuhfVr/ycJZPzsPPMn dIdyZEdURjmz5mq7JGlC97MvDH15HVf9wnKUbZztDl+Vv/NgIdY6QDezXST/i6fPdXNZ ijWsE21tuF9uTYbzcQ+s5JwbenhLWO0XP50MVeyc+3OAm4Vbuboyv93DyyLPsbtRQ2pS XnIDxYho3ePeCeadbNPndK2h/Eyp+vhgWojPQ8uwFR3phvis1WlNNtavZ8f7girIh3vE ewEw== X-Gm-Message-State: AC+VfDyee9IfywtZyAugCSrWbV16ARYLE7UI93kaqK/rnPb8gsz/VHPr yY0aAyRm79Qmt6uBizbEEDzi/ulsCKptJ5lOoCQ= X-Received: by 2002:a05:6a20:5482:b0:10b:71c:20c5 with SMTP id i2-20020a056a20548200b0010b071c20c5mr11647062pzk.51.1684862995725; Tue, 23 May 2023 10:29:55 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id bs5-20020a632805000000b0051eff0a70d7sm6210358pgb.94.2023.05.23.10.29.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 May 2023 10:29:55 -0700 (PDT) Date: Tue, 23 May 2023 10:29:54 -0700 From: Kees Cook To: "Gustavo A. R. Silva" Cc: Eric Farman , Matthew Rosato , Halil Pasic , Vineeth Vijayan , Peter Oberparleiter , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , linux-s390@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH 1/2][next] vfio/ccw: Replace one-element array with flexible-array member Message-ID: <202305231029.FC995C740F@keescook> References: <3c10549ebe1564eade68a2515bde233527376971.1684805398.git.gustavoars@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3c10549ebe1564eade68a2515bde233527376971.1684805398.git.gustavoars@kernel.org> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 22, 2023 at 07:35:12PM -0600, Gustavo A. R. Silva wrote: > One-element arrays are deprecated, and we are replacing them with flexible > array members instead. So, replace one-element array with flexible-array > member in struct vfio_ccw_parent and refactor the the rest of the code > accordingly. > > Link: https://github.com/KSPP/linux/issues/79 > Link: https://github.com/KSPP/linux/issues/297 > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Kees Cook -- Kees Cook