Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230519142456.2588145-1-pavacic.p@gmail.com> <20230519142456.2588145-3-pavacic.p@gmail.com>
In-Reply-To: <20230519142456.2588145-3-pavacic.p@gmail.com>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Tue, 23 May 2023 19:33:37 +0200
Message-ID: <CACRpkda8Q+zy-J9Hs28eJuioaE6eEzDmFE6ftEGgs9ot0t4Y6g@mail.gmail.com>
Subject: Re: [PATCH 2/2] drm/panel-fannal-c3004: Add fannal c3004 DSI panel
To:     Paulo Pavacic <pavacic.p@gmail.com>
Cc:     neil.armstrong@linaro.org, sam@ravnborg.org, airlied@gmail.com,
        daniel@ffwll.ch, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, May 19, 2023 at 4:25=E2=80=AFPM Paulo Pavacic <pavacic.p@gmail.com>=
 wrote:

> +//macro for writing to DSI
> +#define WRITE_DSI(dsi, seq...)                                          =
         \
> +       {                                                                =
        \
> +               const u8 d[] =3D { seq };                                =
          \
> +               int ret =3D mipi_dsi_generic_write(dsi, d, ARRAY_SIZE(d))=
;         \
> +               if (ret < 0) {                                           =
        \
> +                       dev_err(&dsi->dev,                               =
        \
> +                               "Error (%d) occurred while trying to"    =
        \
> +                               " write MIPI DSI command: %s (decimal val=
ue)\n", \
> +                               ret, d);                                 =
        \
> +               }                                                        =
        \
> +       }

As said for the other patch, this reinvents mipi_dsi_dcs_write_seq()
so use that instead.

mipi_dsi_dcs_write_seq(dsi, 0xFF, 0x77, 0x01, 0x00, 0x00, 0x13);
etc.

Yours,
Linus Walleij