Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230522212114.gonna.589-kees@kernel.org>
In-Reply-To: <20230522212114.gonna.589-kees@kernel.org>
From:   Song Liu <song@kernel.org>
Date:   Tue, 23 May 2023 10:43:52 -0700
Message-ID: <CAPhsuW5ibONdyyJq0zVCEHuM38GUocn8A1abi4mTa9gUHH1hHQ@mail.gmail.com>
Subject: Re: [PATCH v2] md/raid5: Convert stripe_head's "dev" to flexible
 array member
To:     Kees Cook <keescook@chromium.org>
Cc:     Christoph Hellwig <hch@infradead.org>, linux-raid@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, May 22, 2023 at 2:21=E2=80=AFPM Kees Cook <keescook@chromium.org> w=
rote:
>
> Replace old-style 1-element array of "dev" in struct stripe_head with
> modern C99 flexible array. In the future, we can additionally annotate
> it with the run-time size, found in the "disks" member.
>
> Cc: Christoph Hellwig <hch@infradead.org>
> Cc: linux-raid@vger.kernel.org
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> It looks like this memory calculation:
>
>         memory =3D conf->min_nr_stripes * (sizeof(struct stripe_head) +
>                  max_disks * ((sizeof(struct bio) + PAGE_SIZE))) / 1024;
>
> ... was already buggy (i.e. it included the single "dev" bytes in the
> result). However, I'm not entirely sure if that is the right analysis,
> since "dev" is not related to struct bio nor PAGE_SIZE?
>
> v1: https://lore.kernel.org/all/20230517233313.never.130-kees@kernel.org/
> v2: use new struct_size_t() helper from
>     https://lore.kernel.org/lkml/20230522211810.never.421-kees@kernel.org=
/

LTGM. Thanks!

I will hold this for a while until struct_size_t() merged.

Song