Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9b88ddaf-c5c5-0244-5be7-12400ee54e11@intel.com>
Date:   Tue, 23 May 2023 10:52:48 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH 1/2] x86/Kconfig: Allow CONFIG_X86_MPPARSE disable for OF
 platforms
Content-Language: en-US
To:     Saurabh Sengar <ssengar@linux.microsoft.com>, tglx@linutronix.de,
        mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
        x86@kernel.org, hpa@zytor.com, kys@microsoft.com,
        haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com,
        mikelley@microsoft.com, linux-kernel@vger.kernel.org,
        linux-hyperv@vger.kernel.org
Cc:     ssengar@microsoft.com
References: <1683816877-10747-1-git-send-email-ssengar@linux.microsoft.com>
From:   Dave Hansen <dave.hansen@intel.com>
In-Reply-To: <1683816877-10747-1-git-send-email-ssengar@linux.microsoft.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/11/23 07:54, Saurabh Sengar wrote:
> X86_MPPARSE is only selectable when ACPI is enabled. However,
> on Devicetree platforms where ACPI is disabled, it is always
> enabled. Allow X86_MPPARSE to be selected by OF platforms as
> well.

I'm finding this changelog really hard to read.

In Kconfig, you can "select FOO".  But in this changelog, it means
something different.  I think "selectable" here means that there's a
user prompt for the option.

Could you please rephrase this to be less confusing?

This is also one of those patches where I wonder: Why do _you_ care
about this?  Are you just trying to be nice?  Is this intended as some
kind of cleanup?