Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <52cfebaf-79f6-c318-c14b-3716555d0e8f@intel.com>
Date:   Tue, 23 May 2023 11:03:51 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH] igb: Fix igb_down hung on surprise removal
To:     Grant Grundler <grundler@chromium.org>,
        Pavan Chebbi <pavan.chebbi@broadcom.com>,
        Aleksandr Loktionov <aleksandr.loktionov@intel.com>,
        "Neftin, Sasha" <sasha.neftin@intel.com>,
        "Ruinskiy, Dima" <dima.ruinskiy@intel.com>
CC:     Ying Hsu <yinghsu@chromium.org>, <netdev@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        "Jakub Kicinski" <kuba@kernel.org>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Paolo Abeni <pabeni@redhat.com>,
        <intel-wired-lan@lists.osuosl.org>, <linux-kernel@vger.kernel.org>
References: <20230518072657.1.If9539da710217ed92e764cc0ba0f3d2d246a1aee@changeid>
 <CALs4sv2+Uu=Bry=B3FYzWdNrHjGWDvPCDhTFcNERVpWTjpmEyA@mail.gmail.com>
 <CANEJEGuzoBa_yYHRCa0KygUe=AOhUkSg4u6gWx+QNCuGtKod2Q@mail.gmail.com>
Content-Language: en-US
From:   Tony Nguyen <anthony.l.nguyen@intel.com>
In-Reply-To: <CANEJEGuzoBa_yYHRCa0KygUe=AOhUkSg4u6gWx+QNCuGtKod2Q@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b1FpMUxaZ0pQU2JUN3lyb3dMZUx6QlNIWFRGWjhjMzJwbkEvZllKY2RBV3lv?=
 =?utf-8?B?YnY2YjhLeU92anFxY095MFoxOXU4a1RYY0luNXVJNXZOd0s5eHVDMUZnSTlw?=
 =?utf-8?B?Zi92aC9Ra2ZFUmhqVUdFbWpKL3h4VEJkM2MrOXpzY202VW90K2toQnh6eEpZ?=
 =?utf-8?B?K3hJRFBJKysrK0oyWjRiUFc4ZXcvTldFTnc4TTl4NjVCZTVKV0h3ZVRZcDl3?=
 =?utf-8?B?aTZZTEZjcGtWaURmdnQ2UldtODl0VkRZdUdhU2NjWU1DWVplRkhuSHFsM2tQ?=
 =?utf-8?B?Q2ppZUsxK21yU25BTjRFS1h5d09TU2hNN1pDblJCcWllWHljelpTMVE1MDAv?=
 =?utf-8?B?MmpuMVB3S3RxTHRaUUViaU1QRnJuVnJ2NU1VMHlaUVRrUTd2cnJZVGtISDRt?=
 =?utf-8?B?eS9KTDl2WGg4K2FheTZwbXZJS2V2TCthUFg2RW14MHRpR2hIdCtPTkEvVStY?=
 =?utf-8?B?UEo3QkFFMDVKcW9QT2hSeGNCek1YQWszUXlacnhySTV5VFYwdHhaV3VMSTNs?=
 =?utf-8?B?cmxXanlxMjQ4aThvZ1NlSFY2UnFKOThBKzIyRjZ5TEVXcGhialh4dVR2bHhl?=
 =?utf-8?B?K3lySll0aTJ6N1FZL3BEcDE4eUF3ME00MkF1eEhBWVJBSmxEbTRBTnhobUlC?=
 =?utf-8?B?M2lqVUFOc3R0YWFFR3NCMTRtbGkyNFYxa2NwNWFOZlI1bzRFekNzVE5EbEJ0?=
 =?utf-8?B?NGhCeDljemZOdCs4WXpiSTh5dVVkYTJtMkpQNEtQQ3JhdGZHWlpxb3loUkF4?=
 =?utf-8?B?blRVV1pQcTJEYkVCY0lBOE0rYUQ1RVZXTlhrTUhHMGt4OFRLUmhreW1nZklm?=
 =?utf-8?B?a0JtMlVzR0pwZ3JESHNXQWM0MHF6VllrVGdxcW5vVUZFMWtwa1Noc3Rnc2Yx?=
 =?utf-8?B?dVo1UjlOWit3OVlEeVVkdHBoUkJwTHA0ZjIvbzRCbmRpZXpXVzA5UjU2R2FI?=
 =?utf-8?B?S1Jzd3hXWjRZVjFHRUhLanNRWkIxTWVVam12dUdYNm5YaTN4YUxSZ1ovTi9y?=
 =?utf-8?B?bmhkcUpmQWpGb21mRy85Wk91djNpZmppZkdnTnArdkxQWnNiOXpJRVc1NlEw?=
 =?utf-8?B?TUVtK1IySXpJcWNXY1IxVWJnSFVpaHhyS2FOVVFUb01rRlZDT1YxVFpxalFo?=
 =?utf-8?B?eTkxcEJ5b1ZJZjBaUU5KUE01Tkg2ZWlITk16M21DK1M4MHJaeWdlZk9MY2Za?=
 =?utf-8?B?VzZyNCtwZkkwdkQ0UGFjR0dXNTdFWmZQL2dWUWJ6SmNVSndXOGwxSkVlU2RT?=
 =?utf-8?B?cW9XS1E5VkpldUJyRS9jWmpldXR5bnRhaTRnZFVoeFpjTitlMVUza1h0YlJO?=
 =?utf-8?B?d2Q1UTVHRHRnVWpGTllwbmdJRFUzczd5OGJiYkdNNytzSGFSaXFWZVFlVzZT?=
 =?utf-8?B?cklpbXBqVWhZcFI3RVRCUFAwZ1JNSWNsS0JSQ0dsckpzUEJ5K0lJYlpZSmZ2?=
 =?utf-8?B?QUV1ZzZkaU52WmdyM3JzY202L1hBVEV4bTUrcDFQUFE2M01HU0dOMjM2ZFl6?=
 =?utf-8?B?SHJCZFA0cWV4TTBpSUtNRmRFcEI4KzEvQ2p2UGoyOW52OExEVlFTaURPMHRV?=
 =?utf-8?B?M251NlozWmw4VTgyL05ZeXExVTFWNHNpTzNxWDhyM2RhZTFsQ0tSVFdXcytJ?=
 =?utf-8?B?RmdwejhKbGNsZk1nWFEyRTRYcU5ZR2w1RGFmcGRPekxFRzZ3NmhiY0trSzRy?=
 =?utf-8?B?SUUzSGg5bmlzOEhGdHFaZWRBRjhHY21qOCtPMGw2ZkJVOElPNVV1OVJhaHNE?=
 =?utf-8?B?V0Z4cFJSYi9ZV2tkOGVtaFV3WjlPa2FzMlY5M1RDUDZLb3RtZWgvWFRBWXBm?=
 =?utf-8?B?UE94Q3BhcHdWUEtBMzRDa24rVlQ2elBhY09oaEJweWRpQ3d1K1hnaFNrZHdB?=
 =?utf-8?B?Q2VuQURaSUowUG00TWMzSWdtcUdXTUt1VndMQzk5cC9nbHBlQXRHdmE3OUwv?=
 =?utf-8?B?OEVzb1h1TWtmQ2JsYWxGbHdXTGRuMFNGVlpadDZFLzNMWTlYT1hQREEzSXJ1?=
 =?utf-8?B?WnBzUml2QzNOVWpicklmcVBZT25Ma0xCbWVmSHA0QmV4UUU1UUJlcXREWGRt?=
 =?utf-8?B?Y215eEVCSlVXNHVjVDIwTXFoTkxZUFk2UzRNdWh5SEErZExhSS9OQUMvQi9K?=
 =?utf-8?B?SUVwSWF5TGp4d3NuWmxpT2p6cFh4dmE4eVdXMnF1S1Q5ZXBQUXZTcWdXSnEv?=
 =?utf-8?B?cXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 56036917-8791-4708-71bc-08db5bb812b2
X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3229.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 18:03:55.4715
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3Sx4dlGIHM/CXLPHWkO16WSsbk6VzbfJ3cBuVv8N+x6te2OoVvtrduOL2YK81GcMabODm5AV6E4fAj3RBWeILpU+z0MuXuqMj84iWrsWV2A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB5892
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 5/22/2023 1:16 PM, Grant Grundler wrote:
> On Thu, May 18, 2023 at 3:36 AM Pavan Chebbi <pavan.chebbi@broadcom.com> wrote:
>>
>> On Thu, May 18, 2023 at 12:58 PM Ying Hsu <yinghsu@chromium.org> wrote:
>>>
>>> diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
>>> index 58872a4c2540..a8b217368ca1 100644
>>> --- a/drivers/net/ethernet/intel/igb/igb_main.c
>>> +++ b/drivers/net/ethernet/intel/igb/igb_main.c
>>> @@ -9581,6 +9581,11 @@ static pci_ers_result_t igb_io_error_detected(struct pci_dev *pdev,
>>>          struct net_device *netdev = pci_get_drvdata(pdev);
>>>          struct igb_adapter *adapter = netdev_priv(netdev);
>>>
>>> +       if (state == pci_channel_io_normal) {
>>> +               dev_warn(&pdev->dev, "Non-correctable non-fatal error reported.\n");
>>> +               return PCI_ERS_RESULT_CAN_RECOVER;
>>> +       }
>>> +
>>
>> This code may be good to have. But not sure if this should be the fix
>> for igb_down() synchronization.
> 
> I have the same opinion. This appears to solve the problem - but I
> don't know if there is a better way to solve this problem.
> 
>> Intel guys may comment.
> 
> Ping? Can we please get feedback from IGB/IGC maintainers this week?
> 
> (I hope igc maintainers can confirm this isn't an issue for igc.)

Adding some of the igb and igc developers.

> cheers,
> grant
> 
>>
>>>          netif_device_detach(netdev);
>>>
>>>          if (state == pci_channel_io_perm_failure)
>>> --
>>> 2.40.1.606.ga4b1b128d6-goog
>>>
>>>