Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 23 May 2023 19:27:38 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Claudiu Beznea <claudiu.beznea@microchip.com>
Cc:     robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        conor.dooley@microchip.com, nicolas.ferre@microchip.com,
        alexandre.belloni@bootlin.com, sre@kernel.org,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 2/4] dt-bindings: power: reset: atmel,at91sam9260-shdwc:
 convert to yaml
Message-ID: <20230523-depletion-petty-978775d05b22@spud>
References: <20230523061512.195271-1-claudiu.beznea@microchip.com>
 <20230523061512.195271-3-claudiu.beznea@microchip.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="4QfNIu1KVbjjpExj"
Content-Disposition: inline
In-Reply-To: <20230523061512.195271-3-claudiu.beznea@microchip.com>
Precedence: bulk


--4QfNIu1KVbjjpExj
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hey Claudiu,

On Tue, May 23, 2023 at 09:15:10AM +0300, Claudiu Beznea wrote:
> Convert Atmel shutdown controller to YAML.
>=20
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>

> diff --git a/Documentation/devicetree/bindings/power/reset/atmel,at91sam9=
260-shdwc.yaml b/Documentation/devicetree/bindings/power/reset/atmel,at91sa=
m9260-shdwc.yaml
> new file mode 100644
> index 000000000000..3b3162677db3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/reset/atmel,at91sam9260-shd=
wc.yaml
> @@ -0,0 +1,81 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)

I think you'll need an explict Ack from Rob as the text binding has no
licence text.

> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/reset/atmel,at91sam9260-shdwc.y=
aml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Atmel SHDWC Shutdown Controller
> +
> +maintainers:
> +  - Claudiu Beznea <claudiu.beznea@microchip.com>
> +
> +description: |
> +  Atmel SHDWC shutdown controller controls the power supplies VDDIO and =
VDDCORE
> +  and the wake-up detection on debounced input lines.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - atmel,at91sam9260-shdwc
> +      - atmel,at91sam9rl-shdwc
> +      - atmel,at91sam9x5-shdwc

For my own curiosity, is this x a wildcard or part of the product name?
Quick google was slightly confusing.

> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  atmel,wakeup-mode:
> +    description: operation mode of the wakeup mode
> +    $ref: /schemas/types.yaml#/definitions/string
> +    enum: [ none, high, low, any ]
> +
> +  atmel,wakeup-counter:
> +    description: counter on wake-up 0
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum: [ 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15 ]

This can just be
minimum: 0
maximum: 15
I think.

Otherwise, looks good to me.

Thanks,
Conor.

--4QfNIu1KVbjjpExj
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZG0FmgAKCRB4tDGHoIJi
0inzAQCWkwG07Dt5F/OF9pU6MN9adj6hqLi8AuPEL69yois7BgEAgUyZ4xlAfRoK
YwYAEd3JvLpw9MU9HQPwhBmOSGXHRgw=
=+W2q
-----END PGP SIGNATURE-----

--4QfNIu1KVbjjpExj--