Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <692650e7-c006-4f89-3b11-dd2f193f510c@intel.com>
Date:   Tue, 23 May 2023 11:19:00 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH][next] iavf: Replace one-element array with flexible-array
 member
Content-Language: en-US
To:     "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, <keescook@chromium.org>
CC:     <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-hardening@vger.kernel.org>,
        "Keller, Jacob E" <jacob.e.keller@intel.com>
References: <ZGLR3H1OTgJfOdFP@work>
From:   Tony Nguyen <anthony.l.nguyen@intel.com>
In-Reply-To: <ZGLR3H1OTgJfOdFP@work>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WlNjYWFIMWg1MEgxYVdZNU5xT3RZZDJqLzE2dTZlVVRYazZtQngyVUtRR1lO?=
 =?utf-8?B?M1JxT3hRTXNncmE2d1E4MzY3aHdrUE9MR1JyQ3p6aHZqSTlSamRhWkJMNVR2?=
 =?utf-8?B?OTc4ZDRPYU1Fc1pGeGNQclhNY0huSmxSZVZURjNZRCtQM2VienVzZTVvTkdL?=
 =?utf-8?B?bTFqb1JKOG9RMkRBZ1BqSlAzSTk5ZFNpd2pMSDNObXByQ0phMzFSYkswSXFQ?=
 =?utf-8?B?Tnd2Vjk0M210NVhBWWxySVNucXZDZ2t0UzYyZGJFUW9DNk8wcTVWd0tVWU8w?=
 =?utf-8?B?eWpYT1NjbmYvMHRIZ3dPU3ZXaUw5TmFFOFZPcCtKMjNVWHV6MFo3YXFtSFJK?=
 =?utf-8?B?NkIrR0ZwbUlVVTJWeDZWUzEwZDg2Tm4wVDJqcnVSbTVPanA4NEdKQWVnekFM?=
 =?utf-8?B?MEU4RGt5WHZxRmxjb2J0amQ4UDFPdVRuZWtiQlhSVkkrZURESGJjNDRQMVht?=
 =?utf-8?B?dXF4a215Uzh6aFhuTWtiZ1lnVDQwMWJ5aHJtaHNCWTN2SnBHeXpTZUpYVGR2?=
 =?utf-8?B?amcrUFh5RzRzSlMwMVVpNGxyYTBONEJYMG16YlR6TnN6clNyVkxRdkNkQkNw?=
 =?utf-8?B?YmRubUJWNTBlTEtLZ0pVQWhxUTMrcW0xYWJLdWRWTVRzYnFLR0hRUldLWlZl?=
 =?utf-8?B?bTJTVmUwS1ZoR0xvTXB4K1YzeitSSWpPWXVtaGFlb00rWnpIYXVQTDRTYlgy?=
 =?utf-8?B?bW1MZjBFalQyT2t2VSs0N1JSOG1yS1VDRFJYWmFCNHYxejZzeW44OUFYaHpE?=
 =?utf-8?B?MnVKbVBkTEtvUUkrZmVZRlNPMjdxVzBRNnVTcHhmMy9WQVBodFpTY1BnSmpN?=
 =?utf-8?B?ekcyWnJzYXFId0lyUHZPOHZsb3BPRjc0andWZU1kNEpjUHdBcTNxNWFFa2o2?=
 =?utf-8?B?VEVaVjVNYngxZ3BNS25KY2RCdUdCMytlUGtKMEROMmFiNU9GVGhHeFhFNy8v?=
 =?utf-8?B?d3JtU2ZPdDBLVUZtMHRJSkpWRXNaU2ZCbkJpdkxsa3JJdHc4SC9iUWdyYm9Y?=
 =?utf-8?B?K3I0S2h2OCs4UGNIa0F3cysweHVYdkNiV0gySEFIRWVUYk1mSDIzZlpoNkFp?=
 =?utf-8?B?Z3JWL0syeE50RHIvcGtGcXBYSU1UaGI3Z3diSTcrdUYvcHliYWVXclhWYytW?=
 =?utf-8?B?UXpvZ1d0S1dIYTRySEtRRHVzbTRzczJnTDlVSFZzdG9WT2dwQ2hrMm1XNTBh?=
 =?utf-8?B?R0ptSUVUd28wQW1zZ0REWlA5d1BvY2hzb0s3dFFralVxVXpUSDFmTWxmRWl5?=
 =?utf-8?B?RnpLKytVcmFhVXA0ZTQ5eU15cy9BZmlEajVna2FvNGFtZlpOR0ZDa3pKdXRS?=
 =?utf-8?B?ZTkwdmN3SXA5YngwN2toNFhWeStzaFRkeUg1Q0RoYWhjUjFHT2picCtOSkJQ?=
 =?utf-8?B?MkRSSWUyN0F6bDlpU1paSzlOVXFLVmY3RmZnSno3bzJkZ1VhYjViMWIzY3pw?=
 =?utf-8?B?eU5uQ25qdHpkK2NzWW5WU29qcE9oUWR2LzhvMFh4YWhXZzlkcDJnQnNtbXZ6?=
 =?utf-8?B?SW92Z29aa0NoWlRqd0cvb2VZQlVDaEJXL2dxeExRdzJVR3diVUcyVSs0TE1Z?=
 =?utf-8?B?RERSWCtISkRFZ0FRTlFQQVVlMktHMDkvTUlFelJ2THpORG1MdDdEWDAwRk0r?=
 =?utf-8?B?c2krRVF3NjFzTTJ3bGVBSE1uTnBWQ05uejdKYXBSZmxONkpMV2JGYXVSdXRj?=
 =?utf-8?B?NU12dFVWWE9QbWNMRW5Ud2pEbjVaRmNYc3BFRTJsaXUycFBuZ3VYTjVBQlZO?=
 =?utf-8?B?MDJDd0JSdGV1MnRFZTZQci8xVU9LdENhME1YV21QWlZSNUhaRDVyTm5SUWc1?=
 =?utf-8?B?MEhaLzd2a3hMbjNHekhFM05Hb3c4NHgzcjhFUW80T0lJMUcya3VSVmNKczJ1?=
 =?utf-8?B?MmFJZkl5SzBXRk91Wi8yMDlKS1RQWnArS3RhVGt5VzZTcW95STMycHpQY05Z?=
 =?utf-8?B?Q25FRXFtMHlLOEhKcHFlK3J4eTZNM3RlNWpZUWhCSXFQQk9ZWjVHb3UwSm5q?=
 =?utf-8?B?cFRvZDZJMnFSSWp1bThRZDBNcW5JSGs4QitLSTRRUmNtZ2FldG80M2pYcUR6?=
 =?utf-8?B?bnZoT1FpdEQvdnJIcGpRaFBQQlN5SHZoRkx0YmRRL2ovcjZ4clZ1dXIzUWZM?=
 =?utf-8?B?eXJQQWZ5NEM1OG14R0p2SkswMEVvNEltYXQreG5RUjVVUkxXdEhqbHhmQjhN?=
 =?utf-8?B?R0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fccd2d6e-e2c8-4525-1449-08db5bba305e
X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3229.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 18:19:03.8349
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KQ2hKXLZSLlCLKlD/urhnh4KJWisfzDIXonyNRMA25TJ2GUx5/DEhmQpAvPxvuk4AB5olFfSEi9fMlPNVziRLlIFBtkdM84HDfG3wpi6NUQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6991
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 5/15/2023 5:44 PM, Gustavo A. R. Silva wrote:
> One-element arrays are deprecated, and we are replacing them with flexible
> array members instead. So, replace one-element array with flexible-array
> member in struct iavf_qvlist_info, and refactor the rest of the code,
> accordingly.
> 
> This helps with the ongoing efforts to tighten the FORTIFY_SOURCE
> routines on memcpy() and help us make progress towards globally
> enabling -fstrict-flex-arrays=3 [1].
> 
> Link: https://github.com/KSPP/linux/issues/79
> Link: https://github.com/KSPP/linux/issues/289
> Link: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/602902.html [1]
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
>   drivers/net/ethernet/intel/iavf/iavf_client.c | 2 +-
>   drivers/net/ethernet/intel/iavf/iavf_client.h | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_client.c b/drivers/net/ethernet/intel/iavf/iavf_client.c
> index 93c903c02c64..782384b3aa38 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_client.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_client.c
> @@ -470,7 +470,7 @@ static int iavf_client_setup_qvlist(struct iavf_info *ldev,
>   
>   	v_qvlist_info = (struct virtchnl_rdma_qvlist_info *)qvlist_info;
>   	msg_size = struct_size(v_qvlist_info, qv_info,
> -			       v_qvlist_info->num_vectors - 1);
> +			       v_qvlist_info->num_vectors);

The problem is this mirrors the virtchnl struct 
(virtchnl_rdma_qvlist_info) so that structure needs to change as well... 
However, this goes back to the interface that virtchnl provides between 
PF and VF [1].

I think removing the iavf structure and directly using the virtchnl one 
would make sense. We'd need to adjust virtchnl and follow Kees' 
suggestion [2].

>   	adapter->client_pending |= BIT(VIRTCHNL_OP_CONFIG_RDMA_IRQ_MAP);
>   	err = iavf_aq_send_msg_to_pf(&adapter->hw,
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_client.h b/drivers/net/ethernet/intel/iavf/iavf_client.h
> index c5d51d7dc7cc..500269bc0f5b 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_client.h
> +++ b/drivers/net/ethernet/intel/iavf/iavf_client.h
> @@ -53,7 +53,7 @@ struct iavf_qv_info {
>   
>   struct iavf_qvlist_info {
>   	u32 num_vectors;
> -	struct iavf_qv_info qv_info[1];
> +	struct iavf_qv_info qv_info[];
>   };
>   
>   #define IAVF_CLIENT_MSIX_ALL 0xFFFFFFFF

[1] 
https://lore.kernel.org/intel-wired-lan/f3674339c0390ced22b365101f2d3e3a2bf26845.camel@intel.com/
[2] https://lore.kernel.org/intel-wired-lan/202106091424.37E833794@keescook/