Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 23 May 2023 11:43:13 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Davidlohr Bueso <dave@stgolabs.net>, <dan.j.williams@intel.com>
CC:     <dave.jiang@intel.com>, <alison.schofield@intel.com>,
        <vishal.l.verma@intel.com>, <ira.weiny@intel.com>,
        <Jonathan.Cameron@huawei.com>, <fan.ni@samsung.com>,
        <a.manzanares@samsung.com>, <dave@stgolabs.net>,
        <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 3/4] cxl/pci: Introduce cxl_request_irq()
Message-ID: <646d0941a2a48_afb77294c@dwillia2-xfh.jf.intel.com.notmuch>
References: <20230523170927.20685-1-dave@stgolabs.net>
 <20230523170927.20685-4-dave@stgolabs.net>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230523170927.20685-4-dave@stgolabs.net>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aS4xBno2VzoYio3dP+n4P0M3JkTtJ+nDHX8tjpujrG8Y8NVuy7xTlZDtNNxK?=
 =?us-ascii?Q?gGLHMctS/YWrDTw+70gV3zHJpXnHMuDBKoe7jsiBpBRMZwkQcSfPDnUihX//?=
 =?us-ascii?Q?Zng9uMScNG2bqfDxj/4uEZ3P7JI+Ocqi8GamamLo9DKfPeRE5I81/eSOLsF5?=
 =?us-ascii?Q?MOSK7FkCzHrLt11VLTPWMdnQSmJfE/JF8+5QGpulc/8pYMu/AtCjfL/hWcOi?=
 =?us-ascii?Q?3o+sAhnwRzn+cRe5KkyiPBN8Ot/drkSi/oVruoJGhN74krD8vPZz0RIpqvQJ?=
 =?us-ascii?Q?yRVNrxsFncZf0U5MTLImpLhv3LWY7SSF6CbAqRicmL+xyP5laO+0X4TpmdgB?=
 =?us-ascii?Q?ZCVCWYllIT96Y4vORPxn1wUipOotXPgW99o735Ap+3LNrA1jNd/t3vVDjBVW?=
 =?us-ascii?Q?oNYsNV81uj9NH8NAXmQDBic6KzSrzR6rHWnFLOy0Xb6Nt3OrYyfkRtNmOxCP?=
 =?us-ascii?Q?Pe7bMNpaVShbpwnaMvui5SBrlgoCl/Y3JRPVY6ZZmZ9z4RYT8qKYB74TEXWd?=
 =?us-ascii?Q?wohJQcZ01F0DQbNXV3xLrWMcLuG9jfqQDWecMRZYUhKwgfMkTsfCQXc9jTSS?=
 =?us-ascii?Q?vBwDr5ruwiJaezr9xwVzp+O6A1djY76F7FdSRnOBk9w9oXu6ak38fLfJpn3o?=
 =?us-ascii?Q?K8bksXKV5Pqnq1JBvA7p9JXztSTGAzKl5jK59ci5zerQa5J+mFiy58topWex?=
 =?us-ascii?Q?cDjvTjW4oL4c5Qmx13Jq7sGpcJMZOug2CV6f1ec83iuBic6QcE+HK+BncyEh?=
 =?us-ascii?Q?InYUOP+y5CcgrWioyAsbPGnAruCIv5JYR3AKAPW1gu7o93jo3FiDUne85/m0?=
 =?us-ascii?Q?vYZ5m2JBwqGSsn3gYJRc4we07FntI4Ckz4LZSJpj/KMRP6fHFOgR185cYyG2?=
 =?us-ascii?Q?OdLpdAv0D2yswcrgi3zbDfsc7fLiSUzSzCQljbLNxDc7pJPeupSr/OB6jL6c?=
 =?us-ascii?Q?IMk+f10K02L/dSPdoGwixTps55N5L9jU/HvsqHqlYGnQQspmWyoEopHSiL6z?=
 =?us-ascii?Q?0emIJ2UGCFQntT9zjb845kcPvS/7snHnnHFVDaX2NMtNf6MB+xbcnCnpoDuV?=
 =?us-ascii?Q?nuGqP5URWeR4zcIJ+3c6caF1pxJUKI8gd28E6F29Y2rFEQQDQiiKh5Zi9twP?=
 =?us-ascii?Q?AiDGnXVjkcoKlYUKkN26nfwIZG0pObILmMKXQiwgBmQaklYWA1Xgrx2j3Wf7?=
 =?us-ascii?Q?ReCrzn90WnpFHytZBUhp5BJhsP+hG0GFbcJ60h+Sop6q/pu2DPA98RngP2Qg?=
 =?us-ascii?Q?d5zvf582lcZSxToAb89a/ABtEV4u2+Utj8uPtWN7tYYU3NxPsRRe/PdfgO7V?=
 =?us-ascii?Q?oTLLyAAMuGV1bSEGmlbhCShAJhcuR3axt/xEoXQAaxqycvs4OqgCLg+ewvpY?=
 =?us-ascii?Q?Hhwk4HzBsDHS7aRV6TqfxAvkqintaZh4lOLvH30JtuwWVYQdEyBBqeibPSOD?=
 =?us-ascii?Q?7QKRIgfHJajYUPrYXBbQp+Ps5gXOHE4tT20n0moPnq5fxBSAcb0Nio1R0v55?=
 =?us-ascii?Q?P1KKONXcBx9bP/TMR3D3w0KdeVtOx/P39KUFvLiNCIuuUN5JO/DY8zj12IZv?=
 =?us-ascii?Q?18sAebuCoxEMs2PdIo+KvTaEzXdYU9fUa51GV+ZRKPHGCsnHOevMioXOdPVs?=
 =?us-ascii?Q?FA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 29e0135e-58a8-4467-cfb0-08db5bbd91f1
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 18:43:16.2137
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mXWfZ2wG3ra0LLUUzUAGkZEeTEkQhNStLVSon2QGJLldhexgDSQwbYdaw9Ht2q2ibrJdRZlq8R6d6WmtuuzzMFCB/Gqu00blUBr8ex6DY60=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7500
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Davidlohr Bueso wrote:
> Factor out common functionality/semantics for cxl shared interrupts
> into a new helper on top of devm_request_irq().
> 
> Suggested-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
> ---
>  drivers/cxl/pci.c | 39 +++++++++++++++++++++++----------------
>  1 file changed, 23 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/cxl/pci.c b/drivers/cxl/pci.c
> index f2039fe0805d..18b8f3ce680c 100644
> --- a/drivers/cxl/pci.c
> +++ b/drivers/cxl/pci.c
> @@ -84,6 +84,27 @@ static int cxl_pci_mbox_wait_for_doorbell(struct cxl_dev_state *cxlds)
>  			    status & CXLMDEV_DEV_FATAL ? " fatal" : "",        \
>  			    status & CXLMDEV_FW_HALT ? " firmware-halt" : "")
>  
> +struct cxl_dev_id {
> +	struct cxl_dev_state *cxlds;
> +};
> +
> +static int cxl_request_irq(struct cxl_dev_state *cxlds, int irq,
> +			   irq_handler_t handler, irq_handler_t thread_fn)
> +{
> +	struct device *dev = cxlds->dev;
> +	struct cxl_dev_id *dev_id;
> +
> +	/* dev_id must be globally unique and must contain the cxlds */
> +	dev_id = devm_kzalloc(dev, sizeof(*dev_id), GFP_KERNEL);
> +	if (!dev_id)
> +		return -ENOMEM;
> +	dev_id->cxlds = cxlds;
> +
> +	return devm_request_threaded_irq(dev, irq, handler, thread_fn,
> +					 IRQF_SHARED | IRQF_ONESHOT,
> +					 NULL, dev_id);

I was going to say drop the IRQF_ONESHOT in the case where @thread_fn is
NULL, but I could not convince myself that was safe. I assume that
pci_request_irq() gets away with that because most drivers are not
mixing combinations of @handler and @thread_fn being set to NULL.

So, with that, this looks good to me.