Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e547edf4-1b48-5d12-1600-45f78e7cab49@quicinc.com>
Date:   Tue, 23 May 2023 12:53:19 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [Freedreno] [PATCH] Revert "drm/msm/dp: Remove INIT_SETUP delay"
Content-Language: en-US
To:     Abhinav Kumar <quic_abhinavk@quicinc.com>,
        Leonard Lausen <leonard@lausen.nl>,
        Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        "Bjorn Andersson" <andersson@kernel.org>
CC:     <freedreno@lists.freedesktop.org>,
        Sankeerth Billakanti <quic_sbillaka@quicinc.com>,
        Bjorn Andersson <quic_bjorande@quicinc.com>,
        <regressions@lists.linux.dev>, David Airlie <airlied@gmail.com>,
        "Nikita Travkin" <nikita@trvn.ru>, <linux-kernel@vger.kernel.org>,
        <dri-devel@lists.freedesktop.org>, Rob Clark <robdclark@gmail.com>,
        "Daniel Vetter" <daniel@ffwll.ch>, <linux-arm-msm@vger.kernel.org>,
        Stephen Boyd <swboyd@chromium.org>,
        Sean Paul <sean@poorly.run>,
        Johan Hovold <johan+linaro@kernel.org>
References: <1345a125-f745-4fe3-0f5e-bfe84225958d@quicinc.com>
 <b0cc40d5-6de1-91cc-e2cd-f47cc53551e4@quicinc.com>
 <ebbcd56ac883d3c3d3024d368fab63d26e02637a@lausen.nl>
 <20230508021536.txtamifw2vkfncnx@ripper>
 <3802269cd54ce105ef6dece03b1b9af575b4fa06@lausen.nl>
 <ad351c02-1c29-3601-53e8-f8cdeca2ac63@linaro.org>
 <49d175ec16e3f65a18265063e51092ee8d0d79c1@lausen.nl>
 <f2d1bb37-ea83-4d5d-6ef5-ae84c26d6ac1@quicinc.com>
From:   Kuogee Hsieh <quic_khsieh@quicinc.com>
In-Reply-To: <f2d1bb37-ea83-4d5d-6ef5-ae84c26d6ac1@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 5/23/2023 11:56 AM, Abhinav Kumar wrote:
> Hi Leonard
>
> On 5/22/2023 7:39 PM, Leonard Lausen wrote:
>> Abhinav Kumar <quic_abhinavk@quicinc.com> writes:
>>>>>> There is no need to add the 100ms delay back yet.
>>>>>>
>>>>>> thanks for posting this but NAK on this patch till we post the 
>>>>>> fix this
>>>>>> week.
>>>>>>
>>>>>> Appreciate a bit of patience till then.
>>>>>
>>>>> This regression is already part of the 6.3 stable release series. 
>>>>> Will
>>>>> the new patch qualify for inclusion in 6.3.y? Or will it be part 
>>>>> of 6.4
>>>>> and this revert should go into 6.3.y?
>>>>
>>>> This is a tough situation, as landing a revert will break x13s, as 
>>>> noted
>>>> by Bjorn. Given that the workaround is known at this moment, I would
>>>> like to wait for the patch from Abhinav to appear, then we can decide
>>>> which of the fixes should go to the stable kernel.
>>
>> I wasn't able to find new patches, though may have missed them. Is there
>> a decision yet how to proceed with this regression? 6.2 now being EOL
>> may make this a good moment to decide on the next steps.
>>
>
> Yes, the new patch to fix this issue is here
>
> https://patchwork.freedesktop.org/patch/538601/?series=118148&rev=3
>
> Apologies if you were not CCed on this, if a next version is CCed, 
> will ask kuogee to cc you.
>
> Meanwhile, will be great if you can verify if it works for you and 
> provide Tested-by tags.

Hi Leonard,

I had  cc you with v5 patches.

Would you please verify it.

Thanks,

>
>>>>> [  275.025497] [drm:dpu_encoder_phys_vid_wait_for_commit_done:488]
>>>>> [dpu error]vblank timeout
>>>>> [  275.025514] [drm:dpu_kms_wait_for_commit_done:510] [dpu error]wait
>>>>> for commit done returned -110
>>>>> [  275.064141] [drm:dpu_encoder_frame_done_timeout:2382] [dpu
>>>>> error]enc33 frame done timeout
>>>
>>> This is a different crash but the root-cause of both the issues is the
>>> bridge hpd_enable/disable series.
>>>
>>> https://patchwork.freedesktop.org/patch/514414/
>>>
>>> This is breaking the sequence and logic of internal hpd as per my
>>> discussion with kuogee.
>>>
>>> We are analyzing the issue and the fix internally first and once we
>>> figure out all the details will post it.
>>
>> Thank you!