Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 23 May 2023 22:58:31 +0200
From:   luca abeni <luca.abeni@santannapisa.it>
To:     Vineeth Remanan Pillai <vineeth@bitbyteword.org>
Cc:     Juri Lelli <juri.lelli@redhat.com>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Joel Fernandes <joel@joelfernandes.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        Valentin Schneider <vschneid@redhat.com>,
        Jonathan Corbet <corbet@lwn.net>, linux-kernel@vger.kernel.org,
        linux-doc@vger.kernel.org
Subject: Re: [PATCH v3 2/5] sched/deadline: Fix reclaim inaccuracy with SMP
Message-ID: <20230523225831.60d75b38@nowhere>
In-Reply-To: <CAO7JXPgXi8q02HBeBR_RLWmODd9uQBH_UMCYgVQwbf+FX=Qxkg@mail.gmail.com>
References: <20230515025716.316888-1-vineeth@bitbyteword.org>
        <20230515025716.316888-3-vineeth@bitbyteword.org>
        <20230515100616.33ba5dd9@luca64>
        <CAO7JXPgq8V5yHM6F2+iXf4XJ9cyT30Hn4ot5b2k7srjsaPc3JQ@mail.gmail.com>
        <20230516093729.0771938c@luca64>
        <CAO7JXPh5uLV4QjAEi6bJXfAGSsZ=XsnCyzrvKS8m35BGbRPYJw@mail.gmail.com>
        <20230519115621.2b3f75e2@luca64>
        <20230519121804.6c85a3ed@luca64>
        <CAO7JXPhZPvzVRyL87qNT5VnaVOf=0wrRftFB-Rjx-vJc3JUMog@mail.gmail.com>
        <20230520115857.3838a7ea@nowhere>
        <CAO7JXPgXi8q02HBeBR_RLWmODd9uQBH_UMCYgVQwbf+FX=Qxkg@mail.gmail.com>
Organization: Scuola Superiore Sant'Anna
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zyy3bcy35sxZFg8aCkaLfjtCJMv3fS9CarmrcDgp477pH6smz9ABng872qMz?=
 =?us-ascii?Q?vKEENCmEUZtIUQmf1IdcpYGtX3jcarZBNEkupJD5uepBMUO5YevoOGR2njrR?=
 =?us-ascii?Q?dAbIwFUu4sQk/TBCWq6aih5CAiJjXfe9AjqqHUC23RZlzX2hhAOhR4Bft/tk?=
 =?us-ascii?Q?dT4UO3AkR7fTwfXJrWrE30ASM9/DpPdtWDmoLsFk8gQszAZsv96hBtU1TLwq?=
 =?us-ascii?Q?WRU8VCGyNBn9eTl/RFS1ztM9kCO0AG7TfGWGR4LfB1sjbGzuROEP6mb8XY4T?=
 =?us-ascii?Q?42mzF6IlIp3I/xLkynvsUUY2uwOjw1QgypxSfW0bp8A53zrJbWzb1H3Hn1HZ?=
 =?us-ascii?Q?pIEZXr6tSFUWXvlGnFCE4UtRPOdRBERTf1a/lhkcpDiYkRm6o8w9zHDAqw9n?=
 =?us-ascii?Q?FCfbHSJe5EvEnHuoi0TwBkpUjhjXJ/tby8UiTXPPggxHbnCRhrWVfzjKkci6?=
 =?us-ascii?Q?R1cbe42ECI7XO9tC7b4D8DFNBQmiXhj2aJbw8HEEprXgRSs+kjuhlHDg1jBa?=
 =?us-ascii?Q?WGvV1fpOrgQilyCKbdhU84UPpxk6RTnTMF1GOw12MMjON6wz6j+BeIqtjIsH?=
 =?us-ascii?Q?MqDs4+IFSpguB9xnYMH3j41EzuHnJHuL5lXQa3SQ7P9fDAUj2Xgx7ttIGRwG?=
 =?us-ascii?Q?30emXeM/QgUj3wmqkktRuPnd7kbjhCS3HZBxDouE7JmloyhoJJrjNXw+BShp?=
 =?us-ascii?Q?zjnq3fGc9ex7QQZeMFeFKegQUGrbALjLan1bnLWzbdDdELUH14L++l4p5N59?=
 =?us-ascii?Q?UnaLcdSq0nZrPdkBd1C604QVQ47vHJMVKqMnkyp9O8gnbi1wkcJ4fWay45wt?=
 =?us-ascii?Q?J5LeTXHYrzafcBt07qE8azHdEBXHpPaJh3d7qstSF2Ra16SJN1OPDyYsysJ+?=
 =?us-ascii?Q?lLRqF4Q/v/Vk7PrKzXUWZJfESlo3McTWcN8Esgz/Naau2MOrSzpxGGJqS0Iz?=
 =?us-ascii?Q?Y0uyuu1qTEIpq6GgdXu+E2Bc8ET35vhD0DiyvK4lXRtPNCjfQUuNqqDm/5Gx?=
 =?us-ascii?Q?+5MyuDa7ZNSKX/MDjGe3sjAIOxlfKWtXUVk8DJ6uUeW+8Qg4SrtUrCXpYO8H?=
 =?us-ascii?Q?zai4odxI0DAhgvh1+jVnevTzhNZ6vL80+L4S1ZTJyeBFVR3qyHZOSdosjXTV?=
 =?us-ascii?Q?3+W8BLBgzNHPREDR2DM/cUa3vro8AYFcm/Rbhx4cpAWTnOaln/Y5p/q6++/3?=
 =?us-ascii?Q?2zjS9kzff4lFzLvjg/aEd0jSd396Ge37l1GZKOKJmF7hIaxjDWa4/wMmlIio?=
 =?us-ascii?Q?txBjqPQkrJ73RnLqwiBh9fpPi4+LipKQQWyI5lCOHtWyNgAsiRoY4TmbOkDv?=
 =?us-ascii?Q?aEjSeYXAjXIcSf8zteJhuQ57zYGbXhPPHw89mv7JWOygVkLetfCusu6jdgQR?=
 =?us-ascii?Q?MHH55a5MVrYk+byVuiOMkipL8zaLY4QZay4lNsafrk8MIJ0fF+ayEwCOR2vq?=
 =?us-ascii?Q?KM4uLL2cMGioJbDjQil8pOIOYuEx/kg3huiUB2DYVpsEh40egic6j5m2FrHe?=
 =?us-ascii?Q?KTSMAYfU8nS3o8PM3HO3ADfyfZd4jWqggqb6f8lYdAtE6n8qbAfl79bxYXO2?=
 =?us-ascii?Q?Kqxs3GoDcjfVelfAYRxTRkKwc3jsbUdoynY3nTEBupb8fsNBxOF9U+27uvuZ?=
 =?us-ascii?Q?JQ=3D=3D?=
X-OriginatorOrg: santannapisa.it
X-MS-Exchange-CrossTenant-Network-Message-Id: 6ae20bbe-c52c-45ce-afd1-08db5bd07926
X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB2880.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 20:58:34.8093
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: d97360e3-138d-4b5f-956f-a646c364a01e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: a+z/Oy2SI2DoLaW4/wa7xA6niXK/lAlZ84fYQCOnJS/pg1Q+bMw28oS27pSfkxRy+cmabIKQ2rf5JyRjLyS6b+NDsENYy2ytjLLUmZJAZxY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR03MB6562
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

sorry for the late reply.

On Mon, 22 May 2023 15:22:52 -0400
Vineeth Remanan Pillai <vineeth@bitbyteword.org> wrote:
[...]
> > But when I use
> >         dq = -(max{u_i, (Umax - Uinact - Uextra)} / Umax) * dt
> > everything works as expected, the 4 tasks reclaim 95% of the CPU
> > time and my shell is still active...
> > (so, I cannot reproduce the starvation issue with this equation)
> >  
> Sorry about this confusion, yes you are right, there is no stall with
> this equation. The only issue is the lesser reclaim when the load is
> less and tasks have different bandwidth requirements.
> 
> > So, I now think the second one is the correct equation to be used.
> >  
> Thanks for confirming.
> 
> I think it probably makes sense to get the fix for the equation to go
> in as a first step and then we can investigate more about the second
> issue (less reclaiming with less load and different bandwidth) and
> fix it separately. What do you think?

I fully agree. If you split this change in a first patch, IMHO it
can be applied.

BTW, I tried changing the equation without introducing div64, and it
seems to me that it works well... So, if removing the bw_ratio
approximation is needed, I think you can do it in a second patch (so,
the first patch changes the reclaiming equation, and the second one
introduces div64)


			Thanks,
				Luca

> I shall send the next iteration
> with the fix for the equation alone if its okay with you.
> 
> Thanks,
> Vineeth