Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
From:   Rob Herring <robh@kernel.org>
To:     Justin Chen <justin.chen@broadcom.com>
Cc:     kuba@kernel.org, hkallweit1@gmail.com, davem@davemloft.net,
        sumit.semwal@linaro.org, netdev@vger.kernel.org,
        linux@armlinux.org.uk, bcm-kernel-feedback-list@broadcom.com,
        christian.koenig@amd.com, opendmb@gmail.com, robh+dt@kernel.org,
        conor@kernel.org, justinpopo6@gmail.com, richardcochran@gmail.com,
        Florian Fainelli <florian.fainelli@broadcom.com>,
        f.fainelli@gmail.com, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
        edumazet@google.com, andrew@lunn.ch, simon.horman@corigine.com,
        devicetree@vger.kernel.org, pabeni@redhat.com
In-Reply-To: <1684878827-40672-3-git-send-email-justin.chen@broadcom.com>
References: <1684878827-40672-1-git-send-email-justin.chen@broadcom.com>
 <1684878827-40672-3-git-send-email-justin.chen@broadcom.com>
Message-Id: <168488029701.2003121.3742030688630968396.robh@kernel.org>
Subject: Re: [PATCH net-next v4 2/6] dt-bindings: net: Brcm ASP 2.0
 Ethernet controller
Date:   Tue, 23 May 2023 17:18:17 -0500
Precedence: bulk


On Tue, 23 May 2023 14:53:43 -0700, Justin Chen wrote:
> From: Florian Fainelli <florian.fainelli@broadcom.com>
> 
> Add a binding document for the Broadcom ASP 2.0 Ethernet
> controller.
> 
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
> Signed-off-by: Justin Chen <justin.chen@broadcom.com>
> ---
> v3
> 	- Adjust compatible string example to reference SoC and HW ver
> 
> v3
>         - Minor formatting issues
>         - Change channel prop to brcm,channel for vendor specific format
>         - Removed redundant v2.0 from compat string
>         - Fix ranges field
> 
> v2
>         - Minor formatting issues
> 
>  .../devicetree/bindings/net/brcm,asp-v2.0.yaml     | 145 +++++++++++++++++++++
>  1 file changed, 145 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/brcm,asp-v2.0.example.dtb: ethernet@9c00000: compatible: ['brcm,bcm72165-asp', 'brcm,asp-v2.0'] is too long
	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/1684878827-40672-3-git-send-email-justin.chen@broadcom.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.