Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Wed, 24 May 2023 04:29:00 +0300
Message-Id: <CSU49W63M584.3VBYBMYWJZ3H5@suppilovahvero>
Cc:     <jsnitsel@redhat.com>, <hdegoede@redhat.com>,
        <oe-lkp@lists.linux.dev>, <lkp@intel.com>,
        <peter.ujfalusi@linux.intel.com>, <peterz@infradead.org>,
        <linux@mniewoehner.de>, <linux-integrity@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <lukas@wunner.de>,
        <p.rosenberger@kunbus.com>
Subject: Re: [PATCH 2/2] tpm, tpm_tis: reuse code in disable_interrupts()
From:   "Jarkko Sakkinen" <jarkko@kernel.org>
To:     "Lino Sanfilippo" <l.sanfilippo@kunbus.com>,
        "Lino Sanfilippo" <LinoSanfilippo@gmx.de>, <peterhuewe@gmx.de>,
        <jgg@ziepe.ca>
References: <20230522143105.8617-1-LinoSanfilippo@gmx.de>
 <20230522143105.8617-2-LinoSanfilippo@gmx.de>
 <CSTW5YGZ50O1.16RYO14HOQRH2@suppilovahvero>
 <f22d2c28-5934-a989-3aea-4ff4d20b6326@kunbus.com>
In-Reply-To: <f22d2c28-5934-a989-3aea-4ff4d20b6326@kunbus.com>
Precedence: bulk

On Tue May 23, 2023 at 11:52 PM EEST, Lino Sanfilippo wrote:
>
>
> On 23.05.23 21:07, Jarkko Sakkinen wrote:
>
> >=20
> > NAK as invidual change w/o further discussion.
> >=20
> > Would need to be seen in context. This does not change kernel for
> > better.
> >=20
> > If you want to wrap, please do it in 1/2 and then we can evaluate
> > whether it makes sense or not.
> >=20
>
> Ok, will do so.

And generally: keep it *minimal* :-) We want to exactly fix the bug,
and take absolutely no other action.

BR, Jarkko