Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Wed, 24 May 2023 05:50:27 +0300
Message-Id: <CSU6091FJLXS.3MMTQQFUENGKB@suppilovahvero>
Cc:     <peterhuewe@gmx.de>, <jgg@ziepe.ca>,
        <linux-integrity@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <l.sanfilippo@kunbus.com>
Subject: Re: [PATCH - for 6.4] tpm: tpm_tis: Disable interrupts for AEON
 UPX-i11
From:   "Jarkko Sakkinen" <jarkko@kernel.org>
To:     =?utf-8?q?P=C3=A9ter_Ujfalusi?= <peter.ujfalusi@linux.intel.com>,
        "Jerry Snitselaar" <jsnitsel@redhat.com>
References: <20230517122931.22385-1-peter.ujfalusi@linux.intel.com>
 <ohdpul6hax5bj5hhsnpt7i3ejbttivufmoolzunbhipexjkczi@meg3zx2yqkc7>
 <CSPMQ03V3G7G.EBWKDRE4B0XY@suppilovahvero>
 <432df3cf-da16-1f2a-02dc-e2c371c1f29c@linux.intel.com>
 <2c94260b-ac97-3f5e-331b-76f1a17ec5b5@linux.intel.com>
In-Reply-To: <2c94260b-ac97-3f5e-331b-76f1a17ec5b5@linux.intel.com>
Precedence: bulk

On Mon May 22, 2023 at 10:40 AM EEST, P=C3=A9ter Ujfalusi wrote:
>
> On 18/05/2023 23:24, P=C3=A9ter Ujfalusi wrote:
> >=20
> > The version is used to differentiate the revisions of the UPX-i11
> > boards, and this issue present in all revisions.
> >=20
> >> I can squash this to the commit I pushed (it is not yet mirrored
> >> to linux-next), if I get the dmidecode info.
> >=20
> > System Information
> >         Manufacturer: AAEON
> >         Product Name: UPX-TGL01
> >         Version: V1.0
> >         Serial Number: Default string
> >         UUID: a300091d-fb1c-ce1c-1d30-0007328efc11
> >         Wake-up Type: Power Switch
> >         SKU Number: Default string
> >         Family: Default string
> >=20
> > I have used this description as it it is used for SOF, probably
> > DMI_MATCH(DMI_PRODUCT_NAME, "UPX-TGL01")
> > should be added?
>
> Jarkko: I have tested that adding the
> DMI_MATCH(DMI_PRODUCT_NAME, "UPX-TGL01")
> works.
>
> I would also do a small update to commit message: "120000 jiffies"  to
> "120000 msec".
> On my setup 120000 msec ends up to be 120000 jiffies.
>
> How do you prefer to handle this?
> I can send a v2 on top of linux-next / mainline
> I can send a fixup patch which can be squashed to the patch you have in
> your master branch atm
> Or you add this line by yourself?
>
> Either way is fine for me, whichever works best for you.

If you want to send a follow-up please do, and I can pick it.

BR, Jarkko