Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <791e1cc9-38e1-eb02-673c-13c1194c7960@intel.com>
Date:   Wed, 24 May 2023 10:55:15 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH v3 14/21] KVM:VMX: Add a synthetic MSR to allow userspace
 to access GUEST_SSP
Content-Language: en-US
To:     Binbin Wu <binbin.wu@linux.intel.com>
CC:     <seanjc@google.com>, <pbonzini@redhat.com>, <kvm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <peterz@infradead.org>,
        <rppt@kernel.org>, <rick.p.edgecombe@intel.com>,
        <john.allen@amd.com>,
        Sean Christopherson <sean.j.christopherson@intel.com>
References: <20230511040857.6094-1-weijiang.yang@intel.com>
 <20230511040857.6094-15-weijiang.yang@intel.com>
 <98bbc70e-7566-36fa-98e2-5bf5a97d682c@linux.intel.com>
From:   "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <98bbc70e-7566-36fa-98e2-5bf5a97d682c@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YlNvVTFJNUt4b1FuTlRFOStEam1QQmM2UTZxS2ZhaFhnSHdPS1lwb0c0SGQ5?=
 =?utf-8?B?WjNKTXpqcFFLTDNJUWhUbjJjWVN6aUJJWGl1OFlMcmlQbzFZKytyZ0NSdW11?=
 =?utf-8?B?ajNGT3cvUFZFUUdiQXprVFg5K2oyNVVmM0V5b2h3RHFpU2lQdEF6NGhyU2lt?=
 =?utf-8?B?L1liZXMzM2pzR2VpY0hnZC9EalpxSGpJbzJvU1k2b3NyQ3o3RjdXampxdkVT?=
 =?utf-8?B?RzF1ZUt6MHpJaWo3UHF3QzcxR0w3RjNEWkJUSHlYSWN4enhhTkdZT2hOUTdK?=
 =?utf-8?B?eUErc1VpdjFLQWJTNjA0QTJadnRZdU1iSmZoejZ0OTM4OURnM25NNy9ueDQ4?=
 =?utf-8?B?QlRsT1hXdlFYWkFjQy80dGZUT1cxUkJERktrMDhteTNxSy9lMFM0N1liam1h?=
 =?utf-8?B?RGNFQmRMSlFPUlBqbjhuMmNWV0FuMzZWdFlRZFFka0ZMMFc4ZVY5RXpoOUx5?=
 =?utf-8?B?Unp2OEFKWG1SdXI2SndFWWxMTHJrSFZaTW0xWDBIN3I4Z3R1bUVIdHZ6NHcr?=
 =?utf-8?B?L0R3V0xocDhmRm5SOHIvdDc0b1pRU1Q4bSttcFdFYXIzVi8wMndDQWFIZ1Va?=
 =?utf-8?B?WERkUnJ6WWROa2dUM3BRTmwvd3o4QXdJMFM4WXhvRDNCcGJEWUNWY04wUGZ4?=
 =?utf-8?B?MVlvZllwNyszRmdxelBDSTV5amJGMXY3eEgwMUNoZEJqeFkxZWlnbDJUUGQz?=
 =?utf-8?B?MjY3a3NtYS9xa29PYVV2bnRhdWx3V2xKMHZNOVlHTzB1b1NCK0dDQ1VNbVNm?=
 =?utf-8?B?ZHFpZS9pajM3UDZDeHExVEVLTnFVeE4yV0Y4dThnTStjUWgxUVlvOGpObG9k?=
 =?utf-8?B?V2lDVWxMbDY5cmlwTDdrd3hYeHBWVHVJQTh3SlNwRnZSRy9IQ3Z6aEtQd1l3?=
 =?utf-8?B?NUx1OGV0c1lBTWZKSXc3US91R1lVbDlaS0RWc1JCNXAxcWZWSStrUlViN1JN?=
 =?utf-8?B?UzFUUk8zayttSmxsWXFyRlA5Uk9OcU9VTHZ3SzRpUTgwK1RPWUdqSnRkdzNN?=
 =?utf-8?B?WjJ2VzN2TitnWEp4NGZaTFFMSE4xbWwrRXg2RjJLamh6V0U5aWViL0FUTW5W?=
 =?utf-8?B?RGJNNDk3UTNPNWtEWDVpakNJNDE1cWdqenU5bHhUanh4UDNUNFY3clF4T0Qy?=
 =?utf-8?B?RWFIbEN0bXBaRWxXTGdSdTZmRXY5eEVhMzFBVmV6YVFVVjlkVG16SlN4Q3Zm?=
 =?utf-8?B?aCtwY2FFYlNjSHU1c0dNV1lPaUh2MmZKcDhhZE9pYUc1UVdDMUFmT1oySUJs?=
 =?utf-8?B?YVBUWEtoT1l4UUYrTnA0dmhQeVpQb0ZmZlY0NzMvaWdZRHIzb1VLMnprQm1x?=
 =?utf-8?B?d0haTUdsV1d3bkxjdUhXbTdmbFU1dDNnTjdJWm5UNWYxSTJYUEVLeXNsNHpN?=
 =?utf-8?B?RzNZb2doUEMxZ1BQL0tYYWFtTWZNdDlmYU1EQ0Z2bGlWWGJWcHY2S0t0K2xn?=
 =?utf-8?B?SUxnWXZtSVgwTVJXZjNPNmRoQ1RwL1YyRlNTb3ZmZkZBNWptcjc0T29lM2pW?=
 =?utf-8?B?YmVZM2hoNkxiL2M1dDdrWS9aNGpzcStQSkZIYkZyMmFjb0cwUDdJQ3BudHpE?=
 =?utf-8?B?U01FdnRWL3Q0TnlHRnVaWExEREpEU3d6NGVtemlOR2Y3TEYyUmNwclFkSWwv?=
 =?utf-8?B?eTBYZ08ya2pFOVpZbGtxVWFBaDRuZG5sV2QwcnByQWFmVXVSNnNuREExNTlF?=
 =?utf-8?B?RGZUbVBvN1pERmZwMVNWaEZVcm1vQzN6WEc4d1BMOHV3Z05jdm9CRzVMZFhl?=
 =?utf-8?B?OXRBTzF5R0RiU2FFYTc3N1RPMCsvU2M5RFhOK0lvQmhrZDdtNDd0VUU5NWxZ?=
 =?utf-8?B?MGIxRU9ZY3RsMjluWWJYQjFQUi95aEhzN0ZlRlFoQm9mcjIwMHFJVG51dVpB?=
 =?utf-8?B?bzZHZWlyWmVNVUdjZlkvR3AzVTdRNDZIN1VtOEpyejNZTDhRNGI2L256bFFE?=
 =?utf-8?B?T0VaWHEwTmYrdkdUekZ2eXNDaFRXWUIzcmtMY2RUazYydWFQSDJFY2wyc0ww?=
 =?utf-8?B?WTZubndiaWJ5TjZ3MUVVL29CNVlUZUNMOW45LzY0cU1USjZqaG4xTmlWV3NL?=
 =?utf-8?B?OEY2Q2ttcVYyKy95cVY3NnoyWWxHNFBLd2JFbU02bDFjKzU2bDVDRUtsUWhq?=
 =?utf-8?B?TFBZaWMxMnBKRzcxS3ovb0xEdkxXQzJBTDRnNDBRNWxCTmlKbFRvMzJUaFQ2?=
 =?utf-8?B?dHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 629ecfb3-3454-4989-4d35-08db5c025397
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2023 02:55:26.9667
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Evoy1D9FTHJO2IQJBsytwEoyWhhM29mbl28qtSevm810KDXO8c2Xl8tQEZB4FVztHvA6CpdHdPPcSkB8YjuhvQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6493
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/23/2023 4:57 PM, Binbin Wu wrote:
>
>
> On 5/11/2023 12:08 PM, Yang Weijiang wrote:
>> Introduce a host-only synthetic MSR, MSR_KVM_GUEST_SSP, so that the VMM
>> can read/write the guest's SSP, e.g. to migrate CET state.  Use a 
>> synthetic
>> MSR, e.g. as opposed to a VCPU_REG_, as GUEST_SSP is subject to the same
>> consistency checks as the PL*_SSP MSRs, i.e. can share code.
>>
>> Co-developed-by: Sean Christopherson <sean.j.christopherson@intel.com>
>> Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
>> Signed-off-by: Yang Weijiang <weijiang.yang@intel.com>
>> ---
>>   arch/x86/include/uapi/asm/kvm_para.h |  1 +
>>   arch/x86/kvm/vmx/vmx.c               | 15 ++++++++++++---
>>   arch/x86/kvm/x86.c                   |  4 ++++
>>   3 files changed, 17 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/x86/include/uapi/asm/kvm_para.h 
>> b/arch/x86/include/uapi/asm/kvm_para.h
>> index 6e64b27b2c1e..7af465e4e0bd 100644
>> --- a/arch/x86/include/uapi/asm/kvm_para.h
>> +++ b/arch/x86/include/uapi/asm/kvm_para.h
>> @@ -58,6 +58,7 @@
>>   #define MSR_KVM_ASYNC_PF_INT    0x4b564d06
>>   #define MSR_KVM_ASYNC_PF_ACK    0x4b564d07
>>   #define MSR_KVM_MIGRATION_CONTROL    0x4b564d08
>> +#define MSR_KVM_GUEST_SSP    0x4b564d09
>>     struct kvm_steal_time {
>>       __u64 steal;
>> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
>> index 0ccaa467d7d3..72149156bbd3 100644
>> --- a/arch/x86/kvm/vmx/vmx.c
>> +++ b/arch/x86/kvm/vmx/vmx.c
>> @@ -2095,9 +2095,13 @@ static int vmx_get_msr(struct kvm_vcpu *vcpu, 
>> struct msr_data *msr_info)
>>           break;
>>       case MSR_IA32_U_CET:
>>       case MSR_IA32_PL3_SSP:
>> +    case MSR_KVM_GUEST_SSP:
>>           if (!kvm_cet_is_msr_accessible(vcpu, msr_info))
>>               return 1;
>> -        kvm_get_xsave_msr(msr_info);
>> +        if (msr_info->index == MSR_KVM_GUEST_SSP)
>> +            msr_info->data = vmcs_readl(GUEST_SSP);
> According to the change of the kvm_cet_is_msr_accessible() below,
> kvm_cet_is_msr_accessible() will return false for MSR_KVM_GUEST_SSP, 
> then this code is unreachable?

No, when the access is initiated from host side, 
kvm_cet_is_msr_accessible() return true for MSR_KVM_GUEST_SSP.

So the code is reachable:

if (msr->host_initiated)

     return true;


[...]