Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <CAH2r5msVBGuRbv2tEuZWLR6_pSNNaoeihx=CjvgZ7NxwCNqZvA@mail.gmail.com>
 <CAHk-=wjuNDG-nu6eAv1vwPuZp=6FtRpK_izmH7aBkc4Cic-uGQ@mail.gmail.com>
 <CAH2r5msZ_8q1b4FHKGZVm_gbiMWuYyaF=_Mz1-gsfJPS0ryRsg@mail.gmail.com>
 <CAHk-=wjYTAK4PSK23bDm_urZ49Q=5m=ScYcmK27ZJNKSBPdbgA@mail.gmail.com> <CAH2r5mssPFZO3XZvws+=C+Gywjs_79bpC0nByeWP5F2T7DWHvw@mail.gmail.com>
In-Reply-To: <CAH2r5mssPFZO3XZvws+=C+Gywjs_79bpC0nByeWP5F2T7DWHvw@mail.gmail.com>
From:   Steve French <smfrench@gmail.com>
Date:   Tue, 23 May 2023 23:27:10 -0500
Message-ID: <CAH2r5muhWo9mV44n8AUQgKX+gpBZ=7sWpn7ns7+EODXDXzofLQ@mail.gmail.com>
Subject: Re: patches to move ksmbd and cifs under new subdirectory
To:     Linus Torvalds <torvalds@linux-foundation.org>
Cc:     CIFS <linux-cifs@vger.kernel.org>,
        samba-technical <samba-technical@lists.samba.org>,
        Namjae Jeon <linkinjeon@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>
Content-Type: multipart/mixed; boundary="0000000000008306ee05fc68eb2e"
Precedence: bulk

--0000000000008306ee05fc68eb2e
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

One more minor change (fs/smb/common/Makefile was missing a two line change=
).
Running automated tests now.

Attached updated patch

On Tue, May 23, 2023 at 9:41=E2=80=AFPM Steve French <smfrench@gmail.com> w=
rote:
>
> Lightly updated (e.g. to include a missing trivial change needed to
> Documentation/filesystems/index.rst that Namjae noticed).  See
> attached.
>
> Presumably can defer the additional cleanup/prettying (ie those beyond
> those required for the directory rename) with distinct patches later.
>
> On Tue, May 23, 2023 at 12:35=E2=80=AFPM Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > On Mon, May 22, 2023 at 11:39=E2=80=AFPM Steve French <smfrench@gmail.c=
om> wrote:
> > >
> > > My reason for adding CONFIG_SMB_CLIENT, enabling CONFIG_SMB_CLIENT
> > > when CONFIG_CIFS was enabled, I was trying to make the Makefile more =
clear
> > > (without changing any behavior):
> >
> > That sounds ok, but I think it should be done separately from the
> > move. Keep the move as a pure move/rename, not "new things".
> >
> > Also, when you actually do this cleanup, I think you really should just=
 do
> >
> >   config SMB
> >         tristate
> >
> >   config SMB_CLIENT
> >         tristate
> >
> > to declare them, but *not* have that
> >
> >         default y if CIFS=3Dy || SMB_SERVER=3Dy
> >         default m if CIFS=3Dm || SMB_SERVER=3Dm
> >
> > kind of noise anywhere. Not for SMBFS, not for SMB_CLIENT.
> >
> > Just do
> >
> >         select SMBFS
> >         select SMB_CLIENT
> >
> > in the current CIFS Kconfig entry. And then SMB_SERVER can likewise do
> >
> >         select SMBFS
> >
> > and I think it will all automatically do what those much more complex
> > "default" expressions currently do.
> >
> > But again - I think this kind of "clean things up" should be entirely
> > separate from the pure code movement. Don't do new functionality when
> > moving things, just do the minimal required infrastructure changes to
> > make things work with the movement.
> >
> >               Linus
>
>
>
> --
> Thanks,
>
> Steve


--=20
Thanks,

Steve

--0000000000008306ee05fc68eb2e
Content-Type: text/x-patch; charset="US-ASCII"; 
	name="0001-smb3-move-Documentation-filesystems-cifs-to-Document.patch"
Content-Disposition: attachment; 
	filename="0001-smb3-move-Documentation-filesystems-cifs-to-Document.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_li17ecct0>
X-Attachment-Id: f_li17ecct0

RnJvbSA0ZjBkMDAzMWNiOTcyMDFmZGFmNGNjYzM2MTkzMTBlMjAwZmFlN2FjIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGV2ZSBGcmVuY2ggPHN0ZnJlbmNoQG1pY3Jvc29mdC5jb20+
CkRhdGU6IE1vbiwgMjIgTWF5IDIwMjMgMDk6NTA6MzMgLTA1MDAKU3ViamVjdDogW1BBVENIXSBz
bWIzOiBtb3ZlIERvY3VtZW50YXRpb24vZmlsZXN5c3RlbXMvY2lmcyB0bwogRG9jdW1lbnRhdGlv
bi9maWxlc3lzdGVtcy9zbWIKCkRvY3VtZW50YXRpb24vZmlsZXN5c3RlbXMvY2lmcyBjb250YWlu
cyBib3RoIHNlcnZlciBhbmQgY2xpZW50IGluZm9ybWF0aW9uCnNvIGl0cyBwYXRobmFtZSBpcyBt
aXNsZWFkaW5nLiAgSW4gYWRkaXRpb24sIHRoZSBkaXJlY3RvcnkgZnMvc21iCm5vdyBjb250YWlu
cyBib3RoIHNlcnZlciBhbmQgY2xpZW50LCBzbyBtb3ZlIERvY3VtZW50YXRpb24vZmlsZXN5c3Rl
bXMvY2lmcwp0byBEb2N1bWVudGF0aW9uL2ZpbGVzeXN0ZW1zL3NtYgoKU3VnZ2VzdGVkLWJ5OiBO
YW1qYWUgSmVvbiA8bGlua2luamVvbkBrZXJuZWwub3JnPgpBY2tlZC1ieTogTmFtamFlIEplb24g
PGxpbmtpbmplb25Aa2VybmVsLm9yZz4KU2lnbmVkLW9mZi1ieTogU3RldmUgRnJlbmNoIDxzdGZy
ZW5jaEBtaWNyb3NvZnQuY29tPgotLS0KIERvY3VtZW50YXRpb24vZmlsZXN5c3RlbXMvaW5kZXgu
cnN0ICAgICAgICAgICAgICAgICAgfCAyICstCiBEb2N1bWVudGF0aW9uL2ZpbGVzeXN0ZW1zL3tj
aWZzID0+IHNtYn0vY2lmc3Jvb3QucnN0IHwgMAogRG9jdW1lbnRhdGlvbi9maWxlc3lzdGVtcy97
Y2lmcyA9PiBzbWJ9L2luZGV4LnJzdCAgICB8IDAKIERvY3VtZW50YXRpb24vZmlsZXN5c3RlbXMv
e2NpZnMgPT4gc21ifS9rc21iZC5yc3QgICAgfCAwCiBNQUlOVEFJTkVSUyAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgMiArLQogNSBmaWxlcyBjaGFuZ2VkLCAyIGlu
c2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCiByZW5hbWUgRG9jdW1lbnRhdGlvbi9maWxlc3lz
dGVtcy97Y2lmcyA9PiBzbWJ9L2NpZnNyb290LnJzdCAoMTAwJSkKIHJlbmFtZSBEb2N1bWVudGF0
aW9uL2ZpbGVzeXN0ZW1zL3tjaWZzID0+IHNtYn0vaW5kZXgucnN0ICgxMDAlKQogcmVuYW1lIERv
Y3VtZW50YXRpb24vZmlsZXN5c3RlbXMve2NpZnMgPT4gc21ifS9rc21iZC5yc3QgKDEwMCUpCgpk
aWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9maWxlc3lzdGVtcy9pbmRleC5yc3QgYi9Eb2N1bWVu
dGF0aW9uL2ZpbGVzeXN0ZW1zL2luZGV4LnJzdAppbmRleCBmYmIyYjVhZGE5NWIuLmViMjUyZmM5
NzJhYSAxMDA2NDQKLS0tIGEvRG9jdW1lbnRhdGlvbi9maWxlc3lzdGVtcy9pbmRleC5yc3QKKysr
IGIvRG9jdW1lbnRhdGlvbi9maWxlc3lzdGVtcy9pbmRleC5yc3QKQEAgLTcyLDcgKzcyLDYgQEAg
RG9jdW1lbnRhdGlvbiBmb3IgZmlsZXN5c3RlbSBpbXBsZW1lbnRhdGlvbnMuCiAgICBiZWZzCiAg
ICBiZnMKICAgIGJ0cmZzCi0gICBjaWZzL2luZGV4CiAgICBjZXBoCiAgICBjb2RhCiAgICBjb25m
aWdmcwpAQCAtMTExLDYgKzExMCw3IEBAIERvY3VtZW50YXRpb24gZm9yIGZpbGVzeXN0ZW0gaW1w
bGVtZW50YXRpb25zLgogICAgcmFtZnMtcm9vdGZzLWluaXRyYW1mcwogICAgcmVsYXkKICAgIHJv
bWZzCisgICBzbWIvaW5kZXgKICAgIHNwdWZzL2luZGV4CiAgICBzcXVhc2hmcwogICAgc3lzZnMK
ZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZmlsZXN5c3RlbXMvY2lmcy9jaWZzcm9vdC5yc3Qg
Yi9Eb2N1bWVudGF0aW9uL2ZpbGVzeXN0ZW1zL3NtYi9jaWZzcm9vdC5yc3QKc2ltaWxhcml0eSBp
bmRleCAxMDAlCnJlbmFtZSBmcm9tIERvY3VtZW50YXRpb24vZmlsZXN5c3RlbXMvY2lmcy9jaWZz
cm9vdC5yc3QKcmVuYW1lIHRvIERvY3VtZW50YXRpb24vZmlsZXN5c3RlbXMvc21iL2NpZnNyb290
LnJzdApkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9maWxlc3lzdGVtcy9jaWZzL2luZGV4LnJz
dCBiL0RvY3VtZW50YXRpb24vZmlsZXN5c3RlbXMvc21iL2luZGV4LnJzdApzaW1pbGFyaXR5IGlu
ZGV4IDEwMCUKcmVuYW1lIGZyb20gRG9jdW1lbnRhdGlvbi9maWxlc3lzdGVtcy9jaWZzL2luZGV4
LnJzdApyZW5hbWUgdG8gRG9jdW1lbnRhdGlvbi9maWxlc3lzdGVtcy9zbWIvaW5kZXgucnN0CmRp
ZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2ZpbGVzeXN0ZW1zL2NpZnMva3NtYmQucnN0IGIvRG9j
dW1lbnRhdGlvbi9maWxlc3lzdGVtcy9zbWIva3NtYmQucnN0CnNpbWlsYXJpdHkgaW5kZXggMTAw
JQpyZW5hbWUgZnJvbSBEb2N1bWVudGF0aW9uL2ZpbGVzeXN0ZW1zL2NpZnMva3NtYmQucnN0CnJl
bmFtZSB0byBEb2N1bWVudGF0aW9uL2ZpbGVzeXN0ZW1zL3NtYi9rc21iZC5yc3QKZGlmZiAtLWdp
dCBhL01BSU5UQUlORVJTIGIvTUFJTlRBSU5FUlMKaW5kZXggOTAyZjc2M2U4NDVkLi42MTUyYTQy
NTFjZTcgMTAwNjQ0Ci0tLSBhL01BSU5UQUlORVJTCisrKyBiL01BSU5UQUlORVJTCkBAIC0xMTMw
MCw3ICsxMTMwMCw3IEBAIFI6CVRvbSBUYWxwZXkgPHRvbUB0YWxwZXkuY29tPgogTDoJbGludXgt
Y2lmc0B2Z2VyLmtlcm5lbC5vcmcKIFM6CU1haW50YWluZWQKIFQ6CWdpdCBnaXQ6Ly9naXQuc2Ft
YmEub3JnL2tzbWJkLmdpdAotRjoJRG9jdW1lbnRhdGlvbi9maWxlc3lzdGVtcy9jaWZzL2tzbWJk
LnJzdAorRjoJRG9jdW1lbnRhdGlvbi9maWxlc3lzdGVtcy9zbWIva3NtYmQucnN0CiBGOglmcy9z
bWIvY29tbW9uLwogRjoJZnMvc21iL3NlcnZlci8KIAotLSAKMi4zNC4xCgo=
--0000000000008306ee05fc68eb2e--