Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Linu Cherian <lcherian@marvell.com>
To:     Mike Leach <mike.leach@linaro.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "coresight@lists.linaro.org" <coresight@lists.linaro.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     "acme@kernel.org" <acme@kernel.org>
Subject: RE: [EXT] [PATCH v6 0/6]  coresight: syscfg: Add config table load
 via configfs
Thread-Topic: [EXT] [PATCH v6 0/6]  coresight: syscfg: Add config table load
 via configfs
Thread-Index: AQHZg9VVfzPoIytoGUiHzRJrqLjF269o6frQ
Date:   Wed, 24 May 2023 04:48:19 +0000
Message-ID: <PH0PR18MB5002D43DD267B8E778EC634DCE419@PH0PR18MB5002.namprd18.prod.outlook.com>
References: <20230511065330.26392-1-mike.leach@linaro.org>
In-Reply-To: <20230511065330.26392-1-mike.leach@linaro.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?d6BN3GTOPONF+w3E4Se6nvaIFtIuS7YDCiQnsIzuujdqENko8XxphG3FuOIK?=
 =?us-ascii?Q?2vHAZ61Ok+ZV9/6AkK+BIqTSAaeQBpJDuf4xGuTw9sl+S7XDDhZoXuCppPxf?=
 =?us-ascii?Q?8M5At2WtOTQ51k/AoonwYwZzGUSwtUxqt1zyZnfzwlY+rtmWW+/Mk3AQQapN?=
 =?us-ascii?Q?gXSyCwVjl7Y5Z0FS48Wvu+B59qbr8HiPHUQp4PrICMTigA3CMO4rZD/pLpyk?=
 =?us-ascii?Q?wMXko/ZD9FQIygk8RmVpqFLYqgfg47gLZCjS2pYrNQkosHL2FsLtezb2nfJD?=
 =?us-ascii?Q?FeJDTy4UQPETSxhpNmU38ydgbK1hrobrMGQH7kEldiTfoKSUlwMA20v9cCf+?=
 =?us-ascii?Q?fOlkfsn09WKj6WTb1/mkx5OJ0AJjr9LXCSPuDAFFR4+0f7dYaz2xPhPxsf8A?=
 =?us-ascii?Q?ZyoxrB4oSo/X1SAHsHJQbbUL2gXddkHEEgjuvzmu11I9CvT6jLz3b2vLT7KB?=
 =?us-ascii?Q?EUbG3IhL5eV6IlcBsM3XHp86rbxlxwG3WrD533+fCWUIUHgf11Hp1PFfmD2J?=
 =?us-ascii?Q?9mNEWA6N4tUaDzFEr06PNSlUgD+HOyE3Erq0rpSRLi2aWaoFUA/KCqSIFZbM?=
 =?us-ascii?Q?YGOV1nDkRr2PLpYZQpVJSxnR8pJVEmub0vjwwC7VjZatR3TsVURdHr0+ditL?=
 =?us-ascii?Q?3RR1Z0zwHlcyu3i9Lb1hAtD51uWfcEpGKZEjLQWgfdD9IUZgYlt6jJyCThjN?=
 =?us-ascii?Q?vlX7uU134BGiy9rJATZFP80hV9KXbHOYuKhF38Alwtqu9RHzFSxe//wsAb1K?=
 =?us-ascii?Q?mY0w0C42moaJLeW970gDD6z6EPaOScftFpDZU4n/UalX8Fd/efdAZTI1lGvF?=
 =?us-ascii?Q?aEwyJiWJuXlnghAYXo1ajmOxAedGqiFpcASmRUh5nuHTL7i0D7MvXz7NGA+g?=
 =?us-ascii?Q?r5wDMrK5FNZvAuMeKjVamDmuCIIFdofV7dPql6OExZ6F6drh1QyGq2KitqN4?=
 =?us-ascii?Q?ItTAHjr1BBwZZXMQgLHlR56Bk8wmE1Xet2xysgERZG/oMPUvPHnYKeypryiV?=
 =?us-ascii?Q?on7bqn1O85XqCvXX9uMwD+/6zH6ipJ50QWvaj0quzAhXWhcEpWpMw26WlzSw?=
 =?us-ascii?Q?m1qKIolBnqyFouUH9S0tcfu8hBLz8xeQKpvQbli9tKc23zYFxv15nJ2X1Rrx?=
 =?us-ascii?Q?+Bk3GBR+TV3YF2pd2482+9M67Of2/rqI3aH8ll1VNO38Y2+SwKXKSZePofz4?=
 =?us-ascii?Q?/tFh7K0H5qYEbOfclATDmf5K6NmrFvV48thL9f0aCx32rmQABV6kF06dj+If?=
 =?us-ascii?Q?cIxL2mc9ASmhYpZ3uusj1kTFMhtBpssWSMMY6jCTEou5nIGkgRlMbsB9z1YB?=
 =?us-ascii?Q?Q6EMVtdSrsz+IxonwySl9Zszz7wR6TiTg2nQOYNX2o4nyDwDijdb5fSUbEkm?=
 =?us-ascii?Q?OT4IMlqC1Ulwgs7w6ECxyfr3LO48T9JMIB09PwfDhHrCVuE6vIl35x4XLCxB?=
 =?us-ascii?Q?WN12GqpIWCcKydeZwy9iaBovffkMb8j5Wi07PlYR4aUUC53YX8FclWOSH6CC?=
 =?us-ascii?Q?AWv0ldfo5EWvT2jX4NKBaYAPBGynO+XftGpWuzYaeEc6VC+uoTAe3FXy4A?=
 =?us-ascii?Q?=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB5002.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 97776fd5-67db-401d-1e41-08db5c1218eb
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2023 04:48:19.9968
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ZVj88fAMjqtbouGK1E/upv2HFnSgs50Lw0Tm9bB6igKtMRuVLvnUxAfcADot/1kUADUFHgC/hU11OUVfiD0M2Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB3894
X-Proofpoint-ORIG-GUID: MPJvcO8Dug77e8zeDdDHaDqHIL_2Q2j3
X-Proofpoint-GUID: MPJvcO8Dug77e8zeDdDHaDqHIL_2Q2j3
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-05-24_01,2023-05-23_02,2023-05-22_02
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Mike,

> -----Original Message-----
> From: Mike Leach <mike.leach@linaro.org>
> Sent: Thursday, May 11, 2023 12:23 PM
> To: linux-arm-kernel@lists.infradead.org; coresight@lists.linaro.org; lin=
ux-
> kernel@vger.kernel.org
> Cc: acme@kernel.org; Mike Leach <mike.leach@linaro.org>
> Subject: [EXT] [PATCH v6 0/6] coresight: syscfg: Add config table load vi=
a
> configfs
>=20
> External Email
>=20
> ----------------------------------------------------------------------
> This set extends the configuration management support to allow loading an=
d
> unloading of configurations as structured tables.
>=20
> The existing coresight configuration configfs API is additionally extende=
d to
> use this table functionality to load and unload configuration tables as b=
inary
> files.
>=20
> This allows coresight configurations to be loaded at runtime, and
> independently of kernel version, without the requirement to re-compile as
> built in kernel modules.
>=20
> Additional attributes - load and unload are provided to in the /config/cs=
-
> syscfg subsytem base group to implement the load functionality.
>=20
> The load attribute is a configfs binary attribute, loading the configurat=
ion
> table in a similar way as the ACPI table binary attribute for that sub-sy=
stem.
>=20
> The configfs binary attribute mechanism supplies a strictly size limited =
kernel
> buffer, providing better safety than other mechnisms, and also has the
> advantage of being accessible directly from the command line, and being p=
art
> of the existing upstream coresight configuration mechanism in configfs
>=20
> Configurations loaded in this way are validated and loaded across the ent=
ire
> system of components atomically. If any part fails to load then the whole
> configuration load will be cancelled.

Currently configuration load is restricted to ETMs alone, CMIIW. Do you hav=
e plans to
extend the generic configuration load support to CTI component as well ?=20

>=20
> Routines to generate binary configuration table files are supplied in
> ./tools/coresight.
>=20
> Example generator and reader applications are provided.
>=20
> Tools may be cross compiled or built for use on host system.
>=20
> Documentation is updated to describe feature usage.
>=20
> Changes since v5:
> 1) Possible memory leak removed.
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <error27@gmail.com>
> 2) Reuse mechanism for reader code revised. (Christoph)
> 3) Unload mechnism now by name in standard attribute, rather than entire
> file
> 4) Mechanism to check last loaded configuration can be unloaded.
> 5) Documentation updates.
>=20
> Changes since v4:
> 1) Update coresight/next - 6.1-rc3
> 2) Update to lockdep fixes to avoid read lock race in configfs.
>=20
> Changes since v3:
> 1) Rebase & tested on coresight/next - 5.19-rc3 - which includes the fix =
patch
> for earlier configfs works.
> 2) Lockdep investigations resulted in re-design of some of the code acces=
sing
> configfs.
> 3) moved load and unload attributes to root of cs-syscfg. (Mathieu)
> 4) Additional minor fixes suggested by Mathieu.
> 5) Memory for configfs loaded and unloaded configurations is now explicit=
ly
> freed.
> 6) LOCKDEP nesting fix for configfs base code (fs/configfs/dir.c)
>=20
> Changes since v2:
> 1) Rebased & tested on coresight/next - 5.18-rc2
> 2) Moved coresight config generator and reader programs from samples to
> tools/coresight. Docs updated to match. (suggested by Mathieu)
> 3) userspace builds now use userspace headers from tools/...
> 4) Other minor fixes from Mathieu's review.
>=20
> Changes since v1:
> 1) Rebased to coresight/next - 5.16-rc1 with previous coresight config se=
t
> applied.
> 2) Makefile.host fixed to default to all target.
>=20
> Mike Leach (6):
>   coresight: config: add config table runtime load functionality
>   coresight: configfs: Update memory allocation / free for configfs
>     elements
>   coresight: configfs: Add attributes to load config tables at runtime
>   coresight: config: extract shared structures to common header file
>   coresight: tools: Add config table file write and reader tools
>   Documentation: coresight: docs for config load via configfs
>=20
>  .../trace/coresight/coresight-config.rst      | 265 ++++++++-
>  MAINTAINERS                                   |   1 +
>  drivers/hwtracing/coresight/Makefile          |   3 +-
>  .../coresight/coresight-config-desc.h         | 105 ++++
>  .../coresight/coresight-config-table.c        | 431 +++++++++++++++
>  .../coresight/coresight-config-table.h        | 151 ++++++
>  .../hwtracing/coresight/coresight-config.h    |  98 +---
>  .../coresight/coresight-syscfg-configfs.c     | 513 ++++++++++++++++--
>  .../coresight/coresight-syscfg-configfs.h     |   5 +
>  .../hwtracing/coresight/coresight-syscfg.c    | 101 +++-
>  .../hwtracing/coresight/coresight-syscfg.h    |   6 +-
>  tools/coresight/Makefile                      |  56 ++
>  tools/coresight/coresight-cfg-bufw.c          | 309 +++++++++++
>  tools/coresight/coresight-cfg-bufw.h          |  26 +
>  tools/coresight/coresight-cfg-example1.c      |  62 +++
>  tools/coresight/coresight-cfg-example2.c      |  95 ++++
>  tools/coresight/coresight-cfg-examples.h      |  25 +
>  tools/coresight/coresight-cfg-file-gen.c      |  61 +++
>  tools/coresight/coresight-cfg-file-read.c     | 227 ++++++++
>  tools/coresight/coresight-config-uapi.h       | 105 ++++
>  20 files changed, 2503 insertions(+), 142 deletions(-)  create mode 1006=
44
> drivers/hwtracing/coresight/coresight-config-desc.h
>  create mode 100644 drivers/hwtracing/coresight/coresight-config-table.c
>  create mode 100644 drivers/hwtracing/coresight/coresight-config-table.h
>  create mode 100644 tools/coresight/Makefile  create mode 100644
> tools/coresight/coresight-cfg-bufw.c
>  create mode 100644 tools/coresight/coresight-cfg-bufw.h
>  create mode 100644 tools/coresight/coresight-cfg-example1.c
>  create mode 100644 tools/coresight/coresight-cfg-example2.c
>  create mode 100644 tools/coresight/coresight-cfg-examples.h
>  create mode 100644 tools/coresight/coresight-cfg-file-gen.c
>  create mode 100644 tools/coresight/coresight-cfg-file-read.c
>  create mode 100644 tools/coresight/coresight-config-uapi.h
>=20
> --
> 2.17.1
>=20
> _______________________________________________
> CoreSight mailing list -- coresight@lists.linaro.org To unsubscribe send =
an
> email to coresight-leave@lists.linaro.org