Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Nicolin Chen <nicolinc@nvidia.com>
CC:     "Liu, Yi L" <yi.l.liu@intel.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "jgg@nvidia.com" <jgg@nvidia.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
        "cohuck@redhat.com" <cohuck@redhat.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
        "yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
        "peterx@redhat.com" <peterx@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "Duan, Zhenzhong" <zhenzhong.duan@intel.com>
Subject: RE: [PATCH v2 01/11] iommu: Add new iommu op to create domains owned
 by userspace
Thread-Topic: [PATCH v2 01/11] iommu: Add new iommu op to create domains owned
 by userspace
Thread-Index: AQHZhBZR9BAjlz4VKEe92tc9klslg69hVLPwgACnKYCABvWhcA==
Date:   Wed, 24 May 2023 05:02:19 +0000
Message-ID: <BN9PR11MB52766A760580E6FBB995A33F8C419@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20230511143844.22693-1-yi.l.liu@intel.com>
 <20230511143844.22693-2-yi.l.liu@intel.com>
 <BL1PR11MB5271B553140BB729AF4389AB8C7C9@BL1PR11MB5271.namprd11.prod.outlook.com>
 <ZGfDrRDI50oGih2r@Asurada-Nvidia>
In-Reply-To: <ZGfDrRDI50oGih2r@Asurada-Nvidia>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MIVIN9eFIXnsjQqpVWuGYQZCtM91XIvAhGRjRq+PpDPZKKdEclldoVffI1KA?=
 =?us-ascii?Q?6lLNqjbA8Gsbf7c8BNDFBRWq7KAc3ED0EqgAAd+zLmO/Aa/KSPpCQUczqQlI?=
 =?us-ascii?Q?tsCJ35rgEUrgyLXiZJdDrVEoa1c65+zf9QctuznvcQeFToDg1LACOb0v2Ute?=
 =?us-ascii?Q?fvauq2yHS4ESDP/n8H7TESTRvVOnD9l0w8DekmeJenQR1a520XGy0gFJ9t7j?=
 =?us-ascii?Q?5Kg+F3NUzXZsdyG1xzBAEZo1e+LO7dCAB8IsjCwskciwd8pejBtTRwmPlqCQ?=
 =?us-ascii?Q?A++AMuthYt6uzSIfC5fe9dcp4h8uzftQTL8MkNySwJml7TlElnSU5bh2B6nm?=
 =?us-ascii?Q?kX1s8bwi7XmMkp79u7wqp5RkvWpnUFG7T8/DSZU1AFVFP2fTZA4A6im8Os3U?=
 =?us-ascii?Q?1OnO+7WM+WntEQNwFXH2rkh7jLT58Wfu2b08CHlrJ5318vWd8688LOkj+Bw1?=
 =?us-ascii?Q?PDMgD+ofIon/zhOWg5QyNTychjmVcSKZaRipF0FYQ2QYX2bFPZEIya1LbsMR?=
 =?us-ascii?Q?DjTJ/FvyBHFZCwOJszrpLlQSIjpmj3XV2VtjlY9Mlwb3yemguQOFNdxcsTXN?=
 =?us-ascii?Q?xlIQaRo8NVMo3Y5uGT8OhXupf9pLxncX+eZWVgDkmTCKftEWYz+rLEe5ZBV2?=
 =?us-ascii?Q?OXLWyipETKVNXcODcXvc2C9Vd4ICyQeCHYi/CCVq/B3zNm6eN/B9b8Z+Ns0J?=
 =?us-ascii?Q?o2XfW0QjJogBaXHkB1pv93M1bbKAOJfJleTFD4td01c4SXz2cDwpRc390N5/?=
 =?us-ascii?Q?PNqyymnO4A+UpPrG4Idx8DloBnUKFGR7wq+oM0ExaF72jhsM0onyAOEAni+T?=
 =?us-ascii?Q?bBvvTCb6+5f2C/LEOlK+piK8POQwnfyoADyjfEZnbzNG7lNyABbwv6Z0nkkU?=
 =?us-ascii?Q?rp3ypzEBZpea1eafcv3lE7rlg7MCDnEj5HyTemSFwgsFlj7Qc6lHGrcFloid?=
 =?us-ascii?Q?SrKK1wSz3iWjXWvScXn32o9tiAhZe1TnIr0i9q2pWjSxAYWoTpxwBVPZ8Dde?=
 =?us-ascii?Q?U0aSiGULvQeBK7BC0AbU0K8IoOxQcd0ZG4ojfMzxzTsDk+7ql0q+A4Scm8NX?=
 =?us-ascii?Q?+Dl6hey3j0nNXB/FKStqaL3I31+LZ/TXAmyaRhbI7lqSpwJyFcsrzeXJ6mKU?=
 =?us-ascii?Q?8z19fB3HCPs303C+J+qy9LAXK7ulAPSxwASPBh5pqWxqL1LrKODlwm3LneCg?=
 =?us-ascii?Q?SH+0PFqbJ16rP2FQekr6TkIshUNiMBhxoSEgykSWK6H1CP4YCNBMVmmdMu/y?=
 =?us-ascii?Q?8C2epopaRidwq3qiZFbyvRZk8U13/ATSc4B1YXbx//GSy2+qrjfRb6GUerqs?=
 =?us-ascii?Q?AlSXY0sEqrh5f/nTqA31x8tYb0pjdXyrGWcAkhgwjD58zrKslL2f96/XELuv?=
 =?us-ascii?Q?7qPLodc82eK9R9Ztf8hbUrVkHlUMS8PBr70H6GK/EjPWXQvKEiM0cUZaGBkW?=
 =?us-ascii?Q?Q5sSU3hyLGIWL3iZmMwSdcLV4wXzChq1vA19HK/l53V82aEKOGhkL6KpSYrU?=
 =?us-ascii?Q?lIJe8JPDZKT4eJKSrJWHm7jbMozfuhLvIzzwxGcUrbbB/E9Q69Btabi+HSWC?=
 =?us-ascii?Q?MkcD8rgx4Y2F7o6DFD5opc1Vo8dgmD0V6BoSX6da?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fb1cd8e1-2d2e-4510-0125-08db5c140d1d
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2023 05:02:19.1923
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FAgyq/okEWAJ373CrNNzq/heCCTN7ivbksHqVpY4qmcGjZ4o3JYSLCxgkWBmYqMchQ92iMw2KE6jFRTVqI11sw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7296
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Nicolin Chen <nicolinc@nvidia.com>
> Sent: Saturday, May 20, 2023 2:45 AM
>=20
> On Fri, May 19, 2023 at 08:47:45AM +0000, Tian, Kevin wrote:
> > > From: Liu, Yi L <yi.l.liu@intel.com>
> > > Sent: Thursday, May 11, 2023 10:39 PM
> > > @@ -229,6 +238,15 @@ struct iommu_iotlb_gather {
> > >   *           after use. Return the data buffer if success, or ERR_PT=
R on
> > >   *           failure.
> > >   * @domain_alloc: allocate iommu domain
> > > + * @domain_alloc_user: allocate user iommu domain
> > > + * @domain_alloc_user_data_len: return the required length of the us=
er
> > > data
> > > + *                              to allocate a specific type user iom=
mu domain.
> > > + *                              @hwpt_type is defined as enum iommu_=
hwpt_type
> > > + *                              in include/uapi/linux/iommufd.h. The=
 returned
> > > + *                              length is the corresponding sizeof d=
river data
> > > + *                              structures in include/uapi/linux/iom=
mufd.h.
> > > + *                              -EOPNOTSUPP would be returned if the=
 input
> > > + *                              @hwpt_type is not supported by the d=
river.
> >
> > Can this be merged with earlier @hw_info callback? That will already
> > report a list of supported hwpt types. is there a problem to further
> > describe the data length for each type in that interface?
>=20
> Yi and I had a last minute talk before he sent this version
> actually... This version of hw_info no longer reports a list
> of supported hwpt types. We previously did that in a bitmap,
> but we found that a bitmap will not be sufficient eventually
> if there are more than 64 hwpt_types.
>=20
> And this domain_alloc_user_data_len might not be necessary,
> because in this version the IOMMUFD core doesn't really care
> about the actual data_len since it copies the data into the
> ucmd_buffer, i.e. we would probably only need a bool op like
> "hwpt_type_is_supported".
>=20

Or just pass to the @domain_alloc_user ops which should fail
if the type is not supported?